renderer: Figure out attachment points with switch command.

Author: heinezen

libopenage/renderer/opengl/framebuffer.cpp

@@ -1,4 +1,4 @@
-// Copyright 2017-2024 the openage authors. See copying.md for legal info.
+// Copyright 2017-2025 the openage authors. See copying.md for legal info.
 
 #include "framebuffer.h"
 
@@ -30,26 +30,42 @@ GlFramebuffer::GlFramebuffer(const std::shared_ptr<GlContext> &context,
 
 	glBindFramebuffer(GL_FRAMEBUFFER, handle);
 
-	std::vector<GLenum> drawBuffers;
+	std::vector<GLenum> draw_buffers;
 
 	if (textures.empty()) {
 		throw Error{ERR << "At least 1 texture must be assigned to texture framebuffer."};
 	}
 
-	size_t colorTextureCount = 0;
+	size_t color_texture_count = 0;
+	size_t depth_texture_count = 0;
 	for (auto const &texture : textures) {
-		// TODO figure out attachment points from pixel formats
-		if (texture->get_info().get_format() == resources::pixel_format::depth24) {
+		auto fmt = texture->get_info().get_format();
+		switch (fmt) {
+		case resources::pixel_format::depth24:
+			depth_texture_count += 1;
+			if (depth_texture_count > 1) {
+				log::log(WARN << "Framebuffer already has one depth texture attached. "
+				              << "Assignment of additional depth texture ignored.");
+				break;
+			}
 			glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, texture->get_handle(), 0);
-		}
-		else {
-			auto attachmentPoint = GL_COLOR_ATTACHMENT0 + colorTextureCount++;
-			glFramebufferTexture2D(GL_FRAMEBUFFER, attachmentPoint, GL_TEXTURE_2D, texture->get_handle(), 0);
-			drawBuffers.push_back(attachmentPoint);
+			break;
+		case resources::pixel_format::r16ui:
+		case resources::pixel_format::r32ui:
+		case resources::pixel_format::rgba8:
+		case resources::pixel_format::rgb8:
+		case resources::pixel_format::bgr8:
+		case resources::pixel_format::rgba8ui: {
+			auto attachment_point = GL_COLOR_ATTACHMENT0 + color_texture_count++;
+			glFramebufferTexture2D(GL_FRAMEBUFFER, attachment_point, GL_TEXTURE_2D, texture->get_handle(), 0);
+			draw_buffers.push_back(attachment_point);
+		} break;
+		default:
+			throw Error{ERR << "Unsupported pixel format for framebuffer texture."};
 		}
 	}
 
-	glDrawBuffers(drawBuffers.size(), drawBuffers.data());
+	glDrawBuffers(draw_buffers.size(), draw_buffers.data());
 
 	if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) {
 		throw Error(MSG(err) << "Could not create OpenGL framebuffer.");