Apply clippy suggestions

Author: FlrnFrmm

behavioral/command/command/copy.rs

@@ -14,7 +14,7 @@ impl Command for CopyCommand {
         context.clipboard = editor.get_content().to_string();
 
         app.set_user_data(context);
-        return false;
+        false
     }
 
     fn undo(&mut self, _: &mut Cursive) {}

behavioral/command/command/cut.rs

@@ -18,7 +18,7 @@ impl Command for CutCommand {
             editor.set_content("".to_string());
         });
 
-        return true;
+        true
     }
 
     fn undo(&mut self, app: &mut Cursive) {

behavioral/command/command/paste.rs

@@ -17,7 +17,7 @@ impl Command for PasteCommand {
             editor.set_content(context.clipboard.clone());
         });
 
-        return true;
+        true
     }
 
     fn undo(&mut self, app: &mut Cursive) {

behavioral/command/main.rs

@@ -26,7 +26,7 @@ fn main() {
             .button("Copy", |s| execute(s, CopyCommand::default()))
             .button("Cut", |s| execute(s, CutCommand::default()))
             .button("Paste", |s| execute(s, PasteCommand::default()))
-            .button("Undo", |s| undo(s))
+            .button("Undo", undo)
             .button("Quit", |s| s.quit()),
     );
 

behavioral/mediator/train_station.rs

@@ -19,10 +19,10 @@ impl Mediator for TrainStation {
     fn notify_about_arrival(&mut self, train_name: &str) -> bool {
         if self.train_on_platform.is_some() {
             self.train_queue.push_back(train_name.into());
-            return false;
+            false
         } else {
             self.train_on_platform.replace(train_name.into());
-            return true;
+            true
         }
     }
 
@@ -53,7 +53,7 @@ impl TrainStation {
     }
 
     pub fn depart(&mut self, name: &'static str) {
-        let train = self.trains.remove(name.into());
+        let train = self.trains.remove(name);
         if let Some(mut train) = train {
             train.depart(self);
         } else {

creational/abstract-factory/main_dyn.rs

@@ -6,7 +6,7 @@ mod gui;
 
 /// The client code calls the creation methods of a factory object instead of
 /// creating products directly with a constructor call.
-fn render(factory: &Box<dyn gui::GuiFactoryDynamic>) {
+fn render(factory: &dyn gui::GuiFactoryDynamic) {
     let button1 = factory.create_button();
     let button2 = factory.create_button();
     let checkbox1 = factory.create_checkbox();
@@ -24,16 +24,16 @@ fn main() {
     let windows = false;
 
     // Allocate a factory object in runtime depending on unpredictable input.
-    let factory: Box<dyn gui::GuiFactoryDynamic> = if windows {
-        Box::new(WindowsFactory)
+    let factory: &dyn gui::GuiFactoryDynamic = if windows {
+        &WindowsFactory
     } else {
-        Box::new(MacFactory)
+        &MacFactory
     };
 
     // Factory invocation can be inlined right here then.
     let button = factory.create_button();
     button.press();
 
     // Factory object can be passed to a function as a parameter.
-    render(&factory);
+    render(factory);
 }

creational/builder/main.rs

@@ -30,5 +30,5 @@ fn main() {
 
     // The final car manual.
     let manual: Manual = manual_builder.build();
-    println!("Car manual built:\n{}", manual.to_string());
+    println!("Car manual built:\n{}", manual);
 }

structural/decorator/main.rs

@@ -14,5 +14,5 @@ fn main() {
         print!("{}", char::from(byte));
     }
 
-    println!("");
+    println!();
 }

structural/facade/main.rs

@@ -9,12 +9,12 @@ use wallet_facade::WalletFacade;
 
 fn main() -> Result<(), String> {
     let mut wallet = WalletFacade::new("abc".into(), 1234);
-    println!("");
+    println!();
 
     // Wallet Facade interacts with the account, code, wallet, notification and
     // ledger behind the scenes.
     wallet.add_money_to_wallet(&"abc".into(), 1234, 10)?;
-    println!("");
+    println!();
 
     wallet.deduct_money_from_wallet(&"abc".into(), 1234, 5)
 }

structural/flyweight/forest.rs

@@ -26,7 +26,7 @@ pub struct Forest {
 
 impl Forest {
     pub fn plant_tree(&mut self, x: u32, y: u32, color: TreeColor, name: String, data: String) {
-        let tree_kind = TreeKind::new(color, name.clone(), data);
+        let tree_kind = TreeKind::new(color, name, data);
 
         // Here is an essence of Flyweight: it's an internal cache,
         // there is always a single instance of a "tree kind" structure.

structural/proxy/server.rs

@@ -4,5 +4,5 @@ mod nginx;
 pub use nginx::NginxServer;
 
 pub trait Server {
-    fn handle_request(&mut self, url: &String, method: &str) -> (u16, String);
+    fn handle_request(&mut self, url: &str, method: &str) -> (u16, String);
 }

structural/proxy/server/application.rs

@@ -3,7 +3,7 @@ use super::Server;
 pub struct Application;
 
 impl Server for Application {
-    fn handle_request(&mut self, url: &String, method: &str) -> (u16, String) {
+    fn handle_request(&mut self, url: &str, method: &str) -> (u16, String) {
         if url == "/app/status" && method == "GET" {
             return (200, "Ok".into());
         }

structural/proxy/server/nginx.rs

@@ -18,24 +18,24 @@ impl NginxServer {
         }
     }
 
-    pub fn check_rate_limiting(&mut self, url: &String) -> bool {
-        let rate = self.rate_limiter.entry(url.clone()).or_insert(1);
+    pub fn check_rate_limiting(&mut self, url: &str) -> bool {
+        let rate = self.rate_limiter.entry(url.to_string()).or_insert(1);
 
         if *rate > self.max_allowed_requests {
             return false;
         }
 
         *rate += 1;
-        return true;
+        true
     }
 }
 
 impl Server for NginxServer {
-    fn handle_request(&mut self, url: &String, method: &str) -> (u16, String) {
+    fn handle_request(&mut self, url: &str, method: &str) -> (u16, String) {
         if !self.check_rate_limiting(url) {
             return (403, "Not Allowed".into());
         }
 
-        return self.application.handle_request(url, method);
+        self.application.handle_request(url, method)
     }
 }