Skip to content

Commit 3147597

Browse files
committed
Add some code tweaks
1 parent adf48e1 commit 3147597

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/app/models/key-models/bfkey.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,13 @@ void BloomFilterKeyModel::loadRows(QVariant, unsigned long,
4444
return callback(err, 0);
4545
};
4646

47-
auto responseHandler = [this, callback](RedisClient::Response r, Callback) {
47+
auto responseHandler = [this, callback](const RedisClient::Response& r, Callback) {
4848
m_rowsCache.clear();
4949
auto value = r.value().toList();
5050

5151
QVariantMap row;
5252

53-
for (QVariantList::const_iterator item = value.cbegin(); item != value.cend();
54-
++item) {
53+
for (auto item = value.cbegin(); item != value.cend(); ++item) {
5554
auto key = item->toByteArray();
5655
++item;
5756

src/app/models/key-models/bfkey.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,16 @@ class BloomFilterKeyModel : public KeyModel<QVariant> {
1212
QVariant getData(int rowIndex, int dataRole) override;
1313

1414
void addRow(const QVariantMap&, Callback c) override;
15+
1516
virtual void updateRow(int, const QVariantMap&,
16-
Callback) override {}
17+
Callback) override {
18+
// NOTE(u_glide): BF/CF is read-only
19+
}
1720
void loadRows(QVariant, unsigned long, LoadRowsCallback callback) override;
18-
void removeRow(int, Callback) override {}
21+
22+
void removeRow(int, Callback) override {
23+
// NOTE(u_glide): BF/CF is read-only
24+
}
1925

2026
virtual unsigned long rowsCount() override { return m_rowCount; }
2127

0 commit comments

Comments
 (0)