Skip to content

Commit a23a9ba

Browse files
authored
Merge pull request #78 from KevM/swift-3-fixes
Fixes to Swift 3 branch for @escaping and Task method label compatibility
2 parents fb4af8a + 3a81e29 commit a23a9ba

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

SwiftTask/SwiftTask.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
6767
public typealias RejectHandler = (Error) -> Void
6868
public typealias Configuration = TaskConfiguration
6969

70-
public typealias PromiseInitClosure = (_ fulfill: FulfillHandler, _ reject: RejectHandler) -> Void
70+
public typealias PromiseInitClosure = (_ fulfill: @escaping FulfillHandler, _ reject: @escaping RejectHandler) -> Void
7171
public typealias InitClosure = (_ progress: @escaping ProgressHandler, _ fulfill: @escaping FulfillHandler, _ reject: @escaping RejectHandler, _ configure: TaskConfiguration) -> Void
7272

7373
internal typealias _Machine = _StateMachine<Progress, Value, Error>
@@ -356,7 +356,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
356356
/// - Note: `oldProgress` is always nil when `weakified = true`
357357
/// - Returns: Self (same `Task`)
358358
///
359-
@discardableResult public func progress(progressClosure: @escaping (ProgressTuple) -> Void) -> Self
359+
@discardableResult public func progress(_ progressClosure: @escaping (ProgressTuple) -> Void) -> Self
360360
{
361361
var dummyCanceller: Canceller? = nil
362362
return self.progress(&dummyCanceller, progressClosure)
@@ -382,7 +382,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
382382
///
383383
/// - Returns: New `Task`
384384
///
385-
@discardableResult public func then<Value2>(thenClosure: @escaping (Value?, ErrorInfo?) -> Value2) -> Task<Progress, Value2, Error>
385+
@discardableResult public func then<Value2>(_ thenClosure: @escaping (Value?, ErrorInfo?) -> Value2) -> Task<Progress, Value2, Error>
386386
{
387387
var dummyCanceller: Canceller? = nil
388388
return self.then(&dummyCanceller, thenClosure)
@@ -403,7 +403,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
403403
///
404404
/// - Returns: New `Task`
405405
///
406-
public func then<Progress2, Value2, Error2>(thenClosure: @escaping (Value?, ErrorInfo?) -> Task<Progress2, Value2, Error2>) -> Task<Progress2, Value2, Error2>
406+
public func then<Progress2, Value2, Error2>(_ thenClosure: @escaping (Value?, ErrorInfo?) -> Task<Progress2, Value2, Error2>) -> Task<Progress2, Value2, Error2>
407407
{
408408
var dummyCanceller: Canceller? = nil
409409
return self.then(&dummyCanceller, thenClosure)
@@ -462,7 +462,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
462462
///
463463
/// - Returns: New `Task`
464464
///
465-
@discardableResult public func success<Value2>(successClosure: @escaping (Value) -> Value2) -> Task<Progress, Value2, Error>
465+
@discardableResult public func success<Value2>(_ successClosure: @escaping (Value) -> Value2) -> Task<Progress, Value2, Error>
466466
{
467467
var dummyCanceller: Canceller? = nil
468468
return self.success(&dummyCanceller, successClosure)
@@ -483,7 +483,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
483483
///
484484
/// - Returns: New `Task`
485485
///
486-
public func success<Progress2, Value2, Error2>(successClosure: @escaping (Value) -> Task<Progress2, Value2, Error2>) -> Task<Progress2, Value2, Error>
486+
public func success<Progress2, Value2, Error2>(_ successClosure: @escaping (Value) -> Task<Progress2, Value2, Error2>) -> Task<Progress2, Value2, Error>
487487
{
488488
var dummyCanceller: Canceller? = nil
489489
return self.success(&dummyCanceller, successClosure)
@@ -519,7 +519,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
519519
///
520520
/// - Returns: New `Task`
521521
///
522-
@discardableResult public func failure(failureClosure: @escaping (ErrorInfo) -> Value) -> Task
522+
@discardableResult public func failure(_ failureClosure: @escaping (ErrorInfo) -> Value) -> Task
523523
{
524524
var dummyCanceller: Canceller? = nil
525525
return self.failure(&dummyCanceller, failureClosure)
@@ -541,7 +541,7 @@ open class Task<Progress, Value, Error>: Cancellable, CustomStringConvertible
541541
///
542542
/// - Returns: New `Task`
543543
///
544-
public func failure<Progress2, Error2>(failureClosure: @escaping (ErrorInfo) -> Task<Progress2, Value, Error2>) -> Task<Progress2, Value, Error2>
544+
public func failure<Progress2, Error2>(_ failureClosure: @escaping (ErrorInfo) -> Task<Progress2, Value, Error2>) -> Task<Progress2, Value, Error2>
545545
{
546546
var dummyCanceller: Canceller? = nil
547547
return self.failure(&dummyCanceller, failureClosure)

0 commit comments

Comments
 (0)