feat(YouTube - Playback Speed): Use modern custom speed dialog (#5069)

Co-authored-by: LisoUseInAIKyrios <[email protected]>

Author: MarcaDian

extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/requests/PlayerRoutes.java

@@ -71,9 +71,7 @@ static String createInnertubeBody(ClientType clientType, String videoId) {
         return innerTubeBody.toString();
     }
 
-    /**
-     * @noinspection SameParameterValue
-     */
+    @SuppressWarnings("SameParameterValue")
     static HttpURLConnection getPlayerResponseConnectionFromRoute(Route.CompiledRoute route, ClientType clientType) throws IOException {
         var connection = Requester.getConnectionFromCompiledRoute(YT_API_URL, route);
 

extensions/youtube/src/main/java/app/revanced/extension/youtube/ThemeHelper.java

@@ -105,6 +105,14 @@ public static int getForegroundColor() {
         return isDarkTheme() ? getLightThemeColor() : getDarkThemeColor();
     }
 
+    public static int getDialogBackgroundColor() {
+        final String colorName = isDarkTheme()
+                ? "yt_black1"
+                : "yt_white1";
+
+        return Utils.getColorFromString(colorName);
+    }
+
     public static int getToolbarBackgroundColor() {
         final String colorName = isDarkTheme()
                 ? "yt_black3"

extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/AlternativeThumbnailsPatch.java

@@ -686,7 +686,7 @@ static DecodedThumbnailUrl decodeImageUrl(String url) {
                     ? "" : fullUrl.substring(imageExtensionEndIndex);
         }
 
-        /** @noinspection SameParameterValue */
+        @SuppressWarnings("SameParameterValue")
         String createStillsUrl(@NonNull ThumbnailQuality qualityToUse, boolean includeViewTracking) {
             // Images could be upgraded to webp if they are not already, but this fails quite often,
             // especially for new videos uploaded in the last hour.

extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/ReturnYouTubeDislikePatch.java

@@ -365,6 +365,11 @@ public static void preloadVideoId(@NonNull String videoId, boolean isShortAndOpe
             if (videoId.equals(lastPrefetchedVideoId)) {
                 return;
             }
+            if (!Utils.isNetworkConnected()) {
+                Logger.printDebug(() -> "Cannot pre-fetch RYD, network is not connected");
+                lastPrefetchedVideoId = null;
+                return;
+            }
 
             final boolean videoIdIsShort = VideoInformation.lastPlayerResponseIsShort();
             // Shorts shelf in home and subscription feed causes player response hook to be called,
@@ -419,6 +424,12 @@ public static void newVideoLoaded(@NonNull String videoId) {
             }
             Logger.printDebug(() -> "New video id: " + videoId + " playerType: " + currentPlayerType);
 
+            if (!Utils.isNetworkConnected()) {
+                Logger.printDebug(() -> "Cannot fetch RYD, network is not connected");
+                currentVideoData = null;
+                return;
+            }
+
             ReturnYouTubeDislike data = ReturnYouTubeDislike.getFetchForVideoId(videoId);
             // Pre-emptively set the data to short status.
             // Required to prevent Shorts data from being used on a minimized video in incognito mode.

extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/VideoInformation.java

@@ -354,4 +354,23 @@ public static boolean isAtEndOfVideo() {
         return videoTime >= videoLength && videoLength > 0;
     }
 
+    /**
+     * Overrides the current playback speed.
+     * Rest of the implementation added by patch.
+     */
+    public static void overridePlaybackSpeed(float speedOverride) {
+        Logger.printDebug(() -> "Overriding playback speed to: " + speedOverride);
+    }
+
+    /**
+     * Injection point.
+     *
+     * @param newlyLoadedPlaybackSpeed The current playback speed.
+     */
+    public static void setPlaybackSpeed(float newlyLoadedPlaybackSpeed) {
+        if (playbackSpeed != newlyLoadedPlaybackSpeed) {
+            Logger.printDebug(() -> "Video speed changed: " + newlyLoadedPlaybackSpeed);
+            playbackSpeed = newlyLoadedPlaybackSpeed;
+        }
+    }
 }

extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/PlaybackSpeedMenuFilterPatch.java

@@ -10,41 +10,25 @@
  */
 public final class PlaybackSpeedMenuFilterPatch extends Filter {
 
-    /**
-     * Old litho based speed selection menu.
-     */
-    public static volatile boolean isOldPlaybackSpeedMenuVisible;
-
     /**
      * 0.05x speed selection menu.
      */
     public static volatile boolean isPlaybackRateSelectorMenuVisible;
 
-    private final StringFilterGroup oldPlaybackMenuGroup;
-
     public PlaybackSpeedMenuFilterPatch() {
         // 0.05x litho speed menu.
         var playbackRateSelectorGroup = new StringFilterGroup(
                 Settings.CUSTOM_SPEED_MENU,
                 "playback_rate_selector_menu_sheet.eml-js"
         );
 
-        // Old litho based speed menu.
-        oldPlaybackMenuGroup = new StringFilterGroup(
-                Settings.CUSTOM_SPEED_MENU,
-                "playback_speed_sheet_content.eml-js");
-
-        addPathCallbacks(playbackRateSelectorGroup, oldPlaybackMenuGroup);
+        addPathCallbacks(playbackRateSelectorGroup);
     }
 
     @Override
     boolean isFiltered(@Nullable String identifier, String path, byte[] protobufBufferArray,
                        StringFilterGroup matchedGroup, FilterContentType contentType, int contentIndex) {
-        if (matchedGroup == oldPlaybackMenuGroup) {
-            isOldPlaybackSpeedMenuVisible = true;
-        } else {
-            isPlaybackRateSelectorMenuVisible = true;
-        }
+        isPlaybackRateSelectorMenuVisible = true;
 
         return false;
     }