Merge pull request SciTools#2263 from greglucas/move-feature-download-script

MNT: Move cartopy feature download script into the package

Author: QuLogic

.github/workflows/ci-testing.yml

@@ -72,7 +72,9 @@ jobs:
         shell: bash
         run: |
           # Check that the downloader tool at least knows where to get the data from (but don't actually download it)
-          python tools/cartopy_feature_download.py gshhs physical --dry-run
+          python -m cartopy.feature.download gshhs physical --dry-run
+          # It should also be available as a script
+          cartopy_feature_download gshhs physical --dry-run
           CARTOPY_GIT_DIR=$PWD
           pytest -ra -n 4 \
               --color=yes \

tools/cartopy_feature_download.py renamed to lib/cartopy/feature/download/__main__.py

@@ -10,7 +10,7 @@
 
 For detail on how to use this tool, execute it with the `-h` option:
 
-    python cartopy_feature_download.py -h
+    python -m cartopy.feature.download -h
 
 """
 
@@ -107,7 +107,7 @@ def download_features(group_names, dry_run=True):
                               ''.format(category, name, scale, len(geoms)))
 
 
-if __name__ == '__main__':
+def main():
     parser = argparse.ArgumentParser(description='Download feature datasets.')
     parser.add_argument('group_names', nargs='+',
                         choices=FEATURE_DEFN_GROUPS,
@@ -146,3 +146,7 @@ def download_features(group_names, dry_run=True):
     config['downloaders'][SHP_NE_SPEC].url_template = URL_TEMPLATE
 
     download_features(args.group_names, dry_run=args.dry_run)
+
+
+if __name__ == '__main__':
+    main()

pyproject.toml

@@ -58,7 +58,7 @@ srtm = ["beautifulsoup4"]
 test = ["pytest>=5.1.2", "pytest-mpl>=0.11", "pytest-xdist", "pytest-cov", "coveralls"]
 
 [project.scripts]
-feature_download = "tools.cartopy_feature_download.py:__main__"
+cartopy_feature_download = "cartopy.feature.download.__main__:main"
 
 [project.urls]
 documentation='https://scitools.org.uk/cartopy/docs/latest/'