Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Dec 6, 2025

Issue

Fixes #7245

PR #7248 missed two std::is_trivial instances that use the ::value syntax (in fingerprint.hpp and edge_based_graph_factory.hpp).

Also, combining multiple type traits with && triggers a false positive from clang-tidy's misc-redundant-expression check. This PR splits all combined static_assert conditions into separate statements to fix the CI failure.

Changes

  • Replace remaining std::is_trivial with std::is_trivially_default_constructible + std::is_trivially_copyable
  • Split combined static_assert conditions to avoid clang-tidy warning
  • Fix typo: "needs have" -> "needs to have"

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber afarber changed the title Replace remaining std::is_trivial instances Fix std::is_trivial deprecation and clang-tidy warnings Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated std::is_trivial

1 participant