From ccb18ff21d68abb5a294f858a661124d68380271 Mon Sep 17 00:00:00 2001 From: Andy Jordan <2226434+andyleejordan@users.noreply.github.com> Date: Wed, 14 May 2025 11:02:55 -0700 Subject: [PATCH] Update recommended PowerShell LTS --- docs/troubleshooting.md | 4 ++-- test/features/UpdatePowerShell.test.ts | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md index c6ccb7dbdc..4c2b6195dd 100644 --- a/docs/troubleshooting.md +++ b/docs/troubleshooting.md @@ -15,7 +15,7 @@ active editor's language mode is PowerShell. ### Using Windows PowerShell 5.1 -While we _highly encourage_ the use of [PowerShell Core 7.2][], if you must use Windows +While we _highly encourage_ the use of [PowerShell 7.4 LTS][], if you must use Windows PowerShell 5.1 we attempt to support it on a best-effort basis. Unfortunately, being two major versions behind and in maintenance mode, Windows PowerShell is missing many of the bug fixes and APIs we use to make the extension experience great. So please, if you can, @@ -410,7 +410,7 @@ WSManStackVersion 3.0 [more information]: #providing-information-about-your-environment [open a new issue]: https://github.com/PowerShell/vscode-powershell/issues/new/choose [open an issue there]: https://github.com/PowerShell/PSScriptAnalyzer/issues/new/choose -[PowerShell Core 7.2]: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.2 +[PowerShell 7.4 LTS]: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.4 [semantic highlighting]: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide [tackling an issue]: ./development.md [v2021.2.2]: https://github.com/PowerShell/vscode-powershell/releases/tag/v2021.2.2 diff --git a/test/features/UpdatePowerShell.test.ts b/test/features/UpdatePowerShell.test.ts index b2b6efe90e..6023e56bbd 100644 --- a/test/features/UpdatePowerShell.test.ts +++ b/test/features/UpdatePowerShell.test.ts @@ -128,7 +128,9 @@ describe("UpdatePowerShell feature", function () { // @ts-expect-error method is private. const tag: string | undefined = await updater.maybeGetNewRelease(); // NOTE: This will need to be updated each new major stable. - assert(tag?.startsWith("v7.5")); + // TODO: Upstream bug causes LTS releases to update the stable info. + // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing + assert(tag?.startsWith("v7.5") || tag?.startsWith("v7.4")); }); }); });