Fix NullReferenceException when processing event subscribers (#3781)

daxian-dbw · web-flow · commit 4e456f020579 · 2023-08-17T09:37:47.000-07:00
diff --git a/PSReadLine/ReadLine.cs b/PSReadLine/ReadLine.cs
@@ -210,7 +210,7 @@ internal static PSKeyInfo ReadKey()
                         bool runPipelineForEventProcessing = false;
                         foreach (var sub in eventSubscribers)
                         {
-                            if (sub.SourceIdentifier.Equals(PSEngineEvent.OnIdle, StringComparison.OrdinalIgnoreCase))
+                            if (string.Equals(sub.SourceIdentifier, PSEngineEvent.OnIdle, StringComparison.OrdinalIgnoreCase))
                             {
                                 // If the buffer is not empty, let's not consider we are idle because the user is in the middle of typing something.
                                 if (_singleton._buffer.Length > 0)

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ internal static PSKeyInfo ReadKey()`
`210`	`210`	`bool runPipelineForEventProcessing = false;`
`211`	`211`	`foreach (var sub in eventSubscribers)`
`212`	`212`	`{`
`213`		`- if (sub.SourceIdentifier.Equals(PSEngineEvent.OnIdle, StringComparison.OrdinalIgnoreCase))`
	`213`	`+ if (string.Equals(sub.SourceIdentifier, PSEngineEvent.OnIdle, StringComparison.OrdinalIgnoreCase))`
`214`	`214`	`{`
`215`	`215`	`// If the buffer is not empty, let's not consider we are idle because the user is in the middle of typing something.`
`216`	`216`	`if (_singleton._buffer.Length > 0)`