Text Files Formatting test should fail on UTF16 files

[PlagueHO]

This test should if a MOF file is set to UTF16.

See:
dsccommunity/WebAdministrationDsc#136 (comment)

for more context.

[nzspambot]

a cursory test suggests this may work better

$allTextFiles = Get-TextFilesList .


C:\Users\jamesb\Dropbox\GitHub\nzspambot\Fiddle> function Get-FileEncoding
{
    [CmdletBinding()] Param (
        [Parameter(Mandatory = $True, ValueFromPipelineByPropertyName = $True)]
                [string]$Path
    )

    [byte[]]$byte = get-content -Encoding byte -ReadCount 4 -TotalCount 4 -Path $Path

    if ( $byte[0] -eq 0xd -and $byte[1] -eq 0xa)
    { Write-Output 'UTF8' }
    elseif ($byte[0] -eq 0xef -and $byte[1] -eq 0xbb -and $byte[2] -eq 0xbf)
    { Write-Output 'UTF8BOM'}
    elseif ($byte[0] -eq 0xff -and $byte[1] -eq 0xfe)
    { Write-Output 'UTF16LE' }
    elseif ($byte[0] -eq 0xfe -and $byte[1] -eq 0xff)
    { Write-Output 'UTF16BE'}
    else
    { Write-Output 'ASCII' }
}

$allTextFiles | % { write-output "$_"; Get-FileEncoding $_ }
testscript.ps1
UTF8BOM
utf16BE.schema.mof
UTF16BE
utf16LE.schema.mof
UTF16LE
utf8.schema.mof
UTF8
utf8withBOM.schema.mof
UTF8BOM

[johlju]

@PlagueHO I saw this issue now. Maybe we should change the function Test-FileHasByteOrderMark to what @nzspambot suggest (replace with Test-FileIsUtf8WithoutByteOrderMark function), and change all the "BOM"-tests to "file is not UTF-8"-tests?

[PlagueHO]

@johlju - I'd completed forgotten about this one - and missed @nzspambot 's comment! Doh! But I think we should add this code as a helper function and then we could recreate some of the tests to ensure the correct encoding is always included.