Remove the workaround code that was added for the missing AppVeyor cmdlet

[johlju]

Details of the problem, bug, or enhancement

It looks like the cmdlet Add-AppveyorTest now should work on PS Core since the issue appveyor/ci#2263 was closed. I have not tested. But if it works, then the following code could be simplified.

DscResource.Tests/AppVeyor.psm1

Lines 854 to 881 in ab96f03

	if ($PSVersionTable.PSEdition -eq 'Core')
	{
	$requestObject = @{
	testName = $addAppVeyorTestParameters.Name
	testFramework = $addAppVeyorTestParameters.Framework
	fileName = $addAppVeyorTestParameters.Filename
	outcome = $addAppVeyorTestParameters.Outcome
	durationMilliseconds = $addAppVeyorTestParameters.Duration
	}
	if ($result.FailureMessage)
	{
	$requestObject['ErrorMessage'] = $addAppVeyorTestParameters.ErrorMessage
	$requestObject['ErrorStackTrace'] = $addAppVeyorTestParameters.ErrorStackTrace
	}
	<#
	ConvertTo-Json will handle all escaping for us, like escaping
	double quotes and backslashes.
	#>
	$requestBody = $requestObject | ConvertTo-Json
	Invoke-RestMethod -Method Post -Uri "$env:APPVEYOR_API_URL/api/tests" -Body $requestBody -ContentType 'application/json' | Out-Null
	}
	else
	{
	Add-AppveyorTest @addAppVeyorTestParameters
	}

Verbose logs showing the problem (if applicable)

n/a

Suggested solution to the issue

Remove the workaround code that was added for the missing AppVeyor cmdlet.

[stale]

This issue has been automatically marked as stale because it has not had activity from the community in the last 30 days. It will be closed if no further activity occurs within 10 days. If the issue is labelled with any of the work labels (e.g bug, enhancement, documentation, or tests) then the issue will not auto-close.

[johlju]

I’m planning on fixing this, just haven’t had time yet with vacation and a lot of work at the day job.
Hoping to get a few hours to DSC next week. :)

[stale]

This issue has been automatically marked as stale because it has not had activity from the community in the last 30 days. It will be closed if no further activity occurs within 10 days. If the issue is labelled with any of the work labels (e.g bug, enhancement, documentation, or tests) then the issue will not auto-close.

[johlju]

This should be done to remove unnecessary code.

@PlagueHO can you please tag this issue accordingly?