Skip to content

Commit 3263da2

Browse files
pearsonradukptfh
authored andcommitted
fix: use qualifier name for formatting conversion service
- Use `feignConversionService` qualifier name for `reactiveFeignContract` bean - If qualified name is not used it will conflict with Spring's predefined conversion service - `Caused by: org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.springframework.format.support.FormattingConversionService' available: expected single matching bean but found 2: feignConversionService,webFluxConversionService` - See https://github.com/spring-projects/spring-boot/blob/f88f8f26fde93df292e1b50a490768058c67b127/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java#L283
1 parent fb2c964 commit 3263da2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

feign-reactor-spring-configuration/src/main/java/reactivefeign/spring/config/ReactiveFeignClientsConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import feign.Contract;
2121
import org.springframework.beans.factory.annotation.Autowired;
22+
import org.springframework.beans.factory.annotation.Qualifier;
2223
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2324
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2425
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
@@ -65,7 +66,7 @@ public class ReactiveFeignClientsConfiguration {
6566
@Bean
6667
@ConditionalOnMissingBean
6768
public Contract reactiveFeignContract(
68-
List<AnnotatedParameterProcessor> parameterProcessors, FormattingConversionService feignConversionService) {
69+
List<AnnotatedParameterProcessor> parameterProcessors, @Qualifier("feignConversionService") FormattingConversionService feignConversionService) {
6970
return new SpringMvcContract(parameterProcessors, feignConversionService);
7071
}
7172

0 commit comments

Comments
 (0)