Skip to content

Commit 4ef64bd

Browse files
committed
hints/darwin.sh: skip ldflags in lddlflags
It has not effect. "adopting flags from ldflags is supposed to happen in Configure, not in hints." - leont Configuring a build of perl with -Aappend:ldflags=" -L/var/empty" and checking the output of 'perl -V:ldflags -V:lddlflags' shows ldflags=' -L/var/empty'; lddlflags='-bundle -undefined dynamic_lookup -L/var/empty'; Found when analysing issue #9437 Tested on OS X 10.4 aka Darwin 8.
1 parent a7c61e7 commit 4ef64bd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

hints/darwin.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,18 +277,18 @@ add_macosx_version_min () {
277277
# But starting from perl 5.8.1/Darwin 7 the default is the two-level.
278278
case "$osvers" in # Note: osvers is the kernel version, not the 10.x
279279
1.[0-3].*) # OS X 10.0.x
280-
lddlflags="${ldflags} -bundle -undefined suppress"
280+
lddlflags="-bundle -undefined suppress"
281281
;;
282282
1.*) # OS X 10.1
283283
ldflags="${ldflags} -flat_namespace"
284-
lddlflags="${ldflags} -bundle -undefined suppress"
284+
lddlflags="-bundle -undefined suppress"
285285
;;
286286
[2-6].*) # OS X 10.1.x - 10.2.x (though [2-4] never existed publicly)
287287
ldflags="${ldflags} -flat_namespace"
288-
lddlflags="${ldflags} -bundle -undefined suppress"
288+
lddlflags="-bundle -undefined suppress"
289289
;;
290290
[7-8].*) # OS X 10.3.x - 10.4.x
291-
lddlflags="${ldflags} -bundle -undefined dynamic_lookup"
291+
lddlflags="-bundle -undefined dynamic_lookup"
292292
case "$ld" in
293293
*MACOSX_DEPLOYMENT_TARGET*) ;;
294294
*) ld="env MACOSX_DEPLOYMENT_TARGET=10.3 ${ld}" ;;
@@ -357,7 +357,7 @@ EOM
357357
esac
358358
fi
359359

360-
lddlflags="${ldflags} -bundle -undefined dynamic_lookup"
360+
lddlflags="-bundle -undefined dynamic_lookup"
361361
;;
362362
esac
363363

0 commit comments

Comments
 (0)