issue #108 progress

improving some coverage, cleaning up a few sonarlint issues, and steering vscode users to clangd.

Author: Scott Dixon

.github/workflows/cetlvast.yml

@@ -190,23 +190,6 @@ jobs:
       - name: SonarQube Scan
         uses: SonarSource/sonarqube-scan-action@v5.3.0
         if: ${{ env.SONAR_TOKEN != '' }}
-        with:
-          args: >
-            -Dsonar.organization=opencyphal
-            -Dsonar.projectKey=OpenCyphal_CETL
-            -Dsonar.projectName=CETLVaSt
-            -Dsonar.verbose=true
-            -Dsonar.cfamily.compile-commands=cetlvast/build/compile_commands.json
-            -Dsonar.cfamily.cobertura.reportPaths=cetlvast/build/suites/unittest/coverage.xml
-            -Dsonar.testExecutionReportPaths=cetlvast/build/suites/unittest/unittest-sonarqube.xml
-            -Dsonar.sources="include,cetlvast/suites/unittest/sonar.cpp"
-            -Dsonar.tests="cetlvast/suites/unittest"
-            -Dsonar.test.inclusions="**/test_*.cpp"
-            -Dsonar.cfamily.ignoreHeaderComments=false
-            -Dsonar.coverage.exclusions="cetlvast/**/*,**/sonar.cpp"
-            -Dsonar.cpd.exclusions="cetlvast/**/*,**/sonar.cpp"
-            -Dsonar.cfamily.reportingCppStandardOverride=c++14
-
   deploy-docs:
     if: >
       (github.event_name == 'release' && !github.event.release.prerelease) ||

.gitignore

@@ -50,3 +50,6 @@ Vagrantfile
 cmake-build-*/
 
 *.gcov
+
+# clangd
+.cache

.vscode/extensions.json

@@ -7,7 +7,7 @@
         "xaver.clang-format",
         "vadimcn.vscode-lldb",
         "matepek.vscode-catch2-test-adapter",
-        "ms-vscode.hexeditor",
-        "Jme797.prettier-vscode-extension"
+        "sonarsource.sonarlint-vscode",
+        "llvm-vs-code-extensions.vscode-clangd"
     ]
 }

.vscode/settings.json

@@ -3,6 +3,8 @@
     "cmake.configureOnEdit": false,
     "cmake.sourceDirectory": "${workspaceFolder}/cetlvast",
     "cmake.buildBeforeRun": true,
+    "C_Cpp.intelliSenseEngine": "disabled",
+    "C_Cpp.autoAddFileAssociations": false,
     "editor.wordWrapColumn": 120,
     "files.insertFinalNewline": true,
     "files.trimFinalNewlines": true,
@@ -30,7 +32,7 @@
             "pattern": "${workspaceFolder}/cetlvast/build/suites/benchmark/**/benchmark_*"
         }
     ],
-    "sonarlint.pathToCompileCommands": "${workspaceFolder}/build/compile_commands.json",
+    "sonarlint.pathToCompileCommands": "${workspaceFolder}/cetlvast/build/compile_commands.json",
     "sonarlint.connectedMode.project": {
         "connectionId": "opencyphal",
         "projectKey": "OpenCyphal_CETL"
@@ -56,110 +58,6 @@
     },
     "files.associations": {
         "*.in": "cmake",
-        "Config": "perl",
-        "memory_resource": "cpp",
-        "any": "cpp",
-        "array": "cpp",
-        "atomic": "cpp",
-        "bit": "cpp",
-        "*.tcc": "cpp",
-        "bitset": "cpp",
-        "cctype": "cpp",
-        "chrono": "cpp",
-        "clocale": "cpp",
-        "cmath": "cpp",
-        "codecvt": "cpp",
-        "compare": "cpp",
-        "concepts": "cpp",
-        "condition_variable": "cpp",
-        "cstdarg": "cpp",
-        "cstddef": "cpp",
-        "cstdint": "cpp",
-        "cstdio": "cpp",
-        "cstdlib": "cpp",
-        "cstring": "cpp",
-        "ctime": "cpp",
-        "cwchar": "cpp",
-        "cwctype": "cpp",
-        "deque": "cpp",
-        "forward_list": "cpp",
-        "list": "cpp",
-        "map": "cpp",
-        "set": "cpp",
-        "string": "cpp",
-        "unordered_map": "cpp",
-        "unordered_set": "cpp",
-        "vector": "cpp",
-        "exception": "cpp",
-        "algorithm": "cpp",
-        "functional": "cpp",
-        "iterator": "cpp",
-        "memory": "cpp",
-        "numeric": "cpp",
-        "optional": "cpp",
-        "random": "cpp",
-        "ratio": "cpp",
-        "string_view": "cpp",
-        "system_error": "cpp",
-        "tuple": "cpp",
-        "type_traits": "cpp",
-        "utility": "cpp",
-        "fstream": "cpp",
-        "future": "cpp",
-        "initializer_list": "cpp",
-        "iomanip": "cpp",
-        "iosfwd": "cpp",
-        "iostream": "cpp",
-        "istream": "cpp",
-        "limits": "cpp",
-        "mutex": "cpp",
-        "new": "cpp",
-        "numbers": "cpp",
-        "ostream": "cpp",
-        "regex": "cpp",
-        "semaphore": "cpp",
-        "shared_mutex": "cpp",
-        "span": "cpp",
-        "sstream": "cpp",
-        "stdexcept": "cpp",
-        "stop_token": "cpp",
-        "streambuf": "cpp",
-        "thread": "cpp",
-        "cinttypes": "cpp",
-        "typeinfo": "cpp",
-        "variant": "cpp",
-        "__bit_reference": "cpp",
-        "__bits": "cpp",
-        "__config": "cpp",
-        "__debug": "cpp",
-        "__errc": "cpp",
-        "__hash_table": "cpp",
-        "__locale": "cpp",
-        "__mutex_base": "cpp",
-        "__node_handle": "cpp",
-        "__split_buffer": "cpp",
-        "__threading_support": "cpp",
-        "__tree": "cpp",
-        "__tuple": "cpp",
-        "__verbose_abort": "cpp",
-        "ios": "cpp",
-        "locale": "cpp",
-        "queue": "cpp",
-        "version": "cpp",
-        "cassert": "cpp",
-        "__memory": "cpp",
-        "__nullptr": "cpp",
-        "__string": "cpp",
-        "ranges": "cpp",
-        "complex": "cpp",
-        "stack": "cpp",
-        "strstream": "cpp",
-        "typeindex": "cpp",
-        "charconv": "cpp",
-        "csignal": "cpp",
-        "format": "cpp",
-        "execution": "cpp",
-        "filesystem": "cpp",
-        "print": "cpp"
+        "*.tcc": "cpp"
     }
 }

.vscode/words-cetl.txt

@@ -1,9 +1,10 @@
- arity
+arity
 AUTOSAR
 builddir
 cetl
 cetlpf
 cetlvast
+cfamily
 COMPILETEST_PRECHECK
 copydoc
 ctest
@@ -32,6 +33,7 @@ NOLINT
 NOLINTBEGIN
 NOLINTEND
 NOLINTNEXTLINE
+NOSONAR
 NOTFOUND
 opencyphal
 Pavel

cetlvast/CMakeLists.txt

@@ -206,12 +206,16 @@ else()
     )
 endif()
 
-add_custom_target(
-    docs
-    DEPENDS
-        lint
-        generate_CETL_docs
-)
+if(DEFINED Doxygen_FOUND)
+if(${Doxygen_FOUND})
+    add_custom_target(
+        docs
+        DEPENDS
+            lint
+            generate_CETL_docs
+    )
+endif()
+endif()
 
 add_custom_target(
     build

cetlvast/cmake/modules/ExternalDependenciesGitHub.cmake.in

@@ -13,4 +13,4 @@
 
 set(GIT_TAG_benchmark "v1.9.1")
 set(GIT_TAG_googletest "v1.16.0")
-set(GIT_TAG_o1heap "aa3c253923db36eee7d73a4a5e30884a5fe7a6eb")
+set(GIT_TAG_o1heap "2.2.0")

cetlvast/cmake/modules/FindSonarScanner.cmake

@@ -56,9 +56,9 @@ function(enable_clang_format_check_for_directory)
     cmake_path(APPEND ARG_DIRECTORY "${ARG_GLOB_PATTERN}" OUTPUT_VARIABLE LOCAL_GLOB_PATTERN_WITH_PATH)
 
     if  (ARG_ADD_TO_ALL)
-    set(LOCAL_ALL "ALL")
+        set(LOCAL_ALL "ALL")
     else()
-    set(LOCAL_ALL  "")
+        set(LOCAL_ALL  "")
     endif()
 
     file(GLOB_RECURSE LOCAL_SOURCE_FILES

cetlvast/cmake/modules/Findclangformat.cmake

@@ -10,7 +10,7 @@
 
 # Function: add_project_library
 #
-# Add and install a library. This method combines all the most common setup for libcyphal library definitions
+# Add and install a library. This method combines all the most common setup for cetlvast library definitions
 # including defining install rules. Additional properties, dependencies, etc can be added after this function
 # using the library target named by the `NAME` argument you passed in.
 #