chore: use PyPI patchelf rather than rebuilding from source (pypa#1236)

patchelf 0.14+ requires c++17
c++17 is not available on all manylinux images, use a prebuilt patchelf wheel for installation.

Author: mayeut

docker/Dockerfile

@@ -60,12 +60,6 @@ RUN export LIBTOOL_ROOT=libtool-2.4.6 && \
     export LIBTOOL_DOWNLOAD_URL=http://ftp.gnu.org/gnu/libtool && \
     manylinux-entrypoint /build_scripts/install-libtool.sh
 
-COPY build_scripts/install-patchelf.sh /build_scripts/
-RUN export PATCHELF_VERSION=0.13.1 && \
-    export PATCHELF_HASH=f6d5ecdb51ad78e963233cfde15020f9eebc9d9c7c747aaed54ce39c284ad019 && \
-    export PATCHELF_DOWNLOAD_URL=https://github.com/NixOS/patchelf/archive && \
-    manylinux-entrypoint /build_scripts/install-patchelf.sh
-
 COPY build_scripts/install-libxcrypt.sh /build_scripts/
 RUN export LIBXCRYPT_VERSION=4.4.27 && \
     export LIBXCRYPT_HASH=e4ff47b7fa5370fa08e27258f8a0de5cb7e9b09c297ec7ab56a8a82e229a1c84 && \

docker/build_scripts/install-patchelf.sh

@@ -0,0 +1,14 @@
+#
+# This file is autogenerated by pip-compile with python 3.9
+# To update, run:
+#
+#    pip-compile --generate-hashes --output-file=docker/build_scripts/requirements-tools/patchelf .nox/update_python_tools/tmp/patchelf.in
+#
+patchelf==0.14.3.0 \
+    --hash=sha256:04cdeea7b24d8daca78e885a113791cedb278eb164a1760c509702d6ed155a46 \
+    --hash=sha256:09ad55d9dff020ecab75d02ae592b6ff7997fc0428ce7ffb35213b3fdd79dad7 \
+    --hash=sha256:0c778f7af59bd781d187ea27556a1ad3e0dd044d85c77536a7c9d2cc027ff0fc \
+    --hash=sha256:4b3ee96c6ac9b2059f038db2838bc0be4d119d3b5b8b0cc252e5cadd832a5ae5 \
+    --hash=sha256:a8dd89901f32f0ce93a5c995a8f9eb79908d43e3a70eaf6b8efe8643976e6a8c \
+    --hash=sha256:fa208aee4b0e6b3f4dbd1bb2be82b1d2635e045e7dfe227b2095bb2e3db67811
+    # via -r .nox/update_python_tools/tmp/patchelf.in

docker/build_scripts/requirements-tools/patchelf

@@ -1,2 +1,3 @@
 auditwheel
 cmake
+patchelf

requirements-tools.in

@@ -117,12 +117,8 @@ def _update_sqlite(dry_run):
 
 def _update_with_gh(tool, dry_run):
     repo = {
-        "patchelf": "NixOS/patchelf",
         "libxcrypt": "besser82/libxcrypt",
     }
-    major = {
-        "patchelf": "0.13"
-    }
     dockerfile = Path(__file__).parent / "docker" / "Dockerfile"
     lines = dockerfile.read_text().splitlines()
     re_ = re.compile(f"^RUN export {tool.upper()}_VERSION=(?P<version>\\S+) && \\\\$")
@@ -131,7 +127,7 @@ def _update_with_gh(tool, dry_run):
         if match is None:
             continue
         current_version = Version(match["version"])
-        latest_tag = latest(repo[tool], output_format="tag", major=major.get(tool, None))
+        latest_tag = latest(repo[tool], output_format="tag")
         latest_version = Version(latest_tag)
         if latest_version > current_version:
             url = re.match(f"^    export {tool.upper()}_DOWNLOAD_URL=(?P<url>\\S+) && \\\\$", lines[i + 2])["url"]
@@ -154,7 +150,7 @@ def main():
     _update_sqlite(args.dry_run)
     for tool in ["autoconf", "automake", "libtool", "git", "swig", "openssl"]:
         _update_with_root(tool, args.dry_run)
-    for tool in ["patchelf", "libxcrypt"]:
+    for tool in ["libxcrypt"]:
         _update_with_gh(tool, args.dry_run)