Skip to content

Commit 2159755

Browse files
committed
Add helper method for disabling bitcode
1 parent defce5f commit 2159755

File tree

1 file changed

+15
-9
lines changed

1 file changed

+15
-9
lines changed

com.onesignal.unity.ios/Editor/BuildPostProcessor.cs

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,7 @@ public void OnPostprocessBuild(BuildReport report) {
111111
// Add the service extension
112112
AddNotificationServiceExtension();
113113

114-
// Unity Tests
115-
var unityTests = _project.TargetGuidByName(PBXProject.GetUnityTestTargetName());
116-
_project.SetBuildProperty(unityTests, "ENABLE_BITCODE", "NO");
117-
118-
// Unity Framework
119-
var unityFramework = _project.GetUnityFrameworkTargetGuid();
120-
_project.SetBuildProperty(unityFramework, "ENABLE_BITCODE", "NO");
114+
DisableBitcode();
121115

122116
// Save the project back out
123117
File.WriteAllText(_projectPath, _project.WriteToString());
@@ -160,8 +154,6 @@ private void AddProjectCapabilities() {
160154
var targetGuid = _project.GetMainTargetGuid();
161155
var targetName = _project.GetMainTargetName();
162156

163-
_project.SetBuildProperty(targetGuid, "ENABLE_BITCODE", "NO");
164-
165157
var entitlementsPath = GetEntitlementsPath(targetGuid, targetName);
166158
var projCapability = new ProjectCapabilityManager(_projectPath, entitlementsPath, targetName);
167159

@@ -293,6 +285,20 @@ private void ExtensionAddPodsToTarget() {
293285

294286
File.WriteAllText(podfilePath, podfile);
295287
}
288+
289+
private void DisableBitcode() {
290+
// Main
291+
var targetGuid = _project.GetMainTargetGuid();
292+
_project.SetBuildProperty(targetGuid, "ENABLE_BITCODE", "NO");
293+
294+
// Unity Tests
295+
var unityTests = _project.TargetGuidByName(PBXProject.GetUnityTestTargetName());
296+
_project.SetBuildProperty(unityTests, "ENABLE_BITCODE", "NO");
297+
298+
// Unity Framework
299+
var unityFramework = _project.GetUnityFrameworkTargetGuid();
300+
_project.SetBuildProperty(unityFramework, "ENABLE_BITCODE", "NO");
301+
}
296302
}
297303
}
298304
#endif

0 commit comments

Comments
 (0)