Remove async from clearAll and requestPermission

Removed async from Notifications.ClearAllNotifications and Location.RequestPermission to match native inconsistency with method signatures

Author: shepherd-l

OneSignalExample/Assets/OneSignal/Example/OneSignalExampleBehaviour.cs

@@ -306,10 +306,10 @@ public async void PromptForPush() {
         _log($"Notification permission is: {OneSignal.Default.Notifications.Permission}");
     }
 
-    public async void ClearPush() {
-        _log("Clearing existing OneSignal push notifications and awaiting result ...");
+    public void ClearPush() {
+        _log("Clearing existing OneSignal push notifications");
 
-        await OneSignal.Default.Notifications.ClearAllNotificationsAsync();
+        OneSignal.Default.Notifications.ClearAllNotifications();
 
         _log("Notifications cleared");
     }
@@ -375,15 +375,10 @@ public void AddOutcomeWithValue() {
      * Location
      */
 
-    public async void PromptLocation() {
-        _log("Opening permission prompt for location and awaiting result...");
+    public void PromptLocation() {
+        _log("Opening permission prompt for location");
 
-        var result = await OneSignal.Default.Location.RequestPermissionAsync();
-
-        if (result)
-            _log("User opted in");
-        else
-            _log("User opted out");
+        OneSignal.Default.Location.RequestPermission();
     }
 
     public void ToggleShareLocation() {

com.onesignal.unity.android/Runtime/AndroidLocationManager.cs

@@ -45,10 +45,9 @@ public bool IsShared {
             set => _location.Call("setShared", value);
         }
 
-        public async Task<bool> RequestPermissionAsync() {
+        public void RequestPermission() {
             var continuation = new BoolContinuation();
             _location.Call<AndroidJavaObject>("requestPermission", continuation.Proxy);
-            return await continuation;
         }
     }
 }

com.onesignal.unity.android/Runtime/AndroidNotificationsManager.cs

@@ -54,10 +54,9 @@ public async Task<bool> RequestPermissionAsync(bool fallbackToSettings) {
             return await continuation;
         }
 
-        public async Task ClearAllNotificationsAsync() {
+        public void ClearAllNotifications() {
             var continuation = new Continuation();
             _notifications.Call<AndroidJavaObject>("clearAllNotifications", continuation.Proxy);
-            await continuation;
         }
 
         public void Initialize() {

com.onesignal.unity.core/Editor/Platform/LocationManager.cs

@@ -31,8 +31,8 @@ namespace OneSignalSDKNew.Location {
     internal sealed class LocationManager : ILocationManager {
         public bool IsShared { get; set; }
 
-        public Task<bool> RequestPermissionAsync() {
-            return Task.FromResult(false);
+        public void RequestPermission() {
+
         }
     }
 }

com.onesignal.unity.core/Editor/Platform/NotificationsManager.cs

@@ -40,8 +40,8 @@ public Task<bool> RequestPermissionAsync(bool fallbackToSettings){
             return Task.FromResult(false);
         }
 
-        public Task ClearAllNotificationsAsync() {
-            return Task.CompletedTask;
+        public void ClearAllNotifications() {
+
         }
     }
 }

com.onesignal.unity.core/Runtime/Location/ILocationManager.cs

@@ -41,14 +41,6 @@ public interface ILocationManager {
         /// <summary>
         /// Helper method to show the native prompt to ask the user for consent to share their location
         /// </summary>
-        /// <param name="fallbackToSettings">
-        /// Whether to direct the user to this app's settings to drive enabling of notifications,
-        /// when the in-app prompting is not possible.
-        /// </param>
-        /// <returns>
-        /// Awaitable boolean of true if the user opted in to location permission or
-        /// false if the user is opted out of location permission
-        /// </returns>
-        Task<bool> RequestPermissionAsync();
+        void RequestPermission();
     }
 }

com.onesignal.unity.core/Runtime/Notifications/INotificationsManager.cs

@@ -89,9 +89,8 @@ public interface INotificationsManager {
         Task<bool> RequestPermissionAsync(bool fallbackToSettings);
 
         /// <summary>
-        /// Removes all OneSignal app notifications from the Notification Shade
+        /// Removes all OneSignal app notifications
         /// </summary>
-        /// <remarks>Android Only</remarks>
-        Task ClearAllNotificationsAsync();
+        void ClearAllNotifications();
     }
 }

com.onesignal.unity.ios/Runtime/iOSLocationManager.cs

@@ -41,9 +41,8 @@ public bool IsShared {
             set => _locationSetIsShared(value);
         }
 
-        public Task<bool> RequestPermissionAsync() { // iOS make async
+        public void RequestPermission() { // iOS make async
             _locationRequestPermission();
-            return Task.FromResult(true);
         }
     }
 }

com.onesignal.unity.ios/Runtime/iOSNotificationsManager.cs

@@ -71,9 +71,8 @@ public async Task<bool> RequestPermissionAsync(bool fallbackToSettings) {
             return await proxy;
         }
 
-        public Task ClearAllNotificationsAsync() {
+        public void ClearAllNotifications() {
             _notificationsClearAll();
-            return Task.CompletedTask;
         }
 
         public void Initialize() {