fix: install sealed secrets in kube-system

Author: bendehaan

build-and-deploy.sh

@@ -18,7 +18,7 @@ WEBTOP_IMAGE=$(cat helm/wrongsecrets-ctf-party/values.yaml | yq '.virtualdesktop
 WEBTOP_TAG=$(cat helm/wrongsecrets-ctf-party/values.yaml | yq '.virtualdesktop.tag')
 echo "doing workaround for selaed secrets"
 helm repo add sealed-secrets https://bitnami-labs.github.io/sealed-secrets
-helm install ws-sealedsecret sealed-secrets/sealed-secrets
+helm install ws-sealedsecrets sealed-secrets/sealed-secrets -n kube-system
 echo "Pulling in required images to actually run $WRONGSECRETS_IMAGE:$WRONGSECRETS_TAG & $WEBTOP_IMAGE:$WEBTOP_TAG."
 echo "If you see an authentication failure: pull them manually by the following 2 commands"
 echo "'docker pull $WRONGSECRETS_IMAGE:$WRONGSECRETS_TAG'"

wrongsecrets-balancer/src/kubernetes.js

@@ -129,16 +129,10 @@ const checkSealedSecretsController = async () => {
   try {
     logger.info('Checking Sealed Secrets controller deployment status...');
     const response = await safeApiCall(
-      () => k8sAppsApi.readNamespacedDeployment({name: 'sealed-secrets-controller', namespace:'kube-system'}),
+      () => k8sAppsApi.readNamespacedDeployment({name: 'ws-sealedsecrets-sealed-secrets', namespace:'kube-system'}),
       'Check Sealed Secrets controller'
     );
-    // const response = await k8sAppsApi.readNamespacedDeployment('sealed-secrets-controller', 'kube-system');
-    if (!response || !response.body) {
-      logger.warn('Sealed Secrets controller deployment not found');
-      return false;
-    }
-
-    const deployment = response.body;
+    const deployment = response;
     const isReady = deployment.status && deployment.status.readyReplicas > 0;
 
     logger.info(`Sealed Secrets controller status: ${isReady ? 'Ready' : 'Not Ready'}`);

wrongsecrets-balancer/src/teams/teams.js

@@ -376,7 +376,11 @@ async function createTeam(req, res) {
       });
   } catch (error) {
     logger.error(`Error while creating deployment or service for team ${team}: ${error.message}`);
+    if (!res.headersSent) {
     res.status(500).send({ message: 'Failed to Create Instance' });
+    } else {
+      logger.error('Could not send error response because headers were already sent');
+    }
   }
 }