Skip to content

Commit 7a6fba5

Browse files
NovoaDevNovoaDev
authored
Merge pull request #52 from NovoaDev/51-bug-update-code-to-pass-new-parser-rules
51 bug update code to pass new parser rules
2 parents cccd6b8 + 4ac616b commit 7a6fba5

36 files changed

+557
-200
lines changed

‎.AL-Go/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,6 @@
3232
"rulesetFile": "Dependency-Graph/.vscode/ruleset.json",
3333
"ALDoc": {
3434
"continuousDeployment": false
35-
}
35+
},
36+
"skipUpgrade": true
3637
}

‎Dependency-Graph.Test/.vscode/launch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"launchBrowser": true,
1414
"enableLongRunningSqlStatements": true,
1515
"enableSqlInformationDebugger": true,
16-
"tenant": "7be8f1f7-bc67-46c0-9487-d836aad47bea"
16+
"tenant": "6de27021-dcdb-4539-b0e1-c5ecb27c4e48"
1717
},
1818
{
1919
"name": "Docker - DependencyGraph",

‎Dependency-Graph.Test/.vscode/ruleset.json

Lines changed: 191 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -386,11 +386,6 @@
386386
"action": "Error",
387387
"justification": "CodeCop - You must use the FieldCaption method instead of the FieldName method and TableCaption method instead of TableName method."
388388
},
389-
{
390-
"id": "AA0448",
391-
"action": "Error",
392-
"justification": "CodeCop - You must use the FieldCaption method instead of the FieldName method and TableCaption method instead of TableName method."
393-
},
394389
{
395390
"id": "AA0462",
396391
"action": "Error",
@@ -556,6 +551,16 @@
556551
"action": "Error",
557552
"justification": "AppSourceCop - Source symbol for the moved symbol cannot be found in the package with the given AppId."
558553
},
554+
{
555+
"id": "AS0126",
556+
"action": "Error",
557+
"justification": "AppSourceCop -InternalsVisibleTo should not specifying a different publisher name than the one of this extension."
558+
},
559+
{
560+
"id": "AS0127",
561+
"action": "Error",
562+
"justification": "AppSourceCop - Objects should be placed in a namespace with at least two levels."
563+
},
559564
{
560565
"id": "PTE0012",
561566
"action": "Error",
@@ -591,6 +596,16 @@
591596
"action": "Error",
592597
"justification": "PerTenantExtensionCop - Use the application property instead of specifying an explicit dependency on Base Application."
593598
},
599+
{
600+
"id": "PTE0022",
601+
"action": "Error",
602+
"justification": "PerTenantExtensionCop - The member ID should be within the allowed range."
603+
},
604+
{
605+
"ID": "PTE0023",
606+
"action": "Error",
607+
"justification": "PerTenantExtensionCop - The enum ordinal value should be within the allowed range."
608+
},
594609
{
595610
"id": "AW0001",
596611
"action": "Error",
@@ -910,6 +925,176 @@
910925
"id": "LC0053",
911926
"action": "Error",
912927
"justification": "LinterCop - The internal procedure is only used in the object in which it is declared. Consider making the procedure local."
913-
}
928+
},
929+
{
930+
"id": "LC0054",
931+
"action": "Error",
932+
"justification": "LinterCop - Interface name must start with the capital 'I' without any spaces following it."
933+
},
934+
{
935+
"id": "LC0055",
936+
"action": "Error",
937+
"justification": "LinterCop - The suffix Tok is meant to be used when the value of the label matches the name."
938+
},
939+
{
940+
"id": "LC0056",
941+
"action": "Error",
942+
"justification": "LinterCop - Empty Enum values should not have a specified Caption property."
943+
},
944+
{
945+
"id": "LC0057",
946+
"action": "Error",
947+
"justification": "LinterCop - Enum values must have non-empty a Caption to be selectable in the client."
948+
},
949+
{
950+
"id": "LC0058",
951+
"action": "Error",
952+
"justification": "LinterCop - PageVariable.SetRecord(): You cannot use a temporary record for the Record parameter."
953+
},
954+
{
955+
"id": "LC0059",
956+
"action": "Error",
957+
"justification": "LinterCop - Single quote escaping issue detected."
958+
},
959+
{
960+
"id": "LC0060",
961+
"action": "Error",
962+
"justification": "LinterCop - The ApplicationArea property is not applicable to API pages."
963+
},
964+
{
965+
"id": "LC0061",
966+
"action": "Error",
967+
"justification": "LinterCop - Pages of type API must have the ODataKeyFields property set to the SystemId field."
968+
},
969+
{
970+
"id": "LC0062",
971+
"action": "Error",
972+
"justification": "LinterCop - Mandatory field is missing on API page."
973+
},
974+
{
975+
"id": "LC0063",
976+
"action": "Error",
977+
"justification": "LinterCop - Consider naming field with a more descriptive name."
978+
},
979+
{
980+
"id": "LC0064",
981+
"action": "Error",
982+
"justification": "LinterCop - Missing ToolTip property on table field."
983+
},
984+
{
985+
"id": "LC0065",
986+
"action": "Error",
987+
"justification": "LinterCop - Event subscriber var keyword mismatch."
988+
},
989+
{
990+
"id": "LC0066",
991+
"action": "Error",
992+
"justification": "LinterCop - Duplicate ToolTip between page and table field."
993+
},
994+
{
995+
"id": "LC0067",
996+
"action": "Error",
997+
"justification": "LinterCop - Set NotBlank property to false when 'No. Series' TableRelation exists."
998+
},
999+
{
1000+
"id": "LC0068",
1001+
"action": "Error",
1002+
"justification": "LinterCop - Informs the user that there are missing permission to access tabledata."
1003+
},
1004+
{
1005+
"id": "LC0069",
1006+
"action": "Error",
1007+
"justification": "LinterCop - Empty statements should be avoided or should have a leading or trailing comment explaining their use."
1008+
},
1009+
{
1010+
"id": "LC0070",
1011+
"action": "Error",
1012+
"justification": "LinterCop - Zero index access on 1-based List objects."
1013+
},
1014+
{
1015+
"id": "LC0071",
1016+
"action": "Error",
1017+
"justification": "LinterCop - Incorrect 'IsHandled' parameter assignment."
1018+
},
1019+
{
1020+
"id": "LC0072",
1021+
"action": "Error",
1022+
"justification": "LinterCop - The documentation comment must match the procedure syntax."
1023+
},
1024+
{
1025+
"id": "LC0073",
1026+
"action": "Error",
1027+
"justification": "LinterCop - Handled parameters in event signatures should be passed by var."
1028+
},
1029+
{
1030+
"id": "LC0074",
1031+
"action": "Error",
1032+
"justification": "LinterCop - Set values for FlowFilter fields using filtering methods."
1033+
},
1034+
{
1035+
"id": "LC0075",
1036+
"action": "Error",
1037+
"justification": "LinterCop - Incorrect number or type of arguments in .Get() method on Record object."
1038+
},
1039+
{
1040+
"id": "LC0076",
1041+
"action": "Error",
1042+
"justification": "LinterCop - The field with table relation should have at least the same length as the referenced field."
1043+
},
1044+
{
1045+
"id": "LC0077",
1046+
"action": "Error",
1047+
"justification": "LinterCop - Methods should always be called with parenthesis."
1048+
},
1049+
{
1050+
"id": "LC0078",
1051+
"action": "Error",
1052+
"justification": "LinterCop - Temporary records should not trigger table triggers."
1053+
},
1054+
{
1055+
"id": "LC0079",
1056+
"action": "Error",
1057+
"justification": "LinterCop - Event publishers should not be public."
1058+
},
1059+
{
1060+
"id": "LC0080",
1061+
"action": "Error",
1062+
"justification": "LinterCop - Replace double quotes in JPath expressions with two single quotes."
1063+
},
1064+
{
1065+
"id": "LC0081",
1066+
"action": "Error",
1067+
"justification": "LinterCop - Use Rec.IsEmpty() for checking record existence."
1068+
},
1069+
{
1070+
"id": "LC0082",
1071+
"action": "Error",
1072+
"justification": "LinterCop - Use Rec.Find('-') with Rec.Next() for checking exactly one record."
1073+
},
1074+
{
1075+
"id": "LC0083",
1076+
"action": "Error",
1077+
"justification": "LinterCop - Use new Date/Time/DateTime methods for extracting parts."
1078+
},
1079+
{
1080+
"id": "LC0084",
1081+
"action": "Error",
1082+
"justification": "LinterCop - Use return value for better error handling."
1083+
},
1084+
{
1085+
"id": "LC0085",
1086+
"action": "Error",
1087+
"justification": "LinterCop - Use the (CR)LFSeparator from the 'Type Helper' codeunit."
1088+
},
1089+
{
1090+
"id": "LC0086",
1091+
"action": "Error",
1092+
"justification": "LinterCop - Use the new PageStyle datatype instead string literals."
1093+
},
1094+
{
1095+
"id": "LC0087",
1096+
"action": "Error",
1097+
"justification": "LinterCop - Use IsNullGuid() to check for empty GUID values."
1098+
}
9141099
]
9151100
}

‎Dependency-Graph.Test/src/Test/FillingProTablesMockANJ.Codeunit.al

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/// Codeunit "FillingProTablesMock_ANJ" (ID 99993).
33
/// </summary>
44
namespace ANJ.Tools.Graph;
5-
codeunit 99993 FillingProTablesMock_ANJ implements FillingProcessingTables_ANJ
5+
codeunit 99993 FillingProTablesMock_ANJ implements IFillingProcessingTables_ANJ
66
{
77
Access = Internal;
88

‎Dependency-Graph.Test/src/Test/FillingProcessTablesMockANJ.EnumExt.al

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ enumextension 99990 FillingProcessTablesMock_ANJ extends FillingProcessingTables
77
value(99990; Mock_ANJ)
88
{
99
Caption = 'Mock';
10-
Implementation = FillingProcessingTables_ANJ = FillingProTablesMock_ANJ;
10+
Implementation = IFillingProcessingTables_ANJ = FillingProTablesMock_ANJ;
1111
}
1212
}

‎Dependency-Graph/.vscode/launch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"launchBrowser": true,
1414
"enableLongRunningSqlStatements": true,
1515
"enableSqlInformationDebugger": true,
16-
"tenant": "7be8f1f7-bc67-46c0-9487-d836aad47bea"
16+
"tenant": "6de27021-dcdb-4539-b0e1-c5ecb27c4e48"
1717
},
1818
{
1919
"name": "Docker - DependencyGraph",

0 commit comments

Comments
 (0)