Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

Commit 9246cd1

Browse files
committed
Support of newest python and opentracing
1 parent bd4f30a commit 9246cd1

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@
1515
platforms='any',
1616
install_requires=[
1717
'sqlalchemy',
18-
'opentracing>=1.1,<=1.3'
18+
'opentracing'
1919
],
20+
tests_require=['pytest-cov'],
2021
classifiers=[
2122
'Intended Audience :: Developers',
2223
'License :: OSI Approved :: BSD License',

tests/test_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import unittest
2-
from mock import patch
2+
from unittest.mock import patch
33
from sqlalchemy import create_engine, MetaData, Table, Column, Integer, String
44
from sqlalchemy.engine import Engine
55
from sqlalchemy.exc import OperationalError

tests/test_core.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def test_traced_transaction(self):
163163
self.assertEqual(True, all(map(lambda x: x.is_finished, tracer.spans)))
164164
self.assertEqual(True, all(map(lambda x: x.child_of == parent_span, tracer.spans)))
165165
self.assertEqual(['create_table', 'insert', 'select'],
166-
map(lambda x: x.operation_name, tracer.spans))
166+
list(map(lambda x: x.operation_name, tracer.spans)))
167167

168168
def test_traced_transaction_nested(self):
169169
tracer = DummyTracer()
@@ -189,7 +189,7 @@ def test_traced_transaction_nested(self):
189189
self.assertEqual(True, all(map(lambda x: x.is_finished, tracer.spans)))
190190
self.assertEqual(True, all(map(lambda x: x.child_of == parent_span, tracer.spans)))
191191
self.assertEqual(['create_table', 'insert', 'select'],
192-
map(lambda x: x.operation_name, tracer.spans))
192+
list(map(lambda x: x.operation_name, tracer.spans)))
193193

194194
def test_traced_rollback(self):
195195
tracer = DummyTracer()
@@ -216,9 +216,9 @@ def test_traced_rollback(self):
216216
self.assertEqual(True, all(map(lambda x: x.is_finished, tracer.spans)))
217217
self.assertEqual(True, all(map(lambda x: x.child_of == parent_span, tracer.spans)))
218218
self.assertEqual(['insert', 'create_table'],
219-
map(lambda x: x.operation_name, tracer.spans))
219+
list(map(lambda x: x.operation_name, tracer.spans)))
220220
self.assertEqual(['false', 'true'],
221-
map(lambda x: x.tags.get('error', 'false'), tracer.spans))
221+
list(map(lambda x: x.tags.get('error', 'false'), tracer.spans)))
222222

223223
def test_traced_after_transaction(self):
224224
tracer = DummyTracer()

tests/test_orm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def test_traced_bulk_insert(self):
262262
parent_span = DummySpan('parent')
263263
session = self.session
264264
sqlalchemy_opentracing.set_parent_span(session, parent_span)
265-
users = [User(name = 'User-%s' % i) for i in xrange(10)]
265+
users = [User(name = 'User-%s' % i) for i in range(10)]
266266
session.bulk_save_objects(users)
267267

268268
self.assertEqual(1, len(tracer.spans))

0 commit comments

Comments
 (0)