LS-5330: Make Proto over HTTP the default transport

Author: frenchfrywpepper

examples/trivial/main.py

@@ -67,8 +67,8 @@ def lightstep_tracer_from_args():
                         dest="no_tls", action='store_true')
     parser.add_argument('--component_name', help='The LightStep component name',
                         default='TrivialExample')
-    parser.add_argument('--use_http', help='Use proto over http',
-                        dest="use_http", action='store_true')
+    parser.add_argument('--use_thrift', help='Use Thrift over http',
+                        dest="use_thrift", action='store_true')
     args = parser.parse_args()
 
     if args.no_tls:
@@ -83,8 +83,8 @@ def lightstep_tracer_from_args():
             collector_port=args.port,
             verbosity=1,
             collector_encryption=collector_encryption,
-            use_thrift=not args.use_http,
-            use_http=args.use_http)
+            use_thrift=args.use_thrift,
+            use_http=not args.use_thrift)
 
 
 if __name__ == '__main__':

lightstep/recorder.py

@@ -44,8 +44,8 @@ def __init__(self,
                  periodic_flush_seconds=constants.FLUSH_PERIOD_SECS,
                  verbosity=0,
                  certificate_verification=True,
-                 use_thrift=True,
-                 use_http=False):
+                 use_thrift=False,
+                 use_http=True):
         self.verbosity = verbosity
         # Fail fast on a bad access token
         if not isinstance(access_token, str):
@@ -55,12 +55,12 @@ def __init__(self,
             warnings.warn('SSL CERTIFICATE VERIFICATION turned off. ALL FUTURE HTTPS calls will be unverified.')
             ssl._create_default_https_context = ssl._create_unverified_context
 
-        if use_thrift:
-            self.use_thrift = True
-            self.converter = ThriftConverter()
-        elif use_http:
+        if use_http:
             self.use_thrift = False
             self.converter = HttpConverter()
+        elif use_thrift:
+            self.use_thrift = True
+            self.converter = ThriftConverter()
         else:
             raise Exception('Either use_thrift or use_http must be True')