maintenance: update/remove dependencies and move tests to mocha

Author: jankapunkt

mongo-instances-tests.js

@@ -1,28 +1,35 @@
-var instances = [];
+/* global CollectionExtensions */
+import { Mongo } from 'meteor/mongo'
+import { Meteor } from 'meteor/meteor'
+const instances = []
 
 CollectionExtensions.addExtension(function (name, options) {
   instances.push({
     name: name,
     instance: this,
     options: options
-  });
-});
+  })
+})
 
-Mongo.Collection.get = function(name, options) {
-  options = options || {};
-  var collection = _.find(instances, function(instance) {
-    if (options.connection)
-      return instance.name === name &&
-        instance.options && instance.options.connection._lastSessionId === options.connection._lastSessionId;
-    return instance.name === name;
-  });
+Mongo.Collection.get = function (name, options) {
+  options = options || {}
+  const collection = instances.find(instance => {
+    if (options.connection) {
+      return (
+        instance.name === name &&
+        instance.options &&
+        instance.options.connection._lastSessionId === options.connection._lastSessionId
+      )
+    }
+    return instance.name === name
+  })
 
-  return collection && collection.instance;
-};
+  return collection && collection.instance
+}
 
-Mongo.Collection.getAll = function() {
-  return instances;
-};
+Mongo.Collection.getAll = function () {
+  return instances
+}
 
 // Meteor.Collection will lack ownProperties that are added back to Mongo.Collection
-Meteor.Collection = Mongo.Collection;
+Meteor.Collection = Mongo.Collection

mongo-instances.js

@@ -0,0 +1,79 @@
+/* eslint-env mocha */
+import { expect } from 'chai'
+import { Random } from 'meteor/random'
+import { Mongo } from 'meteor/mongo'
+import { Meteor } from 'meteor/meteor'
+
+const randomName = () => `test${Random.id(6)}`
+const equal = (a, b) => expect(a).to.equal(b)
+
+describe('unit tests', () => {
+  let collectionName
+
+  beforeEach(() => {
+    collectionName = randomName() // random ID, so a new collection every time
+  })
+
+  it('basic - works Mongo.Collection', () => {
+    const Test = new Mongo.Collection(collectionName)
+
+    Test.insert({ test: true })
+    const find = Mongo.Collection.get(collectionName).find({ test: true })
+    equal(find.count(), 1)
+
+    // get an existing collection again
+    const ReGet = Mongo.Collection.get(collectionName)
+    equal(ReGet.find().count(), 1)
+  })
+
+  it('basic - works Meteor.Collection', function () {
+    const Test = new Meteor.Collection(collectionName)
+    Test.insert({ test: true })
+
+    const find = Meteor.Collection.get(collectionName).find({ test: true })
+    equal(find.count(), 1)
+  })
+
+  it('basic - collection already exists', () => {
+    const createInstance = () => new Mongo.Collection(collectionName)
+    createInstance()
+    expect(createInstance).to.throw('is already')
+  })
+
+  it('nonexistent - returns undefined', () => {
+    const collection = Mongo.Collection.get('truly-non-existent')
+    equal(collection, undefined)
+  })
+
+  it('instanceof - matches Mongo.Collection', () => {
+    const Test = new Mongo.Collection(collectionName)
+    expect(Test).to.be.instanceOf(Mongo.Collection)
+  })
+
+  it('instanceof - Meteor.Collection matches Mongo.Collection', () => {
+    const Test = new Meteor.Collection(collectionName)
+    expect(Test).to.be.instanceOf(Mongo.Collection)
+  })
+
+  it('instanceof - Meteor.users matches (Mongo/Meteor).Collection', () => {
+    expect(Meteor.users).to.be.instanceOf(Mongo.Collection)
+    expect(Meteor.users).to.be.instanceOf(Meteor.Collection)
+  })
+
+  it('constructor equality - Mongo/Meteor.Collection === Mongo/Meteor.Collection.prototype.constructor', () => {
+    equal(Mongo.Collection, Mongo.Collection.prototype.constructor)
+    equal(Meteor.Collection, Mongo.Collection.prototype.constructor)
+    equal(Meteor.Collection, Meteor.Collection.prototype.constructor)
+  })
+
+  it('use New - keep behavior of Mongo.Collection', () => {
+    const createWithoutNew = () => Mongo.Collection(collectionName)
+    expect(createWithoutNew).to.throw('this._maybeSetUpReplication is not a function')
+  })
+
+  it('users - can Mongo.Collection.get Meteor.users instance', () => {
+    const name = 'users'
+    expect(Mongo.Collection.get(name)).to.be.instanceOf(Mongo.Collection)
+    expect(Mongo.Collection.get(name)).to.be.instanceOf(Meteor.Collection)
+  })
+})

mongo-instances.tests.js

@@ -1,24 +1,27 @@
+/* eslint-env meteor */
 Package.describe({
   name: 'dburles:mongo-collection-instances',
   summary: 'Access your Mongo instances',
-  version: '0.3.6',
+  version: '0.4.0',
   git: 'https://github.com/dburles/mongo-collection-instances.git'
-});
+})
 
-Package.onUse(function(api) {
-  api.versionsFrom('1.0');
+Package.onUse(function (api) {
+  api.versionsFrom(['1.0', '2.3', '2.8.0'])
   api.use([
     'mongo',
-    'underscore',
-    'lai:collection-extensions@0.3.0']);
-  api.addFiles('mongo-instances.js');
-});
+    'ecmascript',
+    'lai:collection-extensions@0.4.0'])
+  api.addFiles('mongo-instances.js')
+})
 
-Package.onTest(function(api) {
+Package.onTest(function (api) {
   api.use([
-    'tinytest',
+    'ecmascript',
+    'meteortesting:[email protected]',
     'accounts-base',
     'mongo',
-    'dburles:mongo-collection-instances']);
-  api.addFiles('mongo-instances-tests.js');
-});
+    'dburles:mongo-collection-instances'
+  ])
+  api.addFiles('mongo-instances.tests.js')
+})