-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
MetaMask/core
#5942Labels
area-performanceIssues relating to slowness of app, cpu usage, and/or blank screens.Issues relating to slowness of app, cpu usage, and/or blank screens.team-assets
Description
What is this about?
Findings - Using redux-devtools-expo-dev-plugin, we found some areas that should be optimized.
AccountTrackerControlleris triggering many state updates, many of which do not include new states. The controller needs to prevent these empty state updates from triggering
2 videos showing empty states on AccountTrackerController triggered updates
https://github.com/user-attachments/assets/9039dda7-f368-41ed-956d-b331bff8151b
https://github.com/user-attachments/assets/320163cc-b45a-4b1c-a93e-0cdad25223ea
Findings from - #15028 (comment)
Scenario
No response
Design
No response
Technical Details
- Prevent empty state updates from triggering on
AccountsTrackerController
Threat Modeling Framework
No response
Acceptance Criteria
AccountTrackerControllershould not produce empty state updates
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Other (please specify)
References
Original findings - #15028
Metadata
Metadata
Assignees
Labels
area-performanceIssues relating to slowness of app, cpu usage, and/or blank screens.Issues relating to slowness of app, cpu usage, and/or blank screens.team-assets
Type
Projects
Status
Fixed