feat: query only latest page for incoming transactions (#5983)

## Explanation

Query only the latest page of transaction history from the accounts API.

In order to minimise load, improve performance, and better align with
the transaction state limit.

## References

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

Author: matthewwalsh0

packages/transaction-controller/CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Query only latest page of transactions from accounts API ([#5983](https://github.com/MetaMask/core/pull/5983))
 - Remove incoming transactions when calling `wipeTransactions` ([#5986](https://github.com/MetaMask/core/pull/5986))
 - Poll immediately when calling `startIncomingTransactionPolling` ([#5986](https://github.com/MetaMask/core/pull/5986))
 

packages/transaction-controller/src/TransactionController.test.ts

@@ -4982,24 +4982,6 @@ describe('TransactionController', () => {
     });
   });
 
-  describe('on incoming transaction helper updateCache call', () => {
-    it('updates state', async () => {
-      const { controller } = setupController();
-      const key = 'testKey';
-      const value = 123;
-
-      incomingTransactionHelperClassMock.mock.calls[0][0].updateCache(
-        (cache) => {
-          cache[key] = value;
-        },
-      );
-
-      expect(controller.state.lastFetchedBlockNumbers).toStrictEqual({
-        [key]: value,
-      });
-    });
-  });
-
   describe('updateTransactionGasFees', () => {
     it('throws if transaction does not exist', async () => {
       const { controller } = setupController();

packages/transaction-controller/src/TransactionController.ts

@@ -352,7 +352,7 @@ export type TransactionControllerOptions = {
 
   /** Configuration options for incoming transaction support. */
   incomingTransactions?: IncomingTransactionOptions & {
-    /** API keys to be used for Etherscan requests to prevent rate limiting. */
+    /** @deprecated Ignored as Etherscan no longer used. */
     etherscanApiKeysByChainId?: Record<Hex, string>;
   };
 
@@ -969,25 +969,16 @@ export class TransactionController extends BaseController<
       },
     );
 
-    const updateCache = (fn: (cache: Record<string, unknown>) => void) => {
-      this.update((_state) => {
-        fn(_state.lastFetchedBlockNumbers);
-      });
-    };
-
     this.#incomingTransactionHelper = new IncomingTransactionHelper({
       client: this.#incomingTransactionOptions.client,
-      getCache: () => this.state.lastFetchedBlockNumbers,
       getCurrentAccount: () => this.#getSelectedAccount(),
       getLocalTransactions: () => this.state.transactions,
       includeTokenTransfers:
         this.#incomingTransactionOptions.includeTokenTransfers,
       isEnabled: this.#incomingTransactionOptions.isEnabled,
       messenger: this.messagingSystem,
-      queryEntireHistory: this.#incomingTransactionOptions.queryEntireHistory,
       remoteTransactionSource: new AccountsApiRemoteTransactionSource(),
       trimTransactions: this.#trimTransactionsForState.bind(this),
-      updateCache,
       updateTransactions: this.#incomingTransactionOptions.updateTransactions,
     });
 

packages/transaction-controller/src/helpers/AccountsApiRemoteTransactionSource.test.ts

@@ -18,16 +18,10 @@ jest.useFakeTimers();
 const ADDRESS_MOCK = '0x123';
 const ONE_DAY_MS = 1000 * 60 * 60 * 24;
 const NOW_MOCK = 789000 + ONE_DAY_MS;
-const CURSOR_MOCK = 'abcdef';
-const CACHED_TIMESTAMP_MOCK = 456;
-const INITIAL_TIMESTAMP_MOCK = 789;
 
 const REQUEST_MOCK: RemoteTransactionSourceRequest = {
   address: ADDRESS_MOCK,
-  cache: {},
   includeTokenTransfers: true,
-  queryEntireHistory: true,
-  updateCache: jest.fn(),
   updateTransactions: true,
 };
 
@@ -140,60 +134,10 @@ describe('AccountsApiRemoteTransactionSource', () => {
       expect(getAccountTransactionsMock).toHaveBeenCalledWith({
         address: ADDRESS_MOCK,
         chainIds: SUPPORTED_CHAIN_IDS,
-        cursor: undefined,
-        sortDirection: 'ASC',
+        sortDirection: 'DESC',
       });
     });
 
-    it('queries accounts API with start timestamp if queryEntireHistory is false', async () => {
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        queryEntireHistory: false,
-      });
-
-      expect(getAccountTransactionsMock).toHaveBeenCalledTimes(1);
-      expect(getAccountTransactionsMock).toHaveBeenCalledWith(
-        expect.objectContaining({
-          startTimestamp: INITIAL_TIMESTAMP_MOCK,
-        }),
-      );
-    });
-
-    it('queries accounts API with cursor from cache', async () => {
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        cache: {
-          [`accounts-api#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-            CURSOR_MOCK,
-        },
-      });
-
-      expect(getAccountTransactionsMock).toHaveBeenCalledTimes(1);
-      expect(getAccountTransactionsMock).toHaveBeenCalledWith(
-        expect.objectContaining({
-          cursor: CURSOR_MOCK,
-        }),
-      );
-    });
-
-    it('queries accounts API with timestamp from cache', async () => {
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        queryEntireHistory: false,
-        cache: {
-          [`accounts-api#timestamp#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-            CACHED_TIMESTAMP_MOCK,
-        },
-      });
-
-      expect(getAccountTransactionsMock).toHaveBeenCalledTimes(1);
-      expect(getAccountTransactionsMock).toHaveBeenCalledWith(
-        expect.objectContaining({
-          startTimestamp: CACHED_TIMESTAMP_MOCK,
-        }),
-      );
-    });
-
     it('returns normalized standard transaction', async () => {
       getAccountTransactionsMock.mockResolvedValue({
         data: [RESPONSE_STANDARD_MOCK],
@@ -222,117 +166,6 @@ describe('AccountsApiRemoteTransactionSource', () => {
       expect(transactions).toStrictEqual([TRANSACTION_TOKEN_TRANSFER_MOCK]);
     });
 
-    it('queries multiple times if response has next page', async () => {
-      getAccountTransactionsMock
-        .mockResolvedValueOnce({
-          data: [RESPONSE_STANDARD_MOCK],
-          pageInfo: { hasNextPage: true, count: 1, cursor: CURSOR_MOCK },
-        })
-        .mockResolvedValueOnce({
-          data: [RESPONSE_STANDARD_MOCK],
-          pageInfo: { hasNextPage: true, count: 1, cursor: CURSOR_MOCK },
-        });
-
-      await new AccountsApiRemoteTransactionSource().fetchTransactions(
-        REQUEST_MOCK,
-      );
-
-      expect(getAccountTransactionsMock).toHaveBeenCalledTimes(3);
-      expect(getAccountTransactionsMock).toHaveBeenNthCalledWith(
-        1,
-        expect.objectContaining({ cursor: undefined }),
-      );
-      expect(getAccountTransactionsMock).toHaveBeenNthCalledWith(
-        2,
-        expect.objectContaining({ cursor: CURSOR_MOCK }),
-      );
-      expect(getAccountTransactionsMock).toHaveBeenNthCalledWith(
-        3,
-        expect.objectContaining({ cursor: CURSOR_MOCK }),
-      );
-    });
-
-    it('updates cache if response has cursor', async () => {
-      getAccountTransactionsMock
-        .mockResolvedValueOnce({
-          data: [RESPONSE_STANDARD_MOCK],
-          pageInfo: { hasNextPage: true, count: 1, cursor: CURSOR_MOCK },
-        })
-        .mockResolvedValueOnce({
-          data: [RESPONSE_STANDARD_MOCK],
-          pageInfo: { hasNextPage: true, count: 1, cursor: CURSOR_MOCK },
-        });
-
-      const cacheMock = {};
-
-      const updateCacheMock = jest
-        .fn()
-        .mockImplementation((fn) => fn(cacheMock));
-
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        updateCache: updateCacheMock,
-      });
-
-      expect(updateCacheMock).toHaveBeenCalledTimes(2);
-      expect(cacheMock).toStrictEqual({
-        [`accounts-api#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-          CURSOR_MOCK,
-      });
-    });
-
-    it('removes timestamp cache entry if response has cursor', async () => {
-      getAccountTransactionsMock.mockResolvedValueOnce({
-        data: [RESPONSE_STANDARD_MOCK],
-        pageInfo: { hasNextPage: false, count: 1, cursor: CURSOR_MOCK },
-      });
-
-      const cacheMock = {
-        [`accounts-api#timestamp#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-          CACHED_TIMESTAMP_MOCK,
-      };
-
-      const updateCacheMock = jest
-        .fn()
-        .mockImplementation((fn) => fn(cacheMock));
-
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        updateCache: updateCacheMock,
-      });
-
-      expect(updateCacheMock).toHaveBeenCalledTimes(1);
-      expect(cacheMock).toStrictEqual({
-        [`accounts-api#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-          CURSOR_MOCK,
-      });
-    });
-
-    it('updates cache with timestamp if response does not have cursor', async () => {
-      getAccountTransactionsMock.mockResolvedValueOnce({
-        data: [],
-        pageInfo: { hasNextPage: false, count: 0, cursor: undefined },
-      });
-
-      const cacheMock = {};
-
-      const updateCacheMock = jest
-        .fn()
-        .mockImplementation((fn) => fn(cacheMock));
-
-      await new AccountsApiRemoteTransactionSource().fetchTransactions({
-        ...REQUEST_MOCK,
-        queryEntireHistory: false,
-        updateCache: updateCacheMock,
-      });
-
-      expect(updateCacheMock).toHaveBeenCalledTimes(1);
-      expect(cacheMock).toStrictEqual({
-        [`accounts-api#timestamp#${SUPPORTED_CHAIN_IDS.join(',')}#${ADDRESS_MOCK}`]:
-          INITIAL_TIMESTAMP_MOCK,
-      });
-    });
-
     it('ignores outgoing transactions if updateTransactions is false', async () => {
       getAccountTransactionsMock.mockResolvedValue({
         data: [{ ...RESPONSE_STANDARD_MOCK, to: '0x456' }],