feat: Add lendingWithdraw type to TransactionController and EarnController (#5936)

### Changes
- Add `lendingWithdraw` type to `@metamask/transaction-controller`
- Replace hardcoded `"lendingWithdraw"` in `@metamask/earn-controller`

Author: Matt561

packages/earn-controller/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Replace hardcoded `"lendingWithdraw"` in `LendingTransactionTypes` with `TransactionType.lendingWithdraw` ([#5936](https://github.com/MetaMask/core/pull/5936))
+
 ## [1.0.0]
 
 ### Added

packages/earn-controller/src/EarnController.ts

@@ -98,11 +98,11 @@ const stakingTransactionTypes = new Set<StakingTransactionTypes>([
 
 type LendingTransactionTypes =
   | TransactionType.lendingDeposit
-  | 'lendingWithdraw';
+  | TransactionType.lendingWithdraw;
 
 const lendingTransactionTypes = new Set<LendingTransactionTypes>([
   TransactionType.lendingDeposit,
-  'lendingWithdraw',
+  TransactionType.lendingWithdraw,
 ]);
 
 /**

packages/transaction-controller/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add `lendingWithdraw` to `TransactionType` ([#5936](https://github.com/MetaMask/core/pull/5936))
+
 ### Fixed
 
 - Avoid coercing `publishBatchHook` to a boolean ([#5934](https://github.com/MetaMask/core/pull/5934))

packages/transaction-controller/src/types.ts

@@ -678,6 +678,11 @@ export enum TransactionType {
    */
   lendingDeposit = 'lendingDeposit',
 
+  /**
+   * A transaction that withdraws tokens from a lending contract.
+   */
+  lendingWithdraw = 'lendingWithdraw',
+
   /**
    * A transaction for personal sign.
    */