Skip to content

Commit e385305

Browse files
lramos15lramos15
committed
Remove notEqual part of microsoft#118667 
1 parent e30424a commit e385305

File tree

10 files changed

+74
-74
lines changed

10 files changed

+74
-74
lines changed

‎src/vs/base/test/common/async.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ suite('Async', () => {
529529

530530
return new Promise<void>(c => setTimeout(() => c(), 0)).then(() => {
531531
const r1Queue2 = queue.queueFor(URI.file('/some/path'));
532-
assert.notEqual(r1Queue, r1Queue2); // previous one got disposed after finishing
532+
assert.notStrictEqual(r1Queue, r1Queue2); // previous one got disposed after finishing
533533
});
534534
});
535535

‎src/vs/editor/contrib/snippet/test/snippetParser.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ suite('SnippetParser', () => {
416416
//${3/\\s:=(.*)/${1:+ :=}${1}/}
417417
assert.ok(children[3] instanceof Placeholder);
418418
assert.strictEqual(children[3].children.length, 0);
419-
assert.notEqual((<Placeholder>children[3]).transform, undefined);
419+
assert.notStrictEqual((<Placeholder>children[3]).transform, undefined);
420420
let transform = (<Placeholder>children[3]).transform!;
421421
assert.deepStrictEqual(transform.regexp, /\s:=(.*)/);
422422
assert.strictEqual(transform.children.length, 2);

‎src/vs/platform/telemetry/test/browser/telemetryService.test.ts

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ suite('TelemetryService', () => {
105105
return service.publicLog('testEvent').then(_ => {
106106
assert.strictEqual(testAppender.getEventsCount(), 1);
107107
assert.strictEqual(testAppender.events[0].eventName, 'testEvent');
108-
assert.notEqual(testAppender.events[0].data, null);
108+
assert.notStrictEqual(testAppender.events[0].data, null);
109109

110110
service.dispose();
111111
});
@@ -125,7 +125,7 @@ suite('TelemetryService', () => {
125125
}).then(() => {
126126
assert.strictEqual(testAppender.getEventsCount(), 1);
127127
assert.strictEqual(testAppender.events[0].eventName, 'testEvent');
128-
assert.notEqual(testAppender.events[0].data, null);
128+
assert.notStrictEqual(testAppender.events[0].data, null);
129129
assert.strictEqual(testAppender.events[0].data['stringProp'], 'property');
130130
assert.strictEqual(testAppender.events[0].data['numberProp'], 1);
131131
assert.strictEqual(testAppender.events[0].data['booleanProp'], true);
@@ -388,7 +388,7 @@ suite('TelemetryService', () => {
388388

389389
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
390390
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
391-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
391+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
392392
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
393393

394394
errorTelemetry.dispose();
@@ -419,7 +419,7 @@ suite('TelemetryService', () => {
419419
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
420420
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
421421
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
422-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
422+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
423423
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
424424

425425
errorTelemetry.dispose();
@@ -445,13 +445,13 @@ suite('TelemetryService', () => {
445445
this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
446446
await service.join();
447447

448-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
448+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
449449
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
450450
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
451-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
451+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
452452
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
453453
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
454-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
454+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
455455
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
456456

457457
errorTelemetry.dispose();
@@ -478,13 +478,13 @@ suite('TelemetryService', () => {
478478

479479
assert.strictEqual(errorStub.callCount, 1);
480480
// Test that important information remains but personal info does not
481-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
481+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
482482
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
483483
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
484-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
484+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
485485
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
486486
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
487-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
487+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
488488
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
489489

490490
errorTelemetry.dispose();
@@ -510,10 +510,10 @@ suite('TelemetryService', () => {
510510
this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
511511
await service.join();
512512

513-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModuleAsarPathToRetain), -1);
514-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModulePathToRetain), -1);
515-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModuleAsarPathToRetain), -1);
516-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModulePathToRetain), -1);
513+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModuleAsarPathToRetain), -1);
514+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModulePathToRetain), -1);
515+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModuleAsarPathToRetain), -1);
516+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModulePathToRetain), -1);
517517

518518
errorTelemetry.dispose();
519519
service.dispose();
@@ -539,10 +539,10 @@ suite('TelemetryService', () => {
539539

540540
assert.strictEqual(errorStub.callCount, 1);
541541

542-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModuleAsarPathToRetain), -1);
543-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModulePathToRetain), -1);
544-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModuleAsarPathToRetain), -1);
545-
assert.notEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModulePathToRetain), -1);
542+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModuleAsarPathToRetain), -1);
543+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(' + settings.nodeModulePathToRetain), -1);
544+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModuleAsarPathToRetain), -1);
545+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf('(/' + settings.nodeModulePathToRetain), -1);
546546

547547
errorTelemetry.dispose();
548548
service.dispose();
@@ -568,13 +568,13 @@ suite('TelemetryService', () => {
568568
this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
569569
await service.join();
570570

571-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
571+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
572572
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
573573
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
574-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
574+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
575575
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
576576
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
577-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
577+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
578578
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
579579

580580
errorTelemetry.dispose();
@@ -601,13 +601,13 @@ suite('TelemetryService', () => {
601601

602602
assert.strictEqual(errorStub.callCount, 1);
603603
// Test that important information remains but personal info does not
604-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
604+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.importantInfo), -1);
605605
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
606606
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
607-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
607+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.importantInfo), -1);
608608
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
609609
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
610-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
610+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
611611
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
612612

613613
errorTelemetry.dispose();
@@ -634,13 +634,13 @@ suite('TelemetryService', () => {
634634
this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
635635
await service.join();
636636

637-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.missingModelPrefix), -1);
637+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.missingModelPrefix), -1);
638638
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
639639
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
640-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.missingModelPrefix), -1);
640+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.missingModelPrefix), -1);
641641
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
642642
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
643-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
643+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
644644
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
645645

646646
errorTelemetry.dispose();
@@ -667,13 +667,13 @@ suite('TelemetryService', () => {
667667
assert.strictEqual(errorStub.callCount, 1);
668668
// Test that no file information remains, but this particular
669669
// error message does (Received model events for missing model)
670-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.missingModelPrefix), -1);
670+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.missingModelPrefix), -1);
671671
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
672672
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
673-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.missingModelPrefix), -1);
673+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.missingModelPrefix), -1);
674674
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
675675
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
676-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
676+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
677677
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
678678

679679
errorTelemetry.dispose();
@@ -700,13 +700,13 @@ suite('TelemetryService', () => {
700700
this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
701701
await service.join();
702702

703-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.noSuchFilePrefix), -1);
703+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.noSuchFilePrefix), -1);
704704
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
705705
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
706-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.noSuchFilePrefix), -1);
706+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.noSuchFilePrefix), -1);
707707
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
708708
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
709-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
709+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
710710
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
711711

712712
errorTelemetry.dispose();
@@ -738,13 +738,13 @@ suite('TelemetryService', () => {
738738
// Test that no file information remains, but this particular
739739
// error message does (ENOENT: no such file or directory)
740740
Errors.onUnexpectedError(noSuchFileError);
741-
assert.notEqual(testAppender.events[0].data.msg.indexOf(settings.noSuchFilePrefix), -1);
741+
assert.notStrictEqual(testAppender.events[0].data.msg.indexOf(settings.noSuchFilePrefix), -1);
742742
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.personalInfo), -1);
743743
assert.strictEqual(testAppender.events[0].data.msg.indexOf(settings.filePrefix), -1);
744-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.noSuchFilePrefix), -1);
744+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.noSuchFilePrefix), -1);
745745
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.personalInfo), -1);
746746
assert.strictEqual(testAppender.events[0].data.callstack.indexOf(settings.filePrefix), -1);
747-
assert.notEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
747+
assert.notStrictEqual(testAppender.events[0].data.callstack.indexOf(settings.stack[4].replace(settings.randomUserFile, settings.anonymizedRandomUserFile)), -1);
748748
assert.strictEqual(testAppender.events[0].data.callstack.split('\n').length, settings.stack.length);
749749

750750
errorTelemetry.dispose();

0 commit comments

Comments
 (0)