Properly encode markdown file path for open links

mjbvz · mjbvz · commit c1c3e5eab0f2 · 2019-01-28T15:45:42.000-08:00
Fixes microsoft#59523 Double encode the path so that `Uri.parse`'s decoding only strips out the first level of encoding
diff --git a/extensions/markdown-language-features/src/commands/openDocumentLink.ts b/extensions/markdown-language-features/src/commands/openDocumentLink.ts
@@ -25,7 +25,7 @@ export class OpenDocumentLinkCommand implements Command {
 		path: string,
 		fragment: string
 	): vscode.Uri {
-		return vscode.Uri.parse(`command:${OpenDocumentLinkCommand.id}?${encodeURIComponent(JSON.stringify({ path, fragment }))}`);
+		return vscode.Uri.parse(`command:${OpenDocumentLinkCommand.id}?${encodeURIComponent(JSON.stringify({ path: encodeURIComponent(path), fragment }))}`);
 	}
 
 	public constructor(

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class OpenDocumentLinkCommand implements Command {`
`25`	`25`	`path: string,`
`26`	`26`	`fragment: string`
`27`	`27`	`): vscode.Uri {`
`28`		- return vscode.Uri.parse(`command:${OpenDocumentLinkCommand.id}?${encodeURIComponent(JSON.stringify({ path, fragment }))}`);
	`28`	+ return vscode.Uri.parse(`command:${OpenDocumentLinkCommand.id}?${encodeURIComponent(JSON.stringify({ path: encodeURIComponent(path), fragment }))}`);
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public constructor(`