Skip to content

Commit b79ede8

Browse files
committed
1 parent 1db2641 commit b79ede8

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ import { ICommandService } from 'vs/platform/commands/common/commands';
5959
import { isWeb } from 'vs/base/common/platform';
6060
import { installLocalInRemoteIcon } from 'vs/workbench/contrib/extensions/browser/extensionsIcons';
6161
import { registerAction2, Action2, MenuId } from 'vs/platform/actions/common/actions';
62-
import { WorkspaceTrustContext } from 'vs/workbench/services/workspaces/common/workspaceTrust';
6362

6463
const SearchMarketplaceExtensionsContext = new RawContextKey<boolean>('searchMarketplaceExtensions', false);
6564
const SearchIntalledExtensionsContext = new RawContextKey<boolean>('searchInstalledExtensions', false);
@@ -411,14 +410,14 @@ export class ExtensionsViewletViewsContribution implements IWorkbenchContributio
411410
id: 'workbench.views.extensions.untrustedUnsupportedExtensions',
412411
name: localize('untrustedUnsupportedExtensions', "Disabled in Restricted Mode"),
413412
ctorDescriptor: new SyncDescriptor(UntrustedWorkspaceUnsupportedExtensionsView, [{}]),
414-
when: ContextKeyExpr.and(WorkspaceTrustContext.IsTrusted.negate(), SearchUnsupportedWorkspaceExtensionsContext),
413+
when: ContextKeyExpr.and(SearchUnsupportedWorkspaceExtensionsContext),
415414
});
416415

417416
viewDescriptors.push({
418417
id: 'workbench.views.extensions.untrustedPartiallySupportedExtensions',
419418
name: localize('untrustedPartiallySupportedExtensions', "Limited in Restricted Mode"),
420419
ctorDescriptor: new SyncDescriptor(UntrustedWorkspacePartiallySupportedExtensionsView, [{}]),
421-
when: ContextKeyExpr.and(WorkspaceTrustContext.IsTrusted.negate(), SearchUnsupportedWorkspaceExtensionsContext),
420+
when: ContextKeyExpr.and(SearchUnsupportedWorkspaceExtensionsContext),
422421
});
423422

424423
viewDescriptors.push({

src/vs/workbench/contrib/extensions/browser/extensionsViews.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -553,15 +553,8 @@ export class ExtensionsListView extends ViewPane {
553553
}
554554

555555
private filterWorkspaceUnsupportedExtensions(local: IExtension[], query: Query, options: IQueryOptions): IExtension[] {
556-
557556
// shows local extensions which are restricted or disabled in the current workspace because of the extension's capability
558557

559-
const inVirtualWorkspace = isVirtualWorkspace(this.workspaceService.getWorkspace());
560-
const inRestrictedWorkspace = !this.workspaceTrustManagementService.isWorkpaceTrusted();
561-
if (!inVirtualWorkspace && !inRestrictedWorkspace) {
562-
return [];
563-
}
564-
565558
let queryString = query.value; // @sortby is already filtered out
566559

567560
const match = queryString.match(/^\s*@workspaceUnsupported(?::(untrusted|virtual)(Partial)?)?(?:\s+([^\s]*))?/i);
@@ -594,12 +587,15 @@ export class ExtensionsListView extends ViewPane {
594587
return false;
595588
};
596589

590+
const inVirtualWorkspace = isVirtualWorkspace(this.workspaceService.getWorkspace());
591+
const inRestrictedWorkspace = !this.workspaceTrustManagementService.isWorkpaceTrusted();
592+
597593
if (type === 'virtual') {
598594
// show limited and disabled extensions unless disabled because of a untrusted workspace
599595
local = local.filter(extension => inVirtualWorkspace && hasVirtualSupportType(extension, partial ? 'limited' : false) && !(inRestrictedWorkspace && hasRestrictedSupportType(extension, false)));
600596
} else if (type === 'untrusted') {
601597
// show limited and disabled extensions unless disabled because of a virtual workspace
602-
local = local.filter(extension => inRestrictedWorkspace && hasRestrictedSupportType(extension, partial ? 'limited' : false) && !(inVirtualWorkspace && hasVirtualSupportType(extension, false)));
598+
local = local.filter(extension => hasRestrictedSupportType(extension, partial ? 'limited' : false) && !(inVirtualWorkspace && hasVirtualSupportType(extension, false)));
603599
} else {
604600
// show extensions that are restricted or disabled in the current workspace
605601
local = local.filter(extension => inVirtualWorkspace && !hasVirtualSupportType(extension, true) || inRestrictedWorkspace && !hasRestrictedSupportType(extension, true));

0 commit comments

Comments
 (0)