@@ -585,11 +585,9 @@ export class EditorService extends Disposable implements EditorServiceImpl {
585
585
}
586
586
587
587
// Typed editors that cannot convert to untyped will be taken
588
- // as is without override. We still want to resolve a group though.
588
+ // as is without override.
589
589
if ( ! untypedEditor ) {
590
- const [ group , activation ] = this . findTargetGroup ( editor , preferredGroup ) ;
591
-
592
- return [ OverrideStatus . NONE , group , activation ] ;
590
+ return [ OverrideStatus . NONE , undefined , undefined ] ;
593
591
}
594
592
595
593
// We need a `override` for the untyped editor if it is
@@ -601,11 +599,14 @@ export class EditorService extends Disposable implements EditorServiceImpl {
601
599
return [ OverrideStatus . ABORT , undefined , undefined ] ; // we could not resolve the editor id
602
600
}
603
601
604
- untypedEditor . options = untypedEditor . options ?. override ? untypedEditor . options : { ...untypedEditor . options , override : DEFAULT_EDITOR_ASSOCIATION . id } ;
605
-
606
602
hasConflictingDefaults = populatedInfo . conflictingDefault ;
607
603
}
608
604
605
+ // If we didn't get an override just return as none and let the editor continue as normal
606
+ if ( ! untypedEditor . options ?. override ) {
607
+ return [ OverrideStatus . NONE , undefined , undefined ] ;
608
+ }
609
+
609
610
// Find the target group for the editor
610
611
const [ group , activation ] = this . findTargetGroup ( untypedEditor , preferredGroup ) ;
611
612
0 commit comments