Debug view should show when a breakpoint is hit

fixes microsoft#119646

Author: isidorn

src/vs/workbench/contrib/debug/browser/debug.contribution.ts

@@ -414,7 +414,7 @@ configurationRegistry.registerConfiguration({
 		},
 		'debug.openDebug': {
 			enum: ['neverOpen', 'openOnSessionStart', 'openOnFirstSessionStart', 'openOnDebugBreak'],
-			default: 'openOnFirstSessionStart',
+			default: 'openOnDebugBreak',
 			description: nls.localize('openDebug', "Controls when the debug view should open.")
 		},
 		'debug.showSubSessionsInToolBar': {

src/vs/workbench/contrib/debug/browser/debugService.ts

@@ -501,7 +501,7 @@ export class DebugService implements IDebugService {
 
 		const openDebug = this.configurationService.getValue<IDebugConfiguration>('debug').openDebug;
 		// Open debug viewlet based on the visibility of the side bar and openDebug setting. Do not open for 'run without debug'
-		if (!configuration.resolved.noDebug && (openDebug === 'openOnSessionStart' || (openDebug === 'openOnFirstSessionStart' && this.viewModel.firstSessionStart))) {
+		if (!configuration.resolved.noDebug && (openDebug === 'openOnSessionStart' || (openDebug !== 'neverOpen' && this.viewModel.firstSessionStart))) {
 			await this.viewletService.openViewlet(VIEWLET_ID);
 		}