adjust tests

Author: archmoj

test/jasmine/assets/check_component.js

@@ -9,7 +9,7 @@ var destroyGraphDiv = require('../assets/destroy_graph_div');
  * but the test is that they may have been registered in any order
  */
 module.exports = function checkComponent(Plotly) {
-    describe('core (svg 2d, scatter) and registered (bar) traces and transforms', function() {
+    describe('core (svg 2d, scatter) and registered (bar) traces', function() {
         var gd;
 
         var mock = {
@@ -23,15 +23,6 @@ module.exports = function checkComponent(Plotly) {
                     x: ['2001-01-01', '2002-01-01', '2003-01-01'],
                     y: [1, 3, 5],
                     type: 'bar',
-                    transforms: [{
-                        type: 'filter',
-                        operation: '<',
-                        target: 'y',
-                        value: '4',
-                        // need an explicit calendar, as filter uses a default of null
-                        // the rest of them get the default calendar filled in
-                        valuecalendar: 'nepali'
-                    }]
                 }
             ]
         };
@@ -59,7 +50,6 @@ module.exports = function checkComponent(Plotly) {
 
             expect(nodes.size()).toEqual(1);
             expect(gd._fullData[1].xcalendar).toBe('gregorian');
-            expect(gd._fullData[1].transforms[0].valuecalendar).toBe('nepali');
         });
     });
 

test/jasmine/assets/mock_lists.js

@@ -44,7 +44,6 @@ var svgMockList = [
     ['table_wrapped_birds', require('../../image/mocks/table_wrapped_birds.json')],
     ['ternary_fill', require('../../image/mocks/ternary_fill.json')],
     ['text_chart_arrays', require('../../image/mocks/text_chart_arrays.json')],
-    ['transforms', require('../../image/mocks/transforms.json')],
     ['updatemenus', require('../../image/mocks/updatemenus.json')],
     ['violin_side-by-side', require('../../image/mocks/violin_side-by-side.json')],
     ['world-cals', require('../../image/mocks/world-cals.json')],

test/jasmine/bundle_tests/component_first_test.js

@@ -6,7 +6,7 @@ var Calendars = require('../../../lib/calendars');
 
 var checkComponent = require('../assets/check_component');
 
-describe('Bundle with a component loaded before traces and transforms', function() {
+describe('Bundle with a component loaded before traces', function() {
     'use strict';
 
     Plotly.register([Calendars, Filter, Scatter3d, Bar]);

test/jasmine/bundle_tests/component_last_test.js

@@ -6,7 +6,7 @@ var Calendars = require('../../../lib/calendars');
 
 var checkComponent = require('../assets/check_component');
 
-describe('Bundle with a component loaded after traces and transforms', function() {
+describe('Bundle with a component loaded after traces', function() {
     'use strict';
 
     Plotly.register([Bar, Scatter3d, Filter, Calendars]);

test/jasmine/bundle_tests/finance_test.js

@@ -14,12 +14,6 @@ describe('Bundle with finance trace type', function() {
 
     var mock = require('../../image/mocks/finance_style.json');
 
-    it('should not register transforms anymore', function() {
-        var transformModules = Object.keys(Plots.transformsRegistry);
-
-        expect(transformModules).toEqual([]);
-    });
-
     it('should register the correct trace modules for the generated traces', function() {
         var traceModules = Object.keys(Plots.modules);
 

test/jasmine/bundle_tests/plotschema_test.js

@@ -36,14 +36,6 @@ describe('plot schema', function() {
         });
     }
 
-    function assertTransformSchema(callback) {
-        var transforms = plotSchema.transforms;
-
-        Object.keys(transforms).forEach(function(transformName) {
-            Plotly.PlotSchema.crawl(transforms[transformName].attributes, callback, 0, transformName);
-        });
-    }
-
     function assertLayoutSchema(callback) {
         Plotly.PlotSchema.crawl(plotSchema.layout.layoutAttributes, callback, 0, 'layout');
 
@@ -60,7 +52,6 @@ describe('plot schema', function() {
     function assertPlotSchema(callback) {
         assertTraceSchema(callback);
         assertLayoutSchema(callback);
-        assertTransformSchema(callback);
     }
 
     it('all attributes should have a valid `valType`', function() {
@@ -271,13 +262,6 @@ describe('plot schema', function() {
             }
         });
 
-        assertTransformSchema(function(attr, attrName, attrs, level, attrString) {
-            if(shouldHaveEditType(attr, attrName)) {
-                expect(Lib.validate(attr.editType, editType.traces))
-                    .toBe(true, attrString + ': ' + JSON.stringify(attr.editType));
-            }
-        });
-
         assertLayoutSchema(function(attr, attrName, attrs, level, attrString) {
             if(shouldHaveEditType(attr, attrName)) {
                 expect(Lib.validate(attr.editType, editType.layout))
@@ -286,34 +270,6 @@ describe('plot schema', function() {
         });
     });
 
-    it('should work with registered transforms', function() {
-        var valObjects = plotSchema.transforms.filter.attributes;
-        var attrNames = Object.keys(valObjects);
-
-        ['operation', 'value', 'target'].forEach(function(k) {
-            expect(attrNames).toContain(k);
-        });
-    });
-
-    it('should work with registered transforms (2)', function() {
-        var valObjects = plotSchema.transforms.groupby.attributes;
-        var items = valObjects.styles.items || {};
-
-        expect(Object.keys(items)).toEqual(['style']);
-    });
-
-    it('should work with registered components', function() {
-        expect(plotSchema.traces.scatter.attributes.xcalendar.valType).toEqual('enumerated');
-        expect(plotSchema.traces.scatter3d.attributes.zcalendar.valType).toEqual('enumerated');
-
-        expect(plotSchema.layout.layoutAttributes.calendar.valType).toEqual('enumerated');
-        expect(plotSchema.layout.layoutAttributes.xaxis.calendar.valType).toEqual('enumerated');
-        expect(plotSchema.layout.layoutAttributes.scene.xaxis.calendar.valType).toEqual('enumerated');
-
-        expect(plotSchema.transforms.filter.attributes.valuecalendar.valType).toEqual('enumerated');
-        expect(plotSchema.transforms.filter.attributes.targetcalendar.valType).toEqual('enumerated');
-    });
-
     it('should list correct defs', function() {
         expect(plotSchema.defs.valObjects).toBeDefined();
 
@@ -440,34 +396,6 @@ describe('getTraceValObject', function() {
             .toBe(surface.attributes.zcalendar);
     });
 
-    it('supports transform attributes', function() {
-        var mockTrace = {transforms: [
-            {type: 'filter'},
-            {type: 'groupby'}
-        ]};
-
-        var filterAttrs = require('../../../lib/filter').attributes;
-        expect(getTraceValObject(mockTrace, ['transforms', 0, 'operation']))
-            .toBe(filterAttrs.operation);
-        // check a component-provided attr
-        expect(getTraceValObject(mockTrace, ['transforms', 0, 'valuecalendar']))
-            .toBe(filterAttrs.valuecalendar);
-
-        expect(getTraceValObject(mockTrace, ['transforms', 1, 'styles', 13, 'value', 'line', 'color']))
-            .toBe(require('../../../lib/groupby').attributes.styles.value);
-
-        [
-            ['transforms', 0],
-            ['transforms', 0, 'nameformat'],
-            ['transforms', 2, 'enabled'],
-            ['transforms', '0', 'operation']
-        ].forEach(function(attrArray) {
-            expect(getTraceValObject(mockTrace, attrArray)).toBe(false, attrArray);
-        });
-
-        expect(getTraceValObject({}, ['transforms', 0, 'operation'])).toBe(false);
-    });
-
     it('does not return attribute properties', function() {
         // it still returns the attribute itself - but maybe we should only do this
         // for valType: any? (or data_array/arrayOk with just an index)

test/jasmine/karma.conf.js

@@ -278,7 +278,7 @@ func.defaultConfig = {
         //
         // Although not recommended, some tests "depend" on other
         // tests to pass (e.g. the Plotly.react tests check that
-        // all available traces and transforms are tested). Tag these
+        // all available traces are tested). Tag these
         // with @noCIdep, so that
         // - $ npm run test-jasmine -- tags=noCI,noCIdep
         // can pass.

test/jasmine/tests/animate_test.js

@@ -974,28 +974,6 @@ describe('animating scatter traces', function() {
         }).then(done, done.fail);
     });
 
-    it('computes calcdata correctly when transforms are present', function(done) {
-        Plotly.newPlot(gd, {
-            data: [{
-                x: [1, 2, 3],
-                y: [1, 2, 3],
-                mode: 'markers',
-                transforms: [{
-                    type: 'sort',
-                    target: [1, 3, 2]
-                }]
-            }],
-            frames: [
-                {name: 'frame1', data: [{y: [1, 2, 3]}]},
-                {name: 'frame2', data: [{y: [3, 1, 2]}]}
-            ]
-        }).then(function() {
-            return Plotly.animate(gd, ['frame2'], {frame: {duration: 200, redraw: false}});
-        }).then(function() {
-            expect(gd.calcdata[0][0].y).toEqual(3);
-        }).then(done, done.fail);
-    });
-
     it('@flaky should animate axis ranges using the less number of steps', function(done) {
         // sanity-check that scatter points and bars are still there
         function _assertNodeCnt() {

test/jasmine/tests/finance_test.js

@@ -55,67 +55,6 @@ describe('finance charts defaults:', function() {
         expect(out._fullData.length).toEqual(2);
     });
 
-    it('should not mutate user data', function() {
-        var trace0 = Lib.extendDeep({}, mock0, {
-            type: 'ohlc'
-        });
-
-        var trace1 = Lib.extendDeep({}, mock1, {
-            type: 'candlestick'
-        });
-
-        var out = _supply([trace0, trace1]);
-        expect(out.data[0]).toBe(trace0);
-        expect(out.data[0].transforms).toBeUndefined();
-        expect(out.data[1]).toBe(trace1);
-        expect(out.data[1].transforms).toBeUndefined();
-
-        // ... and in an idempotent way
-
-        var out2 = _supply(out.data);
-        expect(out2.data[0]).toBe(trace0);
-        expect(out2.data[0].transforms).toBeUndefined();
-        expect(out2.data[1]).toBe(trace1);
-        expect(out2.data[1].transforms).toBeUndefined();
-    });
-
-    it('should work with transforms', function() {
-        var trace0 = Lib.extendDeep({}, mock1, {
-            type: 'ohlc',
-            transforms: [{
-                type: 'filter'
-            }]
-        });
-
-        var trace1 = Lib.extendDeep({}, mock0, {
-            type: 'candlestick',
-            transforms: [{
-                type: 'filter'
-            }]
-        });
-
-        var out = _supply([trace0, trace1]);
-
-        expect(out.data.length).toEqual(2);
-        expect(out._fullData.length).toEqual(2);
-
-        var transformTypesIn = out.data.map(function(trace) {
-            return trace.transforms.map(function(opts) {
-                return opts.type;
-            });
-        });
-
-        expect(transformTypesIn).toEqual([ ['filter'], ['filter'] ]);
-
-        var transformTypesOut = out._fullData.map(function(fullTrace) {
-            return fullTrace.transforms.map(function(opts) {
-                return opts.type;
-            });
-        });
-
-        expect(transformTypesOut).toEqual([ ['filter'], ['filter'] ]);
-    });
-
     it('should not slice data arrays but record minimum supplied length', function() {
         function assertDataLength(trace, fullTrace, len) {
             expect(fullTrace.visible).toBe(true);
@@ -446,110 +385,6 @@ describe('finance charts calc', function() {
         expect(mapGet(out[1], 'empty')).toEqual(empties);
     });
 
-    it('should work with *filter* transforms', function() {
-        var trace0 = Lib.extendDeep({}, mock1, {
-            type: 'ohlc',
-            tickwidth: 0.05,
-            transforms: [{
-                type: 'filter',
-                operation: '>',
-                target: 'open',
-                value: 33
-            }]
-        });
-
-        var trace1 = Lib.extendDeep({}, mock1, {
-            type: 'candlestick',
-            transforms: [{
-                type: 'filter',
-                operation: '{}',
-                target: 'x',
-                value: ['2016-09-01', '2016-09-10']
-            }]
-        });
-
-        var out = _calc([trace0, trace1]);
-
-        expect(out.length).toEqual(2);
-
-        expect(out[0].x).toEqual([
-            '2016-09-01', '2016-09-02', '2016-09-03', '2016-09-05', '2016-09-06', '2016-09-07', '2016-09-10'
-        ]);
-        expect(out[0].open).toEqual([
-            33.01, 33.31, 33.50, 34.12, 33.05, 33.31, 33.50
-        ]);
-
-        expect(out[1].x).toEqual([
-            '2016-09-01', '2016-09-10'
-        ]);
-        expect(out[1].close).toEqual([
-            34.10, 33.70
-        ]);
-    });
-
-    it('should work with *groupby* transforms (ohlc)', function() {
-        var opts = {
-            type: 'groupby',
-            groups: ['b', 'b', 'b', 'a'],
-        };
-
-        var trace0 = Lib.extendDeep({}, mock1, {
-            type: 'ohlc',
-            tickwidth: 0.05,
-            transforms: [opts]
-        });
-
-        var out = _calc([trace0]);
-
-        expect(out.length).toBe(2);
-
-        expect(out[0].name).toBe('b');
-        expect(out[0].x).toEqual([
-            '2016-09-01', '2016-09-02', '2016-09-03'
-        ]);
-        expect(out[0].open).toEqual([
-            33.01, 33.31, 33.5
-        ]);
-
-        expect(out[1].name).toBe('a');
-        expect(out[1].x).toEqual([
-            '2016-09-04'
-        ]);
-        expect(out[1].open).toEqual([
-            32.06
-        ]);
-    });
-
-    it('should work with *groupby* transforms (candlestick)', function() {
-        var opts = {
-            type: 'groupby',
-            groups: ['a', 'b', 'b', 'a'],
-        };
-
-        var trace0 = Lib.extendDeep({}, mock1, {
-            type: 'candlestick',
-            transforms: [opts]
-        });
-
-        var out = _calc([trace0]);
-
-        expect(out[0].name).toEqual('a');
-        expect(out[0].x).toEqual([
-            '2016-09-01', '2016-09-04'
-        ]);
-        expect(out[0].open).toEqual([
-            33.01, 32.06
-        ]);
-
-        expect(out[1].name).toEqual('b');
-        expect(out[1].x).toEqual([
-            '2016-09-02', '2016-09-03'
-        ]);
-        expect(out[1].open).toEqual([
-            33.31, 33.5
-        ]);
-    });
-
     it('should use the smallest trace minimum x difference to convert *tickwidth* to data coords for all traces attached to a given x-axis', function() {
         var trace0 = Lib.extendDeep({}, mock1, {
             type: 'ohlc'