Disable Terminal transparency (runs awfully), WM doesn't invalidate

whole window when contents are dirty

Author: fido2020

Applications/Terminal/colours.h

@@ -259,7 +259,7 @@ rgba_colour_t coloursProfile1[] = {
 };
 
 rgba_colour_t coloursProfile2[] = {
-	{ 0x14, 0x14, 0x14, 200},	   // Black
+	RGBAColour::FromRGB(0x000000), // Black
 	RGBAColour::FromRGB(0xea192f), // Dark Red
 	RGBAColour::FromRGB(0xb0db43), // Dark Green
 	RGBAColour::FromRGB(0xffc145), // Dark Yellow

Applications/Terminal/main.cpp

@@ -475,7 +475,7 @@ void* PTYThread() {
 }
 
 int main(int argc, char** argv) {
-    terminalWindow = new GUI::Window("Terminal", {720, 480}, GUI::WindowFlag_Resizable | GUI::WindowFlag_Transparent,
+    terminalWindow = new GUI::Window("Terminal", {720, 480}, GUI::WindowFlag_Resizable,
                                      GUI::WindowType::Basic);
     terminalWindow->OnPaint = OnPaint;
 

System/LemonWM/Compositor.cpp

@@ -86,7 +86,29 @@ void Compositor::Render() {
     } else {
         for (WMWindow* win : WM::Instance().m_windows) {
             if (win->IsDirtyAndClear()) {
-                Invalidate(win->GetContentRect());
+                // If the window is transparent, we will need to invalidate
+                // any rects underneath the window
+
+                // If the window is occluded, we will need to invalidate any rects
+                // above the clip
+
+                // Otherwise, just set the window rect as invalid
+                // and move on
+
+                if(win->IsTransparent()) for(auto& r : m_windowClipRects) {
+                    if(r.win == win) {
+                        Invalidate(r.rect);
+                    }
+                } else for(auto& r : m_windowClipRects) {
+                    if(r.win == win) {
+                        if(r.occluded) {
+                            Invalidate(r.rect);
+                        } else {
+                            r.invalid = true;
+                        }
+                    }
+                }
+                
             }
         }
     }