Skip to content

Commit a54a8fe

Browse files
meshulameshula
committed
Tag all the overridden methods
1 parent da35692 commit a54a8fe

File tree

1 file changed

+38
-5
lines changed

1 file changed

+38
-5
lines changed

‎src/LabSoundInterface.cpp

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ void LabSoundProvider::create_noodle_data_for_node(
8989
if (!audio_node)
9090
return;
9191

92+
// prep the reverse table if necessary
9293
auto reverse_it = g_node_reverse_lookups.find(node.id);
9394
if (reverse_it == g_node_reverse_lookups.end())
9495
{
@@ -97,6 +98,8 @@ void LabSoundProvider::create_noodle_data_for_node(
9798
}
9899
auto& reverse = reverse_it->second;
99100

101+
//---------- custom renderers
102+
100103
lab::ContextRenderLock r(g_audio_context.get(), "LabSoundGraphToy_init");
101104
if (nullptr != dynamic_cast<lab::AnalyserNode*>(audio_node.get()))
102105
{
@@ -116,8 +119,9 @@ void LabSoundProvider::create_noodle_data_for_node(
116119
{
117120
ln_Pin pin_id = { create_entity(), true };
118121
node.pins.push_back(pin_id);
119-
std::string name = ""; // audio_node->input(i)->name(); @TODO an IDL for all the things
120-
reverse.input_pin_map[name] = pin_id;
122+
// currently input names are not part of the LabSound API
123+
std::string name = ""; //audio_node->input(i)->name();
124+
reverse.input_pin_map[name] = pin_id; // making this line currently meaningless
121125
_noodlePins[pin_id] = lab::noodle::NoodlePin{
122126
lab::noodle::NoodlePin::Kind::BusIn,
123127
lab::noodle::NoodlePin::DataType::Bus,
@@ -192,7 +196,6 @@ void LabSoundProvider::create_noodle_data_for_node(
192196
ln_Pin pin_id{ create_entity(), true };
193197
node.pins.push_back(pin_id);
194198
_audioPins[pin_id] = LabSoundPinData{ 0, settings[i] };
195-
196199
_noodlePins[pin_id] = lab::noodle::NoodlePin {
197200
lab::noodle::NoodlePin::Kind::Setting,
198201
dataType,
@@ -233,7 +236,9 @@ void LabSoundProvider::create_noodle_data_for_node(
233236
}
234237
}
235238

236-
void LabSoundProvider::pin_set_setting_bus_value(const std::string& node_name, const std::string& setting_name, const std::string& path)
239+
// override
240+
void LabSoundProvider::pin_set_setting_bus_value(
241+
const std::string& node_name, const std::string& setting_name, const std::string& path)
237242
{
238243
ln_Node node = entity_for_node_named(node_name);
239244
if (!node.valid)
@@ -256,6 +261,7 @@ void LabSoundProvider::pin_set_setting_bus_value(const std::string& node_name, c
256261
}
257262
}
258263

264+
// override
259265
void LabSoundProvider::pin_set_bus_from_file(ln_Pin pin_id, const std::string& path)
260266
{
261267
if (!pin_id.valid || !path.length())
@@ -280,6 +286,7 @@ void LabSoundProvider::pin_set_bus_from_file(ln_Pin pin_id, const std::string& p
280286
}
281287
}
282288

289+
// override
283290
void LabSoundProvider::connect_bus_out_to_bus_in(ln_Node output_node_id, ln_Pin output_pin_id, ln_Node input_node_id)
284291
{
285292
if (!output_node_id.valid || !output_pin_id.valid || !input_node_id.valid)
@@ -301,6 +308,7 @@ void LabSoundProvider::connect_bus_out_to_bus_in(ln_Node output_node_id, ln_Pin
301308
printf("ConnectBusOutToBusIn %lld %lld\n", input_node_id.id, output_node_id.id);
302309
}
303310

311+
// override
304312
void LabSoundProvider::connect_bus_out_to_param_in(ln_Node output_node_id, ln_Pin output_pin_id, ln_Pin param_pin_id)
305313
{
306314
if (!output_node_id.valid || !output_pin_id.valid || !param_pin_id.valid)
@@ -342,6 +350,7 @@ void LabSoundProvider::connect_bus_out_to_param_in(ln_Node output_node_id, ln_Pi
342350
printf("ConnectBusOutToParamIn %lld %lld, index %d\n", param_pin_id.id, output_node_id.id, output_index);
343351
}
344352

353+
// override
345354
void LabSoundProvider::disconnect(ln_Connection connection_id_)
346355
{
347356
auto conn = _connections.find(connection_id_);
@@ -397,6 +406,7 @@ void LabSoundProvider::disconnect(ln_Connection connection_id_)
397406
return;
398407
}
399408

409+
// override
400410
ln_Context LabSoundProvider::create_runtime_context(ln_Node id)
401411
{
402412
const auto defaultAudioDeviceConfigurations = GetDefaultAudioDeviceConfiguration(true);
@@ -417,6 +427,7 @@ ln_Context LabSoundProvider::create_runtime_context(ln_Node id)
417427
return ln_Context{id.id};
418428
}
419429

430+
// override
420431
void LabSoundProvider::node_start_stop(ln_Node node_id, float when)
421432
{
422433
if (node_id.id == ln_Node_null().id)
@@ -444,6 +455,7 @@ void LabSoundProvider::node_start_stop(ln_Node node_id, float when)
444455
}
445456
}
446457

458+
// override
447459
void LabSoundProvider::node_bang(ln_Node node_id)
448460
{
449461
if (node_id.id == ln_Node_null().id)
@@ -467,6 +479,7 @@ void LabSoundProvider::node_bang(ln_Node node_id)
467479
printf("Bang %lld\n", node_id.id);
468480
}
469481

482+
// override
470483
ln_Pin LabSoundProvider::node_output_named(ln_Node node_id, const std::string& output_name)
471484
{
472485
if (!node_id.valid)
@@ -496,6 +509,7 @@ ln_Pin LabSoundProvider::node_output_named(ln_Node node_id, const std::string& o
496509
return result;
497510
}
498511

512+
// override
499513
ln_Pin LabSoundProvider::node_input_with_index(ln_Node node_id, int output)
500514
{
501515
if (!node_id.valid)
@@ -525,6 +539,7 @@ ln_Pin LabSoundProvider::node_input_with_index(ln_Node node_id, int output)
525539
return result;
526540
}
527541

542+
// override
528543
ln_Pin LabSoundProvider::node_output_with_index(ln_Node node_id, int output)
529544
{
530545
if (!node_id.valid)
@@ -554,6 +569,7 @@ ln_Pin LabSoundProvider::node_output_with_index(ln_Node node_id, int output)
554569
return result;
555570
}
556571

572+
// override
557573
ln_Pin LabSoundProvider::node_param_named(ln_Node node_id, const std::string& output_name)
558574
{
559575
if (!node_id.valid)
@@ -583,6 +599,7 @@ ln_Pin LabSoundProvider::node_param_named(ln_Node node_id, const std::string& ou
583599
return result;
584600
}
585601

602+
// override
586603
ln_Node LabSoundProvider::node_create(const std::string& kind, ln_Node id)
587604
{
588605
if (kind == "OSC")
@@ -613,6 +630,7 @@ ln_Node LabSoundProvider::node_create(const std::string& kind, ln_Node id)
613630
return ln_Node{ id };
614631
}
615632

633+
// override
616634
void LabSoundProvider::node_delete(ln_Node node_id)
617635
{
618636
if (node_id.id != ln_Node_null().id)
@@ -664,6 +682,7 @@ void LabSoundProvider::node_delete(ln_Node node_id)
664682
}
665683
}
666684

685+
// override
667686
char const* const* LabSoundProvider::node_names() const
668687
{
669688
static std::vector<const char*> names;
@@ -679,6 +698,7 @@ char const* const* LabSoundProvider::node_names() const
679698
return &names[0];
680699
}
681700

701+
// override
682702
void LabSoundProvider::pin_set_param_value(const std::string& node_name, const std::string& param_name, float v)
683703
{
684704
ln_Node node = entity_for_node_named(node_name);
@@ -698,6 +718,7 @@ void LabSoundProvider::pin_set_param_value(const std::string& node_name, const s
698718
p->setValue(v);
699719
}
700720

721+
// override
701722
void LabSoundProvider::pin_set_setting_float_value(const std::string& node_name, const std::string& setting_name, float v)
702723
{
703724
ln_Node node = entity_for_node_named(node_name);
@@ -717,6 +738,7 @@ void LabSoundProvider::pin_set_setting_float_value(const std::string& node_name,
717738
s->setFloat(v);
718739
}
719740

741+
// override
720742
void LabSoundProvider::pin_set_float_value(ln_Pin pin, float v)
721743
{
722744
if (!pin.valid)
@@ -739,6 +761,7 @@ void LabSoundProvider::pin_set_float_value(ln_Pin pin, float v)
739761
}
740762
}
741763

764+
// override
742765
float LabSoundProvider::pin_float_value(ln_Pin pin)
743766
{
744767
if (!pin.valid)
@@ -757,6 +780,7 @@ float LabSoundProvider::pin_float_value(ln_Pin pin)
757780
return 0.f;
758781
}
759782

783+
// override
760784
void LabSoundProvider::pin_set_setting_int_value(const std::string& node_name, const std::string& setting_name, int v)
761785
{
762786
ln_Node node = entity_for_node_named(node_name);
@@ -776,6 +800,7 @@ void LabSoundProvider::pin_set_setting_int_value(const std::string& node_name, c
776800
s->setUint32(v);
777801
}
778802

803+
// override
779804
void LabSoundProvider::pin_set_int_value(ln_Pin pin, int v)
780805
{
781806
if (!pin.valid)
@@ -798,6 +823,7 @@ void LabSoundProvider::pin_set_int_value(ln_Pin pin, int v)
798823
}
799824
}
800825

826+
// override
801827
int LabSoundProvider::pin_int_value(ln_Pin pin)
802828
{
803829
if (!pin.valid)
@@ -816,7 +842,7 @@ int LabSoundProvider::pin_int_value(ln_Pin pin)
816842
return 0;
817843
}
818844

819-
845+
// override
820846
void LabSoundProvider::pin_set_enumeration_value(ln_Pin pin, const std::string& value)
821847
{
822848
if (!pin.valid)
@@ -838,6 +864,7 @@ void LabSoundProvider::pin_set_enumeration_value(ln_Pin pin, const std::string&
838864
}
839865
}
840866

867+
// override
841868
void LabSoundProvider::pin_set_setting_enumeration_value(const std::string& node_name, const std::string& setting_name, const std::string& value)
842869
{
843870
ln_Node node = entity_for_node_named(node_name);
@@ -864,6 +891,7 @@ void LabSoundProvider::pin_set_setting_enumeration_value(const std::string& node
864891
}
865892
}
866893

894+
// override
867895
void LabSoundProvider::pin_set_setting_bool_value(const std::string& node_name, const std::string& setting_name, bool v)
868896
{
869897
ln_Node node = entity_for_node_named(node_name);
@@ -883,6 +911,7 @@ void LabSoundProvider::pin_set_setting_bool_value(const std::string& node_name,
883911
s->setBool(v);
884912
}
885913

914+
// override
886915
void LabSoundProvider::pin_set_bool_value(ln_Pin pin, bool v)
887916
{
888917
if (!pin.valid)
@@ -905,6 +934,7 @@ void LabSoundProvider::pin_set_bool_value(ln_Pin pin, bool v)
905934
}
906935
}
907936

937+
// override
908938
bool LabSoundProvider::pin_bool_value(ln_Pin pin)
909939
{
910940
if (!pin.valid)
@@ -923,6 +953,7 @@ bool LabSoundProvider::pin_bool_value(ln_Pin pin)
923953
return false;
924954
}
925955

956+
// override
926957
void LabSoundProvider::pin_create_output(const std::string& node_name, const std::string& output_name, int channels)
927958
{
928959
ln_Node node_e = entity_for_node_named(node_name);
@@ -973,6 +1004,7 @@ void LabSoundProvider::pin_create_output(const std::string& node_name, const std
9731004
}
9741005
}
9751006

1007+
// node_get_timing
9761008
float LabSoundProvider::node_get_timing(ln_Node node)
9771009
{
9781010
auto n_it = _audioNodes.find(node);
@@ -986,6 +1018,7 @@ float LabSoundProvider::node_get_timing(ln_Node node)
9861018
return n->graphTime.microseconds.count() * 1.e-6f;
9871019
}
9881020

1021+
// override
9891022
float LabSoundProvider::node_get_self_timing(ln_Node node)
9901023
{
9911024
auto n_it = _audioNodes.find(node);

0 commit comments

Comments
 (0)