Merge pull request kensho-technologies#168 from kensho-technologies/add-sql-unittests

Adding unit-tests for SQL backend.

Author: jmeulemans

graphql_compiler/compiler/ir_lowering_sql/__init__.py

@@ -50,6 +50,7 @@ def lower_ir(ir_blocks, query_metadata_table, type_equivalence_hints=None):
 
     # perform lowering steps
     ir_blocks = lower_unary_transformations(ir_blocks)
+    ir_blocks = lower_unsupported_metafield_expressions(ir_blocks)
 
     # iteratively construct SqlTree
     query_path_to_node = {}
@@ -110,7 +111,7 @@ def _validate_all_blocks_supported(ir_blocks, query_metadata_table):
     for field_name, field in six.iteritems(construct_result.fields):
         if not isinstance(field, constants.SUPPORTED_OUTPUT_EXPRESSION_TYPES):
             unsupported_fields.append((field_name, field))
-        elif field_name in constants.UNSUPPORTED_META_FIELDS:
+        elif field.location.field in constants.UNSUPPORTED_META_FIELDS:
             unsupported_fields.append((field_name, field))
 
     if len(unsupported_blocks) > 0 or len(unsupported_fields) > 0:
@@ -249,3 +250,23 @@ def visitor_fn(expression):
         for block in ir_blocks
     ]
     return new_ir_blocks
+
+
+def lower_unsupported_metafield_expressions(ir_blocks):
+    """Raise exception if an unsupported metafield is encountered in any LocalField expression."""
+    def visitor_fn(expression):
+        """Visitor function raising exception for any unsupported metafield."""
+        if not isinstance(expression, expressions.LocalField):
+            return expression
+        if expression.field_name not in constants.UNSUPPORTED_META_FIELDS:
+            return expression
+        raise NotImplementedError(
+            u'Encountered unsupported metafield {} in LocalField {} during construction of '
+            u'SQL query tree for IR blocks {}.'.format(
+                constants.UNSUPPORTED_META_FIELDS[expression.field_name], expression, ir_blocks))
+
+    new_ir_blocks = [
+        block.visit_and_update_expressions(visitor_fn)
+        for block in ir_blocks
+    ]
+    return new_ir_blocks

graphql_compiler/compiler/ir_lowering_sql/constants.py

@@ -48,6 +48,7 @@
     u'&&': Operator(u'and_', CARDINALITY_BINARY),
     u'||': Operator(u'or_', CARDINALITY_BINARY),
     u'=': Operator(u'__eq__', CARDINALITY_UNARY),
+    u'!=': Operator(u'__ne__', CARDINALITY_UNARY),
     u'<': Operator(u'__lt__', CARDINALITY_UNARY),
     u'>': Operator(u'__gt__', CARDINALITY_UNARY),
     u'<=': Operator(u'__le__', CARDINALITY_UNARY),

graphql_compiler/tests/integration_tests/test_backends_integration.py

@@ -88,14 +88,15 @@ def test_simple_output(self, backend_name):
         {
             Animal {
                 name @output(out_name: "animal_name")
+                uuid @output(out_name: "animal_uuid")
             }
         }
         '''
         expected_results = [
-            {'animal_name': 'Animal 1'},
-            {'animal_name': 'Animal 2'},
-            {'animal_name': 'Animal 3'},
-            {'animal_name': 'Animal 4'},
+            {'animal_name': 'Animal 1', 'animal_uuid': 'cfc6e625-8594-0927-468f-f53d864a7a51'},
+            {'animal_name': 'Animal 2', 'animal_uuid': 'cfc6e625-8594-0927-468f-f53d864a7a52'},
+            {'animal_name': 'Animal 3', 'animal_uuid': 'cfc6e625-8594-0927-468f-f53d864a7a53'},
+            {'animal_name': 'Animal 4', 'animal_uuid': 'cfc6e625-8594-0927-468f-f53d864a7a54'},
         ]
         self.assertResultsEqual(graphql_query, {}, backend_name, expected_results)
 
@@ -144,4 +145,27 @@ def test_two_filters(self, backend_name):
 
         self.assertResultsEqual(graphql_query, parameters, backend_name, expected_results)
 
+    @all_backends
+    @integration_fixtures
+    def test_has_substring_precedence(self, backend_name):
+        graphql_query = '''
+        {
+            Animal {
+                name @output(out_name: "animal_name")
+                     @filter(op_name: "has_substring", value: ["$wide_substring"])
+                     @filter(op_name: "has_substring", value: ["$narrow_substring"])
+            }
+        }
+        '''
+        parameters = {
+            # matches all animal names
+            'wide_substring': 'Animal',
+            # narrows set to just ['Animal 3']
+            'narrow_substring': '3',
+        }
+        expected_results = [
+            {'animal_name': 'Animal 3'},
+        ]
+        self.assertResultsEqual(graphql_query, parameters, backend_name, expected_results)
+
 # pylint: enable=no-member