♻️ refactor: create and update todo process

Author: KhalidSaifullahFuad

app.js

@@ -49,34 +49,38 @@ const server = http.createServer((request, response) => {
 
 	// create - /api/todo : POST
 	else if (request.url == "/api/todo" && request.method === "POST") {
-		todo.createTodo().then((todo) => {
-			response.writeHead(201, CONTENT_TYPE_JSON);
-			response.end(JSON.stringify(todo));
+		getRequestBody(request).then((todoData) => {
+			todo.createTodo(todoData).then((todo) => {
+				response.writeHead(201, CONTENT_TYPE_JSON);
+				response.end(JSON.stringify(todo));
+			})
+			.catch((err) => {
+				response.writeHead(400, CONTENT_TYPE_JSON);
+				response.end(JSON.stringify(err));
+			});
+		})
+		.catch((err) => {
+			response.writeHead(400, CONTENT_TYPE_JSON);
+			response.end(JSON.stringify({ message: "Invalid request body", err }));
 		});
 	}
 
 	// update - /api/todo/ : PUT
 	else if (request.url == "/api/todo" && request.method === "PUT") {
-		let body = "";
-		request
-			.on("data", (chunk) => {
-				console.log(chunk.toString());
-				body += chunk.toString();
+		getRequestBody(request).then((todoData) => {
+			todo.updateTodo(todoData).then((todo) => {
+				response.writeHead(200, CONTENT_TYPE_JSON);
+				response.end(JSON.stringify(todo));
 			})
-			.on("end", () => {
-				const { id, title, completed, date } = JSON.parse(body);
-				const todo = { id: parseInt(id), title, completed, date };
-				new Todo()
-					.updateTodo(todo)
-					.then((todo) => {
-						response.writeHead(200, CONTENT_TYPE_JSON);
-						response.end(JSON.stringify(todo));
-					})
-					.catch((err) => {
-						response.writeHead(404, CONTENT_TYPE_JSON);
-						response.end(JSON.stringify(err));
-					});
+			.catch((err) => {
+				response.writeHead(404, CONTENT_TYPE_JSON);
+				response.end(JSON.stringify(err));
 			});
+		})
+		.catch((err) => {
+			response.writeHead(400, CONTENT_TYPE_JSON);
+			response.end(JSON.stringify({ message: "Invalid request body", err }));
+		});
 	}
 
 	// delete - /api/todo/:id : DELETE

controller.js

@@ -1,3 +1,4 @@
+// Dependencies
 const fs = require("fs");
 
 const data = require("./data.json");
@@ -21,11 +22,20 @@ class Controller {
 
 	// store
 	createTodo(todo) {
-		return new Promise((resolve) => {
+		return new Promise((resolve, reject) => {
+			const { title } = todo;
 			const id = data.reduce((max, todo) => Math.max(max, todo.id), 0) + 1;
-			const newTodo = { id, ...todo };
+			const completed = false;
+			const date = new Date().toISOString().slice(0, 10);
+			const newTodo = { id, title, completed, date };
+
+			if(!title){
+				return reject({ message: `Todo title is required` });
+			}
+
 			data.push(newTodo);
 			fs.writeFileSync("./data.json", JSON.stringify(data));
+
 			resolve(newTodo);
 		});
 	}
@@ -34,12 +44,20 @@ class Controller {
 	updateTodo(todo) {
 		return new Promise((resolve, reject) => {
 			const index = data.findIndex((item) => item.id === todo.id);
+			const date = new Date().toISOString().slice(0, 10);
+
 			if (index === -1) {
 				return reject({ message: `Todo with id ${todo.id} not found` });
 			}
-			data[index] = todo;
 
-			fs.writeFileSync("./data.json", JSON.stringify(data));
+			if(!todo.title) {
+				return reject({ message: `Todo title is required` });
+			}
+			data[index].title = todo.title;
+			data[index].completed = todo.completed || data[index].completed;
+			data[index].date = date;
+
+			fs.writeFileSync("./data.json", JSON.stringify(data[index]));
 
 			resolve(todo);
 		});

data.json

@@ -3,12 +3,24 @@
 		"id": 1,
 		"title": "Learn JavaScript",
 		"completed": true,
-		"date": "28/11/2022"
+		"date": "2022-11-28"
 	},
 	{
 		"id": 2,
 		"title": "Learn NodeJS",
 		"completed": true,
-		"date": "04/12/2022"
+		"date": "2022-12-04"
+	},
+	{
+		"id": 6,
+		"title": "Learn React",
+		"completed": false,
+		"date": "2022-12-05"
+	},
+	{
+		"id": 7,
+		"title": "Learn Unit Testing",
+		"completed": false,
+		"date": "2022-12-05"
 	}
 ]