Remove if VERSION ≥ v"1.4" etc. (#616)

* Update dual.jl

* Update prelude.jl

* Update ForwardDiff.jl

* Update GradientTest.jl

* Update DualTest.jl

* adjust tolerance for gamma_inc test

* Update runtests.jl

Author: mcabbott

src/ForwardDiff.jl

@@ -3,9 +3,7 @@ module ForwardDiff
 using DiffRules, DiffResults
 using DiffResults: DiffResult, MutableDiffResult, ImmutableDiffResult
 using StaticArrays
-if VERSION >= v"1.6"
-    using Preferences
-end
+using Preferences
 using Random
 using LinearAlgebra
 

src/dual.jl

@@ -334,11 +334,7 @@ Base.cld(x::Dual, y::Dual) = cld(value(x), value(y))
 
 Base.exponent(x::Dual) = exponent(value(x))
 
-if VERSION ≥ v"1.4"
-    Base.div(x::Dual, y::Dual, r::RoundingMode) = div(value(x), value(y), r)
-else
-    Base.div(x::Dual, y::Dual) = div(value(x), value(y))
-end
+Base.div(x::Dual, y::Dual, r::RoundingMode) = div(value(x), value(y), r)
 
 Base.hash(d::Dual) = hash(value(d))
 Base.hash(d::Dual, hsh::UInt) = hash(value(d), hsh)
@@ -697,6 +693,7 @@ end
 
 # sin/cos #
 #--------#
+
 function Base.sin(d::Dual{T}) where T
     s, c = sincos(value(d))
     return Dual{T}(s, c * partials(d))
@@ -715,11 +712,9 @@ end
 # sincospi #
 #----------#
 
-if VERSION >= v"1.6.0-DEV.292"
-    @inline function Base.sincospi(d::Dual{T}) where T
-        sd, cd = sincospi(value(d))
-        return (Dual{T}(sd, cd * π * partials(d)), Dual{T}(cd, -sd * π * partials(d)))
-    end
+@inline function Base.sincospi(d::Dual{T}) where T
+    sd, cd = sincospi(value(d))
+    return (Dual{T}(sd, cd * π * partials(d)), Dual{T}(cd, -sd * π * partials(d)))
 end
 
 # Symmetric eigvals #
@@ -816,6 +811,4 @@ for op in (:(Base.typemin), :(Base.typemax), :(Base.floatmin), :(Base.floatmax))
     end
 end
 
-if VERSION >= v"1.6.0-rc1"
-    Printf.tofloat(d::Dual) = Printf.tofloat(value(d))
-end
+Printf.tofloat(d::Dual) = Printf.tofloat(value(d))

src/prelude.jl

@@ -1,10 +1,5 @@
-@static if VERSION >= v"1.6"
-    const NANSAFE_MODE_ENABLED = @load_preference("nansafe_mode", false)
-    const DEFAULT_CHUNK_THRESHOLD = @load_preference("default_chunk_threshold", 12)
-else
-    const NANSAFE_MODE_ENABLED = false
-    const DEFAULT_CHUNK_THRESHOLD = 12
-end
+const NANSAFE_MODE_ENABLED = @load_preference("nansafe_mode", false)
+const DEFAULT_CHUNK_THRESHOLD = @load_preference("default_chunk_threshold", 12)
 
 const AMBIGUOUS_TYPES = (AbstractFloat, Irrational, Integer, Rational, Real, RoundingMode)
 

test/DualTest.jl

@@ -178,10 +178,8 @@ ForwardDiff.:≺(::Type{OuterTestTag}, ::Type{TestTag}) = false
         @test div(NESTED_FDNUM, PRIMAL2) === div(PRIMAL, PRIMAL2)
         @test div(PRIMAL, NESTED_FDNUM2) === div(PRIMAL, PRIMAL2)
 
-        if VERSION ≥ v"1.4"
-            @test div(FDNUM, FDNUM2, RoundUp) === div(PRIMAL, PRIMAL2, RoundUp)
-            @test div(NESTED_FDNUM, NESTED_FDNUM2, RoundUp) === div(PRIMAL, PRIMAL2, RoundUp)
-        end
+        @test div(FDNUM, FDNUM2, RoundUp) === div(PRIMAL, PRIMAL2, RoundUp)
+        @test div(NESTED_FDNUM, NESTED_FDNUM2, RoundUp) === div(PRIMAL, PRIMAL2, RoundUp)
 
         @test Base.rtoldefault(typeof(FDNUM)) ≡ Base.rtoldefault(typeof(PRIMAL))
         @test Dual{TestTag()}(PRIMAL-eps(V), PARTIALS) ≈ FDNUM
@@ -554,9 +552,7 @@ ForwardDiff.:≺(::Type{OuterTestTag}, ::Type{TestTag}) = false
 
     @test all(map(dual_isapprox, ForwardDiff.sincos(FDNUM), (sin(FDNUM), cos(FDNUM))))
 
-    if VERSION >= v"1.6.0-DEV.292"
-        @test all(map(dual_isapprox, sincospi(FDNUM), (sinpi(FDNUM), cospi(FDNUM))))
-    end
+    @test all(map(dual_isapprox, sincospi(FDNUM), (sinpi(FDNUM), cospi(FDNUM))))
 
     if V === Float32
         @test typeof(sqrt(FDNUM)) === typeof(FDNUM)
@@ -589,7 +585,7 @@ ForwardDiff.:≺(::Type{OuterTestTag}, ::Type{TestTag}) = false
         @test pq isa Tuple{Dual{TestTag()},Dual{TestTag()}}
         # We have to adjust tolerances if lower accuracy is requested
         # Therefore we don't use `dual_isapprox`
-        tol = V === Float32 ? 5f-4 : 1e-6
+        tol = V === Float32 ? 5f-4 : 1e-5
         tol = tol^(one(tol) / 2^(isempty(ind) ? 0 : first(ind)))
         for i in 1:2
             @test value(pq[i]) ≈ gamma_inc(a, 1 + PRIMAL, ind...)[i] rtol=tol
@@ -648,13 +644,11 @@ end
     @test length(UnitRange(Dual(1.5,1), Dual(3.5,3))) == 3
 end
 
-if VERSION >= v"1.6.0-rc1"
-    @testset "@printf" begin
-        for T in (Float16, Float32, Float64, BigFloat)
-            d1 = Dual(one(T))
-            @test_nowarn @printf("Testing @printf: %.2e\n", d1)
-            @test @sprintf("Testing @sprintf: %.2e\n", d1) == "Testing @sprintf: 1.00e+00\n"
-        end
+@testset "@printf" begin
+    for T in (Float16, Float32, Float64, BigFloat)
+        d1 = Dual(one(T))
+        @test_nowarn @printf("Testing @printf: %.2e\n", d1)
+        @test @sprintf("Testing @sprintf: %.2e\n", d1) == "Testing @sprintf: 1.00e+00\n"
     end
 end
 

test/GradientTest.jl

@@ -207,15 +207,13 @@ end
     # Issue 536, version with 3-arg *, Julia 1.7:
     @test ForwardDiff.derivative(x -> sum(x*a*b), 0.0) ≈ sum(a * b)
 
-    if VERSION >= v"1.3"
-        # version with just mul!
-        dx = ForwardDiff.derivative(0.0) do x
-            c = similar(a, typeof(x))
-            mul!(c, a, b, x, false)
-            sum(c)
-        end
-        @test dx ≈ sum(a * b)
+    # version with just mul!
+    dx = ForwardDiff.derivative(0.0) do x
+        c = similar(a, typeof(x))
+        mul!(c, a, b, x, false)
+        sum(c)
     end
+    @test dx ≈ sum(a * b)
 end
 
 end # module

test/runtests.jl

@@ -46,12 +46,10 @@ Random.seed!(SEED)
         t = @elapsed include("MiscTest.jl")
         println("##### done (took $t seconds).")
     end
-    if VERSION >= v"1.5-"
-        @testset "Allocations" begin
-            println("##### Testing allocations...")
-            t = @elapsed include("AllocationsTest.jl")
-            println("##### done (took $t seconds).")
-        end
+    @testset "Allocations" begin
+        println("##### Testing allocations...")
+        t = @elapsed include("AllocationsTest.jl")
+        println("##### done (took $t seconds).")
     end
     println("##### Running all ForwardDiff tests took $(time() - t0) seconds.")
-end
+end