Skip to content

Commit 2d79dad

Browse files
committed
Jacobian tests: disable some tests on 1.0
Julia 1.0 misses some ldiv!() variants
1 parent fc3a292 commit 2d79dad

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

test/JacobianTest.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ end
107107
@testset "$f(x::Vector)::Vector" for f in DiffTests.VECTOR_TO_VECTOR_FUNCS
108108
# skip sparse_ldiv() due to missing ldiv!(::Matrix, ::SparseMatrix, ::Matrix)
109109
# FIMXE use @test ... broken= once Julia v1.0 support is dropped
110-
(f == DiffTests.sparse_ldiv) && continue
110+
(f == DiffTests.sparse_ldiv) && continue
111+
# required ldiv!(triag, adjoint) that is not implemented in 1.0
112+
(JULIA_VERSION < v"1.1") && (f in [DiffTests.utriag_div, DiffTests.ltriag_div, DiffTests.sp_utriag_div, DiffTests.sp_ltriag_div]) && continue
111113

112114
v = f(X)
113115
j = ForwardDiff.jacobian(f, X)
@@ -134,6 +136,8 @@ end
134136
# skip sparse_ldiv() due to missing ldiv!(::Matrix, ::SparseMatrix, ::Matrix)
135137
# FIMXE use @test ... broken= once Julia v1.0 support is dropped
136138
(f == DiffTests.sparse_ldiv) && continue
139+
# required ldiv!(triag, adjoint) that is not implemented in 1.0
140+
(JULIA_VERSION < v"1.1") && (f in [DiffTests.utriag_div, DiffTests.ltriag_div, DiffTests.sp_utriag_div, DiffTests.sp_ltriag_div]) && continue
137141

138142
v = f(XX)
139143
j = ForwardDiff.jacobian(f, XX)

0 commit comments

Comments
 (0)