Skip to content

Are the Factorization rules correct for Complex inputs? #101

Open
@oxinabox

Description

@oxinabox

I see in https://github.com/JuliaDiff/ChainRules.jl/blob/master/src/rulesets/LinearAlgebra/factorization.jl

we use a fair bit of A' which is adjoint.
In other places @simeonschaub has said we need to not use that, and to use transpose instread,
so we don't recursively conjugate the complex numbers

Metadata

Metadata

Assignees

No one assigned

    Labels

    testingRelated to tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions