Skip to content

Commit c09d2c0

Browse files
committed
EVMHost: Note about newly created accounts not being rolled back
1 parent 41363d7 commit c09d2c0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/EVMHost.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ evmc::Result EVMHost::call(evmc_message const& _message) noexcept
359359
auto& destination = accounts[message.recipient];
360360
if (message.kind == EVMC_CREATE || message.kind == EVMC_CREATE2)
361361
// Mark account as created if it is a CREATE or CREATE2 call
362+
// TODO: Should we roll changes back on failure like we do for `accounts`?
362363
m_newlyCreatedAccounts.emplace(message.recipient);
363364

364365
if (value != 0 && message.kind != EVMC_DELEGATECALL && message.kind != EVMC_CALLCODE)

0 commit comments

Comments
 (0)