Skip to content

Commit 3aaa207

Browse files
cameelcameel
committed
Enable unoptimized presets in those external tests where they now pass
1 parent 5e32a72 commit 3aaa207

File tree

15 files changed

+37
-35
lines changed

15 files changed

+37
-35
lines changed

‎test/externalTests/bleeps.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ function bleeps_test
4646
local compile_only_presets=()
4747
local settings_presets=(
4848
"${compile_only_presets[@]}"
49-
#ir-no-optimize # Compilation fails with: "YulException: Variable param_0 is 2 slot(s) too deep inside the stack."
50-
#ir-optimize-evm-only # Compilation fails with: "YulException: Variable param_0 is 2 slot(s) too deep inside the stack."
49+
#ir-no-optimize # Compilation fails with: "YulException: Variable expr_15509_mpos is 4 too deep in the stack". No memoryguard was present.
50+
#ir-optimize-evm-only # Compilation fails with: "YulException: Variable expr_15260_mpos is 4 too deep in the stack". No memoryguard was present.
5151
ir-optimize-evm+yul
5252
#legacy-no-optimize # Compilation fails with: "CompilerError: Stack too deep, try removing local variables."
5353
#legacy-optimize-evm-only # Compilation fails with: "CompilerError: Stack too deep, try removing local variables."

‎test/externalTests/brink.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ function brink_test
4545
local extra_optimizer_settings="runs: 800"
4646

4747
local compile_only_presets=(
48-
#ir-no-optimize # Compilation fails with "YulException: Variable var_signature_127_offset is 2 slot(s) too deep inside the stack."
49-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_signature_127_offset is 2 slot(s) too deep inside the stack."
48+
ir-no-optimize # Lots of test failures. Tests depend on constants.js, which seems to be calculated specifically for 0.8.10.
49+
ir-optimize-evm-only # Lots of test failures. Tests depend on constants.js, which seems to be calculated specifically for 0.8.10.
5050
ir-optimize-evm+yul # Lots of test failures. Tests depend on constants.js, which seems to be calculated specifically for 0.8.10.
5151
legacy-optimize-evm+yul # Lots of test failures. Tests depend on constants.js, which seems to be calculated specifically for 0.8.10.
5252
legacy-no-optimize # Lots of test failures. Tests depend on constants.js, which seems to be calculated specifically for 0.8.10.

‎test/externalTests/chainlink.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ function chainlink_test
4747
)
4848
local settings_presets=(
4949
"${compile_only_presets[@]}"
50-
#ir-no-optimize # Compilation fails with "YulException: Variable var__value_775 is 1 slot(s) too deep inside the stack."
51-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var__value_10 is 1 slot(s) too deep inside the stack"
50+
#ir-no-optimize # Compilation fails with "YulException: Variable expr_10724_mpos is 2 too deep in the stack". No memoryguard was present.
51+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable expr_1891_mpos is 2 too deep in the stack". No memoryguard was present.
5252
ir-optimize-evm+yul
5353
legacy-optimize-evm-only # NOTE: This requires >= 4 GB RAM in CI not to crash
5454
legacy-optimize-evm+yul # NOTE: This requires >= 4 GB RAM in CI not to crash

‎test/externalTests/elementfi.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ function elementfi_test
4545
local compile_only_presets=(
4646
# ElementFi's test suite is hard-coded for Mainnet forked via alchemy.io.
4747
# Locally we can only compile.
48-
#ir-no-optimize # Compilation fails with "YulException: Variable var_amount_9311 is 10 slot(s) too deep inside the stack."
49-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_amount_9311 is 10 slot(s) too deep inside the stack."
48+
ir-no-optimize
49+
ir-optimize-evm-only
5050
ir-optimize-evm+yul
5151
legacy-no-optimize
5252
legacy-optimize-evm-only

‎test/externalTests/ens.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ function ens_test
4242
local config_file="hardhat.config.js"
4343

4444
local compile_only_presets=(
45+
ir-no-optimize # FIXME: Tests fail with "Error: cannot estimate gas; transaction may fail or may require manual gas limit"
4546
legacy-no-optimize # Compiles but tests fail to deploy GovernorCompatibilityBravo (code too large).
4647
)
4748
local settings_presets=(
4849
"${compile_only_presets[@]}"
49-
#ir-no-optimize # Compilation fails with "YulException: Variable var__945 is 1 slot(s) too deep inside the stack."
50-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var__945 is 1 slot(s) too deep inside the stack."
51-
ir-optimize-evm+yul # Needs memory-safe inline assembly patch
50+
ir-optimize-evm-only
51+
ir-optimize-evm+yul # Needs memory-safe inline assembly patch
5252
legacy-optimize-evm-only
5353
legacy-optimize-evm+yul
5454
)

‎test/externalTests/euler.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ function euler_test
4747
local compile_only_presets=()
4848
local settings_presets=(
4949
"${compile_only_presets[@]}"
50-
#ir-no-optimize # Compilation fails with "YulException: Variable var_utilisation_307 is 6 slot(s) too deep inside the stack."
51-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_utilisation_307 is 6 slot(s) too deep inside the stack."
50+
#ir-no-optimize # Compilation fails with "YulException: Variable var_v_mpos is 4 too deep in the stack". No memoryguard was present.
51+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_v_mpos is 4 too deep in the stack". No memoryguard was present.
5252
ir-optimize-evm+yul
5353
legacy-optimize-evm-only
5454
legacy-optimize-evm+yul

‎test/externalTests/gnosis.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ function gnosis_safe_test
4545
local compile_only_presets=()
4646
local settings_presets=(
4747
"${compile_only_presets[@]}"
48-
#ir-no-optimize # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
49-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_call_430_mpos is 1 slot(s) too deep inside the stack."
48+
#ir-no-optimize # Compilation fails with "YulException: Variable var_txHash is 1 too deep in the stack". No memoryguard was present.
49+
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_txHash is 1 too deep in the stack". No memoryguard was present.
5050
# TODO: Uncomment the preset below when the issue: https://github.com/safe-global/safe-contracts/issues/544 is solved.
5151
#ir-optimize-evm+yul # Compilation fails with "YulException: Cannot swap Variable var_operation with Variable _1: too deep in the stack by 4 slots."
5252
legacy-no-optimize

‎test/externalTests/gp2.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ function gp2_test
4343
local config_var="config"
4444

4545
local compile_only_presets=(
46-
legacy-no-optimize # Tests doing `new GPv2VaultRelayer` fail with "Error: Transaction reverted: trying to deploy a contract whose code is too large"
46+
ir-no-optimize # Tests fail with "Error: Transaction reverted: trying to deploy a contract whose code is too large"
47+
legacy-no-optimize # Tests fail with "Error: Transaction reverted: trying to deploy a contract whose code is too large"
4748
)
4849
local settings_presets=(
4950
"${compile_only_presets[@]}"
50-
#ir-no-optimize # Compilation fails with "YulException: Variable var_amount_1468 is 10 slot(s) too deep inside the stack."
51-
#ir-no-optimize # Compilation fails with "YulException: Variable var_offset_3451 is 1 slot(s) too deep inside the stack."
51+
ir-optimize-evm-only
5252
ir-optimize-evm+yul
5353
legacy-optimize-evm-only
5454
legacy-optimize-evm+yul

‎test/externalTests/perpetual-pools.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ function perpetual_pools_test
4545
local compile_only_presets=()
4646
local settings_presets=(
4747
"${compile_only_presets[@]}"
48-
#ir-no-optimize # Compilation fails with "YulException: Variable var_amount_527 is 9 slot(s) too deep inside the stack."
49-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_amount_527 is 9 slot(s) too deep inside the stack."
48+
ir-no-optimize
49+
ir-optimize-evm-only
5050
ir-optimize-evm+yul
5151
legacy-no-optimize
5252
legacy-optimize-evm-only

‎test/externalTests/pool-together.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ function pool_together_test
4545
local compile_only_presets=()
4646
local settings_presets=(
4747
"${compile_only_presets[@]}"
48-
#ir-no-optimize # Compilation fails with "YulException: Variable var_amount_205 is 9 slot(s) too deep inside the stack."
49-
#ir-optimize-evm-only # Compilation fails with "YulException: Variable var_amount_205 is 9 slot(s) too deep inside the stack."
48+
ir-no-optimize
49+
ir-optimize-evm-only
5050
ir-optimize-evm+yul
5151
legacy-no-optimize
5252
legacy-optimize-evm-only

0 commit comments

Comments
 (0)