Skip to content

Commit bbef7a7

Browse files
authored
refactor(types): simplify types (react-bootstrap#5708)
1 parent 9199b49 commit bbef7a7

17 files changed

+39
-66
lines changed

src/Accordion.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ import AccordionContext from './AccordionContext';
1111
import AccordionHeader from './AccordionHeader';
1212
import AccordionItem from './AccordionItem';
1313
import {
14-
BsPrefixPropsWithChildren,
14+
BsPrefixProps,
1515
BsPrefixRefForwardingComponent,
1616
SelectCallback,
1717
} from './helpers';
1818

1919
export interface AccordionProps
2020
extends Omit<React.HTMLAttributes<HTMLElement>, 'onSelect'>,
21-
BsPrefixPropsWithChildren {
21+
BsPrefixProps {
2222
activeKey?: string;
2323
defaultActiveKey?: string;
2424
onSelect?: SelectCallback;

src/AccordionBody.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,10 @@ import PropTypes from 'prop-types';
55
import { useBootstrapPrefix } from './ThemeProvider';
66
import AccordionCollapse from './AccordionCollapse';
77
import AccordionItemContext from './AccordionItemContext';
8-
import {
9-
BsPrefixRefForwardingComponent,
10-
BsPrefixPropsWithChildren,
11-
} from './helpers';
8+
import { BsPrefixRefForwardingComponent, BsPrefixProps } from './helpers';
129

1310
export interface AccordionBodyProps
14-
extends BsPrefixPropsWithChildren,
11+
extends BsPrefixProps,
1512
React.HTMLAttributes<HTMLElement> {}
1613

1714
const propTypes = {

src/AccordionButton.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,14 @@ import classNames from 'classnames';
44
import PropTypes from 'prop-types';
55
import AccordionContext from './AccordionContext';
66
import AccordionItemContext from './AccordionItemContext';
7-
import {
8-
BsPrefixPropsWithChildren,
9-
BsPrefixRefForwardingComponent,
10-
} from './helpers';
7+
import { BsPrefixProps, BsPrefixRefForwardingComponent } from './helpers';
118
import { useBootstrapPrefix } from './ThemeProvider';
129

1310
type EventHandler = React.EventHandler<React.SyntheticEvent>;
1411

1512
export interface AccordionButtonProps
1613
extends React.ButtonHTMLAttributes<HTMLButtonElement>,
17-
BsPrefixPropsWithChildren {}
14+
BsPrefixProps {}
1815

1916
const propTypes = {
2017
/** Set a custom element for this component */

src/AccordionCollapse.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@ import { Transition } from 'react-transition-group';
66
import { useBootstrapPrefix } from './ThemeProvider';
77
import Collapse, { CollapseProps } from './Collapse';
88
import AccordionContext from './AccordionContext';
9-
import {
10-
BsPrefixRefForwardingComponent,
11-
BsPrefixAndClassNameOnlyProps,
12-
} from './helpers';
9+
import { BsPrefixRefForwardingComponent, BsPrefixOnlyProps } from './helpers';
1310

1411
export interface AccordionCollapseProps
15-
extends BsPrefixAndClassNameOnlyProps,
12+
extends BsPrefixOnlyProps,
1613
CollapseProps {
1714
eventKey: string;
1815
}

src/AccordionHeader.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@ import * as React from 'react';
33
import PropTypes from 'prop-types';
44
import { useBootstrapPrefix } from './ThemeProvider';
55
import AccordionButton from './AccordionButton';
6-
import {
7-
BsPrefixRefForwardingComponent,
8-
BsPrefixPropsWithChildren,
9-
} from './helpers';
6+
import { BsPrefixRefForwardingComponent, BsPrefixProps } from './helpers';
107

118
export interface AccordionHeaderProps
12-
extends BsPrefixPropsWithChildren,
9+
extends BsPrefixProps,
1310
React.HTMLAttributes<HTMLElement> {}
1411

1512
const propTypes = {

src/AccordionItem.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@ import { useBootstrapPrefix } from './ThemeProvider';
66
import AccordionItemContext, {
77
AccordionItemContextValue,
88
} from './AccordionItemContext';
9-
import {
10-
BsPrefixRefForwardingComponent,
11-
BsPrefixPropsWithChildren,
12-
} from './helpers';
9+
import { BsPrefixRefForwardingComponent, BsPrefixProps } from './helpers';
1310

1411
export interface AccordionItemProps
15-
extends BsPrefixPropsWithChildren,
12+
extends BsPrefixProps,
1613
React.HTMLAttributes<HTMLElement> {
1714
eventKey: string;
1815
}

src/Button.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,14 @@ import PropTypes from 'prop-types';
44

55
import { useBootstrapPrefix } from './ThemeProvider';
66
import SafeAnchor from './SafeAnchor';
7-
import {
8-
BsPrefixPropsWithChildren,
9-
BsPrefixRefForwardingComponent,
10-
} from './helpers';
7+
import { BsPrefixProps, BsPrefixRefForwardingComponent } from './helpers';
118
import { ButtonVariant } from './types';
129

1310
export type ButtonType = 'button' | 'reset' | 'submit' | string;
1411

1512
export interface ButtonProps
1613
extends React.HTMLAttributes<HTMLElement>,
17-
BsPrefixPropsWithChildren {
14+
BsPrefixProps {
1815
active?: boolean;
1916
variant?: ButtonVariant;
2017
size?: 'sm' | 'lg';

src/CardImg.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import PropTypes from 'prop-types';
55
import { useBootstrapPrefix } from './ThemeProvider';
66
import { BsPrefixProps, BsPrefixRefForwardingComponent } from './helpers';
77

8-
export interface CardImgProps extends BsPrefixProps {
8+
export interface CardImgProps
9+
extends BsPrefixProps,
10+
React.ImgHTMLAttributes<HTMLImageElement> {
911
variant?: 'top' | 'bottom';
1012
}
1113

src/FormRange.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import classNames from 'classnames';
22
import PropTypes from 'prop-types';
33
import * as React from 'react';
44
import { useBootstrapPrefix } from './ThemeProvider';
5-
import { BsPrefixAndClassNameOnlyProps } from './helpers';
5+
import { BsPrefixOnlyProps } from './helpers';
66

77
export interface FormRangeProps
8-
extends BsPrefixAndClassNameOnlyProps,
8+
extends BsPrefixOnlyProps,
99
Omit<React.InputHTMLAttributes<HTMLInputElement>, 'type'> {}
1010

1111
const propTypes = {

src/FormSelect.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@ import classNames from 'classnames';
22
import PropTypes from 'prop-types';
33
import * as React from 'react';
44
import { useBootstrapPrefix } from './ThemeProvider';
5-
import {
6-
BsPrefixAndClassNameOnlyProps,
7-
BsPrefixRefForwardingComponent,
8-
} from './helpers';
5+
import { BsPrefixOnlyProps, BsPrefixRefForwardingComponent } from './helpers';
96

107
export interface FormSelectProps
11-
extends BsPrefixAndClassNameOnlyProps,
8+
extends BsPrefixOnlyProps,
129
React.HTMLAttributes<HTMLSelectElement> {
1310
htmlSize?: number;
1411
size?: 'sm' | 'lg';

0 commit comments

Comments
 (0)