Boundary folders broken with v3.9.2 and v3.13.2 no longer uses "packages/packageA/node_modules/**" for allowImportsFrom

[carolinejparr]

For v3.9.2, with independentModules.jsonc setup as

{
  "modules": [
    {
      "name": "App folder",
      "pattern": "packages/packageA/src/app/**",      
      "allowImportsFrom": [
        "packages/packageA/src/features/**",
        "packages/packageA/src/app/**", 
        "{sharedImports}",
        "packages/packageA/node_modules/**" // internal workspace packages and external packages
      ]
    },
    {
      "name": "Features",
      "pattern": "packages/packageA/src/features/**",      
      "allowImportsFrom": [
        "packages/packageA/src/features/*/*.tsx",
        "{family_3}/**",
        "{sharedImports}",
        "packages/packageA/node_modules/**" // internal workspace packages and external packages
      ],
      "errorMessage": "🔥 A feature may only import items from shared folders and its own family. Importing items from another feature is prohibited. 🔥"
    },
    {
      "name": "Shared",
      "pattern": [
        "packages/packageA/src/components/**",
        "packages/packageA/src/models/**",
        "packages/packageA/src/public/**",
        "packages/packageA/src/services/**",
        "packages/packageA/src/state/**",
        "packages/packageA/src/tools/**",
        "packages/packageA/src/tests/**",
        "packages/packageA/src/hooks/**",
        "packages/packageA/src/utils/**"
      ],      
      "allowImportsFrom": [
        "{sharedImports}",
        "packages/packageA/node_modules/**" // internal workspace packages and external packages
      ],
      "errorMessage": "🔥 Shared folders are not allowed to import items from the `features` and `app` folders. 🔥"
    },    
    {
      "name": "Unknown files",
      "pattern": [
        [
          "packages/packageA/src/**",
          "!packages/packageA/src/*"
        ]
      ],
      "allowExternalImports": false,
      "allowImportsFrom": ["packages/packageA/node_modules/**"],
      "errorMessage": "🔥 This file is not specified as an independent module in `independentModules.jsonc`. 🔥"
    }
  ],
  "reusableImportPatterns": {
    "sharedImports": [
      "packages/packageA/src/components/**",
      "packages/packageA/src/models/**",
      "packages/packageA/src/public/**",
      "packages/packageA/src/services/**",
      "packages/packageA/src/state/**",
      "packages/packageA/src/tests/**",
      "packages/packageA/src/tools/**",
      "packages/packageA/src/hooks/**",
      "packages/packageA/src/utils/**"
    ]
  }

using statements for internal workspace packages and external packages are picked up with packages/packageA/node_modules/**, but folder boundaries are not picked up, for example if a feature file was used inside the shared folder, it would not throw an error when linting, which it should

When upgrading to the latest version v3.13.2, packages/packageA/node_modules/** no longer works and aliases are needed, but folder boundaries are picked up.
Aliases for folders that are generated on build, do not pick up correctly. I have used { debugMode: true } to help with debugging.

Would it be possible to reinstate the "packages/packageA/node_modules/**" usage, so that I do not need to use path aliases to pick up individual packages?

[Igorkowalski94]

Hi @carolinejparr, could you prepare a simple repository where I can test your problem?

[Igorkowalski94]

@carolinejparr Can you prepare a simple repository where this issue occurs? That way, I’ll be able to help you faster.

[Igorkowalski94]

@carolinejparr I understand that you mean a folder structure like this, right?

.
├── ...
├── 📂 node_modules <-- Here is the eslint-plugin-project-structure
├── 📄 independentModules.mjs
└── 📂 packages
    ├── 📂 packageA
    │   ├── ...
    │   └── 📂 node_modules
    └── 📂 packageB
        ├── ...
        └── 📂 node_modules
       

[carolinejparr]

@Igorkowalski94 Folder structure like

|-packages
  |- packageA
  |  |- node_modules
  |  |- eslint.config.js  // sets up location of eslint-plugin-project-structure files
  |  |- independentModules.jsonc
  |  |- fileComposition.jsonc
  |  |- folderStructure.ts
  |  |- src
  |     |- app  
  |     |- features
  |     |- components  
  |     |- ...
  |- packageB
     |- node_modules
     |- src

[Igorkowalski94]

@carolinejparr Update to v3.13.3 and try this:

.
├── ...
├── 📂 node_modules <-- Here is the eslint-plugin-project-structure (shared between packages)
└── 📂 packages
    ├── 📂 packageA
    │   ├── ...
    │   ├── 📄 independentModules.mjs
    │   └── 📂 node_modules
    └── 📂 packageB
        ├── ...
        ├── 📄 independentModules.mjs
        └── 📂 node_modules

./packages/packageA/independentModules.mjs

{
  "packageRoot": "./packages/packageA", // Set packageRoot here.
  "modules": [
    {
      "name": "App folder",
      "pattern": "packages/packageA/src/app/**",      
      "allowImportsFrom": [
        "packages/packageA/src/features/**",
        "packages/packageA/src/app/**", 
        "{sharedImports}",
      ]
    },
    {
      "name": "Features",
      "pattern": "packages/packageA/src/features/**",      
      "allowImportsFrom": [
        "packages/packageA/src/features/*/*.tsx",
        "{family_3}/**",
        "{sharedImports}",
      ],
      "errorMessage": "🔥 A feature may only import items from shared folders and its own family. Importing items from another feature is prohibited. 🔥"
    },
    {
      "name": "Shared",
      "pattern": [
        "packages/packageA/src/components/**",
        "packages/packageA/src/models/**",
        "packages/packageA/src/public/**",
        "packages/packageA/src/services/**",
        "packages/packageA/src/state/**",
        "packages/packageA/src/tools/**",
        "packages/packageA/src/tests/**",
        "packages/packageA/src/hooks/**",
        "packages/packageA/src/utils/**"
      ],      
      "allowImportsFrom": [
        "{sharedImports}",
      ],
      "errorMessage": "🔥 Shared folders are not allowed to import items from the `features` and `app` folders. 🔥"
    },    
    {
      "name": "Unknown files",
      "pattern": [
        [
          "packages/packageA/src/**",
          "!packages/packageA/src/*"
        ]
      ],
      "allowExternalImports": false,
      "allowImportsFrom": [],
      "errorMessage": "🔥 This file is not specified as an independent module in `independentModules.jsonc`. 🔥"
    }
  ],
  "reusableImportPatterns": {
    "sharedImports": [
      "packages/packageA/src/components/**",
      "packages/packageA/src/models/**",
      "packages/packageA/src/public/**",
      "packages/packageA/src/services/**",
      "packages/packageA/src/state/**",
      "packages/packageA/src/tests/**",
      "packages/packageA/src/tools/**",
      "packages/packageA/src/hooks/**",
      "packages/packageA/src/utils/**"
    ]
  }
}

[carolinejparr]

@Igorkowalski94 Any news on how to fix it?

[Igorkowalski94]

@carolinejparr

1. git pull
2. Remove node_nodules from root and packageA, packageB
3. cd to project root and pnpm i
4. cd to packages/packageA pnpm i and pnpm build and pnpm lint
5. cd to packages/packageB pnpm i and pnpm build and pnpm lint

[carolinejparr]

Those new changes to the demo project worked 👍
I have updated my project and it also now works 😀

Thank you so much for your help

[carolinejparr]

The solution was:

• install eslint-plugin-project-structure in root folder to be used in package/packageA
• remove eslint-plugin-project-structure from package/packageA
• convert jsonc files to ts

eslint.config.js

• import ts files
• add extra brackets around file mapping ie files: eslintConfig.files.map((file) =>
• add extra commas and semicolons so that each line as an appropriate ending

fileComposition.ts

• define projectRoot to point to packages/packageA
• change keys to have no commas
• add extra commas and semicolons so that each line as an appropriate ending

folderStructure.ts

• define projectRoot to point to packages/packageA
• add extra commas so that each line as an appropriate ending

independentModules.ts

• define projectRoot to point to packages/packageA
• change keys to have no commas
• use family_5 instead of family_3
• node_modules are now picked up automatically so they do not need mentioning