document last additions from Lai Quang Duong

rbri · rbri · commit 684e362ea2fb · 2026-03-12T08:23:19.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,18 @@
 
     <body>
         <release version="5.0.0" date="April 01, 2026" description="jdk17, Bugfixes">
+            <action type="add" dev="Lai Quang Duong">
+                Intl: supportedLocalesOf() implementation added to DateTimeFormat and NumberFormat.
+            </action>
+            <action type="add" dev="Lai Quang Duong">
+                Intl: getCanonicalLocales() implementation added
+            </action>
+            <action type="add" dev="Lai Quang Duong">
+                Intl.Locale implementation added.
+            </action>
+            <action type="fix" dev="Kanoko Yamamoto">
+                Storage: fix storeSize calculation when overwriting existing key
+            </action>
             <action type="update" dev="Lai Quang Duong">
                 In sync with the spec, a form now maintains a past names map at the form level, not on individual elements.
                 The map is populated only when form.xyz resolves to a single element, and entries are invalidated when the element's form owner changes.
diff --git a/src/main/java/org/htmlunit/javascript/host/event/EventHandler.java b/src/main/java/org/htmlunit/javascript/host/event/EventHandler.java
@@ -63,6 +63,7 @@ public Object call(final Context cx, final Scriptable scope,
         // compile "just in time"
         if (realFunction_ == null) {
             final String js = "function on" + eventName_ + "(event) { " + jsSnippet_ + " \n}";
+            // HtmlUnitScriptable scope = scope.getTopLevelScope(scope);
             realFunction_ = cx.compileFunction(scope, js, eventName_ + " event for " + node_
                                     + " in " + node_.getPage().getUrl(), 0, null);
             realFunction_.setParentScope(scope);
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/DateTimeFormat.java b/src/main/java/org/htmlunit/javascript/host/intl/DateTimeFormat.java
@@ -46,6 +46,7 @@
  *
  * @author Ahmed Ashour
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 @JsxClass
 public class DateTimeFormat extends HtmlUnitScriptable {
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/Intl.java b/src/main/java/org/htmlunit/javascript/host/intl/Intl.java
@@ -62,7 +62,8 @@ public static void init(final Scriptable scope, final ScriptableObject globalThi
         intl.defineProperties(scope, browserVersion);
 
         // Configure static functions (getCanonicalLocales)
-        final ClassConfiguration intlConfig = AbstractJavaScriptConfiguration.getClassConfiguration(Intl.class, browserVersion);
+        final ClassConfiguration intlConfig =
+                AbstractJavaScriptConfiguration.getClassConfiguration(Intl.class, browserVersion);
         if (intlConfig != null) {
             defineStaticFunctions(intlConfig, intl, intl);
         }
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/Locale.java b/src/main/java/org/htmlunit/javascript/host/intl/Locale.java
@@ -197,61 +197,81 @@ private static void setUnicodeKeyword(final java.util.Locale.Builder builder,
         builder.setUnicodeLocaleKeyword(unicodeKey, s);
     }
 
-    /** @return the language */
+    /**
+     * @return the language
+     */
     @JsxGetter
     public Object getLanguage() {
         return language_ != null ? language_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the script */
+    /**
+     * @return the script
+     */
     @JsxGetter
     public Object getScript() {
         return script_ != null ? script_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the region */
+    /**
+     * @return the region
+     */
     @JsxGetter
     public Object getRegion() {
         return region_ != null ? region_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the calendar type */
+    /**
+     * @return the calendar type
+     */
     @JsxGetter
     public Object getCalendar() {
         return calendar_ != null ? calendar_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the collation type */
+    /**
+     * @return the collation type
+     */
     @JsxGetter
     public Object getCollation() {
         return collation_ != null ? collation_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the numbering system */
+    /**
+     * @return the numbering system
+     */
     @JsxGetter
     public Object getNumberingSystem() {
         return numberingSystem_ != null ? numberingSystem_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the case first setting */
+    /**
+     * @return the case first setting
+     */
     @JsxGetter
     public Object getCaseFirst() {
         return caseFirst_ != null ? caseFirst_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return the hour cycle */
+    /**
+     * @return the hour cycle
+     */
     @JsxGetter
     public Object getHourCycle() {
         return hourCycle_ != null ? hourCycle_ : JavaScriptEngine.UNDEFINED;
     }
 
-    /** @return whether numeric sorting is used */
+    /**
+     * @return whether numeric sorting is used
+     */
     @JsxGetter
     public boolean isNumeric() {
         return numeric_;
     }
 
-    /** @return the base name (without Unicode extensions) */
+    /**
+     * @return the base name (without Unicode extensions)
+     */
     @JsxGetter
     public Object getBaseName() {
         final String variant = locale_.getVariant().replace("_", "-");
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/NumberFormat.java b/src/main/java/org/htmlunit/javascript/host/intl/NumberFormat.java
@@ -41,6 +41,7 @@
  *
  * @author Ahmed Ashour
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 @JsxClass
 public class NumberFormat extends HtmlUnitScriptable {
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/DateTimeFormatTest.java b/src/test/java/org/htmlunit/javascript/host/intl/DateTimeFormatTest.java
@@ -29,6 +29,7 @@
  *
  * @author Ronald Brill
  * @author Ahmed Ashour
+ * @author Lai Quang Duong
  */
 public class DateTimeFormatTest extends WebDriverTestCase {
 
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/NumberFormatTest.java b/src/test/java/org/htmlunit/javascript/host/intl/NumberFormatTest.java
@@ -23,6 +23,7 @@
  * Tests for {@link NumberFormat}.
  *
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 public class NumberFormatTest extends WebDriverTestCase {
 

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@`
`46`	`46`	`*`
`47`	`47`	`* @author Ahmed Ashour`
`48`	`48`	`* @author Ronald Brill`
	`49`	`+ * @author Lai Quang Duong`
`49`	`50`	`*/`
`50`	`51`	`@JsxClass`
`51`	`52`	`public class DateTimeFormat extends HtmlUnitScriptable {`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,8 @@ public static void init(final Scriptable scope, final ScriptableObject globalThi`
`62`	`62`	`intl.defineProperties(scope, browserVersion);`
`63`	`63`
`64`	`64`	`// Configure static functions (getCanonicalLocales)`
`65`		`- final ClassConfiguration intlConfig = AbstractJavaScriptConfiguration.getClassConfiguration(Intl.class, browserVersion);`
	`65`	`+ final ClassConfiguration intlConfig =`
	`66`	`+ AbstractJavaScriptConfiguration.getClassConfiguration(Intl.class, browserVersion);`
`66`	`67`	`if (intlConfig != null) {`
`67`	`68`	`defineStaticFunctions(intlConfig, intl, intl);`
`68`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`	`*`
`42`	`42`	`* @author Ahmed Ashour`
`43`	`43`	`* @author Ronald Brill`
	`44`	`+ * @author Lai Quang Duong`
`44`	`45`	`*/`
`45`	`46`	`@JsxClass`
`46`	`47`	`public class NumberFormat extends HtmlUnitScriptable {`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@`
`29`	`29`	`*`
`30`	`30`	`* @author Ronald Brill`
`31`	`31`	`* @author Ahmed Ashour`
	`32`	`+ * @author Lai Quang Duong`
`32`	`33`	`*/`
`33`	`34`	`public class DateTimeFormatTest extends WebDriverTestCase {`
`34`	`35`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`* Tests for {@link NumberFormat}.`
`24`	`24`	`*`
`25`	`25`	`* @author Ronald Brill`
	`26`	`+ * @author Lai Quang Duong`
`26`	`27`	`*/`
`27`	`28`	`public class NumberFormatTest extends WebDriverTestCase {`
`28`	`29`