Skip to content

Commit fb878a0

Browse files
authored
refactor(bff): embed bff libs within api library type (#63)
1 parent 19940f0 commit fb878a0

26 files changed

+42
-38
lines changed

apps/blog-bff/src/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ import {
1212
LanguageCodeFilterEnum,
1313
} from '@angular-love/wp/graphql/data-access';
1414
import { toArticle, toArticlePreviewList } from './mappers';
15-
import { articles } from '@angular-love/api';
15+
import { articles } from '@angular-love/blog-bff/articles/api';
1616
import { HTTPException } from 'hono/http-exception';
17-
import { authors } from '@angular-love/blog/bff/authors';
17+
import { authors } from '@angular-love/blog-bff/authors/api';
1818

1919
type Bindings = {
2020
GRAPHQL_URI: string;

libs/blog-bff/articles/README.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

libs/blog-bff/articles/.eslintrc.json renamed to libs/blog-bff/articles/api/.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": ["../../../.eslintrc.json"],
2+
"extends": ["../../../../.eslintrc.json"],
33
"ignorePatterns": ["!**/*"],
44
"overrides": [
55
{

libs/blog-bff/articles/api/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# api-articles
2+
3+
This library was generated with [Nx](https://nx.dev).
4+
5+
## Running unit tests
6+
7+
Run `nx test api-articles` to execute the unit tests via [Jest](https://jestjs.io).
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/* eslint-disable */
22
export default {
3-
displayName: 'api',
4-
preset: '../../../jest.preset.js',
3+
displayName: 'api-articles',
4+
preset: '../../../../jest.preset.js',
55
testEnvironment: 'node',
66
transform: {
77
'^.+\\.[tj]s$': ['ts-jest', { tsconfig: '<rootDir>/tsconfig.spec.json' }],
88
},
99
moduleFileExtensions: ['ts', 'js', 'html'],
10-
coverageDirectory: '../../../coverage/libs/blog-bff/articles',
10+
coverageDirectory: '../../../../coverage/libs/blog-bff/articles/api',
1111
};
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
{
2-
"name": "api",
3-
"$schema": "../../../node_modules/nx/schemas/project-schema.json",
4-
"sourceRoot": "libs/blog-bff/articles/src",
2+
"name": "api-articles",
3+
"$schema": "../../../../node_modules/nx/schemas/project-schema.json",
4+
"sourceRoot": "libs/blog-bff/articles/api/src",
55
"projectType": "library",
6+
"tags": [],
67
"targets": {
78
"lint": {
89
"executor": "@nx/eslint:lint",
910
"outputs": ["{options.outputFile}"],
1011
"options": {
11-
"lintFilePatterns": ["libs/blog-bff/articles/**/*.ts"]
12+
"lintFilePatterns": ["libs/blog-bff/articles/api/**/*.ts"]
1213
}
1314
},
1415
"test": {
1516
"executor": "@nx/jest:jest",
1617
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
1718
"options": {
18-
"jestConfig": "libs/blog-bff/articles/jest.config.ts"
19+
"jestConfig": "libs/blog-bff/articles/api/jest.config.ts"
1920
}
2021
}
21-
},
22-
"tags": []
22+
}
2323
}

libs/blog-bff/articles/tsconfig.json renamed to libs/blog-bff/articles/api/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "../../../tsconfig.base.json",
2+
"extends": "../../../../tsconfig.base.json",
33
"compilerOptions": {
44
"esModuleInterop": true
55
},

libs/blog-bff/articles/tsconfig.lib.json renamed to libs/blog-bff/articles/api/tsconfig.lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"extends": "./tsconfig.json",
33
"compilerOptions": {
44
"module": "commonjs",
5-
"outDir": "../../../dist/out-tsc",
5+
"outDir": "../../../../dist/out-tsc",
66
"declaration": true,
77
"types": ["node", "@cloudflare/workers-types"],
88
"esModuleInterop": true

libs/blog-bff/articles/tsconfig.spec.json renamed to libs/blog-bff/articles/api/tsconfig.spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "./tsconfig.json",
33
"compilerOptions": {
4-
"outDir": "../../../dist/out-tsc",
4+
"outDir": "../../../../dist/out-tsc",
55
"module": "commonjs",
66
"types": ["jest", "node", "@cloudflare/workers-types"]
77
},

libs/blog-bff/authors/.eslintrc.json renamed to libs/blog-bff/authors/api/.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": ["../../../.eslintrc.json"],
2+
"extends": ["../../../../.eslintrc.json"],
33
"ignorePatterns": ["!**/*"],
44
"overrides": [
55
{
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# blog-bff-authors
1+
# api-authors
22

33
This library was generated with [Nx](https://nx.dev).
44

55
## Running unit tests
66

7-
Run `nx test blog-bff-authors` to execute the unit tests.
7+
Run `nx test api-authors` to execute the unit tests.

libs/blog-bff/authors/jest.config.ts renamed to libs/blog-bff/authors/api/jest.config.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/* eslint-disable */
22
export default {
3-
displayName: 'blog-bff-authors',
4-
preset: '../../../jest.preset.js',
3+
displayName: 'api-authors',
4+
preset: '../../../../jest.preset.js',
55
setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
6-
coverageDirectory: '../../../coverage/libs/blog-bff/authors',
6+
coverageDirectory: '../../../../coverage/libs/blog-bff/authors/api',
77
transform: {
88
'^.+\\.(ts|mjs|js|html)$': [
99
'jest-preset-angular',

libs/blog-bff/authors/project.json renamed to libs/blog-bff/authors/api/project.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "blog-bff-authors",
3-
"$schema": "../../../node_modules/nx/schemas/project-schema.json",
4-
"sourceRoot": "libs/blog-bff/authors/src",
2+
"name": "api-authors",
3+
"$schema": "../../../../node_modules/nx/schemas/project-schema.json",
4+
"sourceRoot": "libs/blog-bff/authors/api/src",
55
"prefix": "al",
66
"projectType": "library",
77
"tags": [],
@@ -10,7 +10,7 @@
1010
"executor": "@nx/jest:jest",
1111
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
1212
"options": {
13-
"jestConfig": "libs/blog-bff/authors/jest.config.ts"
13+
"jestConfig": "libs/blog-bff/authors/api/jest.config.ts"
1414
}
1515
},
1616
"lint": {

libs/blog-bff/authors/tsconfig.json renamed to libs/blog-bff/authors/api/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"path": "./tsconfig.spec.json"
2020
}
2121
],
22-
"extends": "../../../tsconfig.base.json",
22+
"extends": "../../../../tsconfig.base.json",
2323
"angularCompilerOptions": {
2424
"enableI18nLegacyMessageIdFormat": false,
2525
"strictInjectionParameters": true,

libs/blog-bff/authors/tsconfig.lib.json renamed to libs/blog-bff/authors/api/tsconfig.lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "./tsconfig.json",
33
"compilerOptions": {
4-
"outDir": "../../../dist/out-tsc",
4+
"outDir": "../../../../dist/out-tsc",
55
"declaration": true,
66
"declarationMap": true,
77
"inlineSources": true,

libs/blog-bff/authors/tsconfig.spec.json renamed to libs/blog-bff/authors/api/tsconfig.spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "./tsconfig.json",
33
"compilerOptions": {
4-
"outDir": "../../../dist/out-tsc",
4+
"outDir": "../../../../dist/out-tsc",
55
"module": "commonjs",
66
"target": "es2016",
77
"types": ["jest", "node"]

tsconfig.base.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,13 @@
1515
"skipDefaultLibCheck": true,
1616
"baseUrl": ".",
1717
"paths": {
18-
"@angular-love/api": ["libs/blog-bff/articles/src/index.ts"],
1918
"@angular-love/article-card-data-model": ["libs/blog/types/src/index.ts"],
19+
"@angular-love/blog-bff/articles/api": [
20+
"libs/blog-bff/articles/api/src/index.ts"
21+
],
22+
"@angular-love/blog-bff/authors/api": [
23+
"libs/blog-bff/authors/api/src/index.ts"
24+
],
2025
"@angular-love/blog/articles/data-access": [
2126
"libs/blog/articles/data-access/src/index.ts"
2227
],
@@ -35,7 +40,6 @@
3540
"@angular-love/blog/authors/ui/author-info": [
3641
"libs/blog/authors/ui/author-info/src/index.ts"
3742
],
38-
"@angular-love/blog/bff/authors": ["libs/blog-bff/authors/src/index.ts"],
3943
"@angular-love/blog/contracts/authors": [
4044
"libs/blog-contracts/authors/src/index.ts"
4145
],

0 commit comments

Comments
 (0)