depricated scaleTier and added a new field scaleType by raazanand · Pull Request #16922 · GoogleCloudPlatform/magic-modules

raazanand · 2026-04-03T14:14:01Z

netapp: added `scaleType` field to `google_netapp_storage_pool` resource

This commit introduces the ability to specify a scale type for NetApp Storage Pools.

Changes include:

StoragePool.yaml:
- Added scaleType enum field to google_netapp_storage_pool. The scale type of the storage pool. Defaults to SCALE_TYPE_DEFAULT if not specified.

netapp: deprecated `scaleTier` field in `google_netapp_storage_pool` resource

github-actions · 2026-04-03T14:14:27Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-04-03T14:27:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 232 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 17 insertions(+), 1 deletion(-))

modular-magician · 2026-04-03T15:49:28Z

Tests analytics

Total tests: 42
Passed tests: 39
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-03T16:36:27Z

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_ScaleTypeEnterprise [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTierConfig [Error message] [Debug log]
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-03T17:17:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 232 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 17 insertions(+), 1 deletion(-))

modular-magician · 2026-04-03T18:40:02Z

Tests analytics

Total tests: 42
Passed tests: 40
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-03T19:25:53Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTierConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-04T04:14:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 232 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 17 insertions(+), 1 deletion(-))

modular-magician · 2026-04-04T05:36:11Z

Tests analytics

Total tests: 42
Passed tests: 41
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-04T06:20:55Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-04T13:13:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 232 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 17 insertions(+), 1 deletion(-))

modular-magician · 2026-04-04T14:36:35Z

Tests analytics

Total tests: 42
Passed tests: 41
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-04T15:22:39Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolume_LargeCapacityScaleTypeConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-04-04T16:38:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 226 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 232 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 45 insertions(+), 2 deletions(-))

modular-magician · 2026-04-04T16:43:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 226 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 237 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 45 insertions(+), 2 deletions(-))

modular-magician · 2026-04-04T16:43:25Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetappStoragePool_ScaleTier
TestAccNetappStoragePool_ScaleType
TestAccNetappVolume_LargeCapacityScaleTierConfig
TestAccNetappVolume_LargeCapacityScaleTypeConfig

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2026-04-04T16:48:14Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetappStoragePool_ScaleTier
TestAccNetappStoragePool_ScaleType
TestAccNetappVolume_LargeCapacityScaleTierConfig
TestAccNetappVolume_LargeCapacityScaleTypeConfig

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2026-04-04T16:48:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 224 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 235 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 44 insertions(+), 2 deletions(-))

modular-magician · 2026-04-04T16:53:32Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetappStoragePool_ScaleTier
TestAccNetappStoragePool_ScaleType
TestAccNetappVolume_LargeCapacityScaleTierConfig
TestAccNetappVolume_LargeCapacityScaleTypeConfig

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2026-04-04T17:45:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 224 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 235 insertions(+), 11 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 41 insertions(+), 2 deletions(-))

modular-magician · 2026-04-04T19:04:20Z

Tests analytics

Total tests: 42
Passed tests: 40
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-04T19:56:55Z

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_ScaleTier [Debug log]
TestAccNetappStoragePool_ScaleType [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

raazanand · 2026-04-05T05:55:10Z

mmv1/products/netapp/StoragePool.yaml

+    description: |
+      The scale type of the storage pool. Defaults to `SCALE_TYPE_DEFAULT` if not specified.
+    enum_values:
+      - 'SCALE_TYPE_UNSPECIFIED'


For consistency with other enums in netapp_storage_pool, I am keeping SCALE_TYPE_UNSPECIFIED.

#ref: #16473 (comment)

c2thorn

looks like a merge conflict needs to be resolved. LGTM otherwise.

mmv1/products/netapp/StoragePool.yaml

Co-authored-by: Cameron Thornton <camthornton@google.com>

depricated scaleTier and added a new field scaleType

97c651c

raazanand marked this pull request as draft April 3, 2026 14:14

github-actions bot requested a review from c2thorn April 3, 2026 14:14

modular-magician added the service/netapp label Apr 3, 2026

raazanand added 3 commits April 3, 2026 22:32

Trigger Build

1403a20

Trigger Build

1a360cd

Triggering build for large_volume_netapp

90aa987

fixed error

6062714

Triggering build for large_volume_netapp

87b13a0

raazanand added 3 commits April 4, 2026 21:55

implement the changes for GA as well

f7e2358

fixed functions name to avoid confusion

af91a88

fixed description for scaleType field

f76bf88

fixed function name

662e94d

raazanand marked this pull request as ready for review April 5, 2026 05:52

raazanand commented Apr 5, 2026

View reviewed changes

c2thorn requested changes Apr 6, 2026

View reviewed changes

mmv1/products/netapp/StoragePool.yaml Outdated Show resolved Hide resolved

Apply suggestion from @c2thorn

335ca83

Co-authored-by: Cameron Thornton <camthornton@google.com>

github-actions bot requested a review from c2thorn April 7, 2026 03:08

Conversation

raazanand commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

modular-magician commented Apr 3, 2026

Diff report

Uh oh!

modular-magician commented Apr 3, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 3, 2026

Uh oh!

modular-magician commented Apr 3, 2026

Diff report

Uh oh!

modular-magician commented Apr 3, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 3, 2026

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2026

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2026

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Apr 4, 2026

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Apr 4, 2026

Diff report

Uh oh!

modular-magician commented Apr 4, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 4, 2026

Uh oh!

raazanand Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

raazanand commented Apr 3, 2026 •

edited

Loading