Skip to content

Commit 0646cc5

Browse files
delsimdelsim
andauthored
Handle change in Dash meta generation (#500)
* Advance permissible Dash versions * Update version --------- Co-authored-by: delsim <[email protected]>
1 parent 8a0b27e commit 0646cc5

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

django_plotly_dash/dash_wrapper.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ def index(self, *args, **kwargs): # pylint: disable=unused-argument
763763
scripts = self._generate_scripts_html()
764764
css = self._generate_css_dist_html()
765765
config = self._generate_config_html()
766-
metas = self._generate_meta_html()
766+
metas = self._version_independent_generate_meta()
767767
renderer = self._generate_renderer()
768768
title = getattr(self, 'title', 'Dash')
769769
if self._favicon:
@@ -787,6 +787,19 @@ def index(self, *args, **kwargs): # pylint: disable=unused-argument
787787

788788
return index
789789

790+
def _version_independent_generate_meta(self):
791+
# Handle renaming of function - for older dash, call the older function if present
792+
if hasattr(self, '_generate_meta_html'):
793+
meta_str = self._generate_meta_html()
794+
else:
795+
metas = self._generate_meta()
796+
meta_strs = []
797+
for meta in metas:
798+
contribs = [f'{k}="{v}"' for k, v in meta.items()]
799+
meta_strs.append(f'<meta {" ".join(contribs)}>')
800+
meta_str = "\n".join(meta_strs)
801+
return meta_str
802+
790803
def interpolate_index(self, **kwargs): #pylint: disable=arguments-differ
791804

792805
if not self._return_embedded:

django_plotly_dash/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@
2323
2424
'''
2525

26-
__version__ = "2.3.2"
26+
__version__ = "2.4.0"

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
'Documentation': 'http://django-plotly-dash.readthedocs.io/',
4242
},
4343
install_requires = ['plotly',
44-
'dash>=2.0,<2.10',
44+
'dash>=2.0,<3.0',
4545
'dpd-components',
4646

4747
'dash-bootstrap-components',

0 commit comments

Comments
 (0)