fix clang-tidy warnings

Author: jube

.clangd

@@ -1,5 +1,5 @@
 CompileFlags:
-    CompilationDatabase: build.cmake
+    CompilationDatabase: build
 Index:
     StandardLibrary: Yes
 Diagnostics:

clang-tidy.sh

@@ -1,3 +1,3 @@
 #!/bin/sh
 
-clang-tidy -header-filter=.* -p build.cmake include/gf2/**/*.h library/core/*.cc library/graphics/*.cc library/network/*.cc library/network/bits/* library/physics/*.cc library/imgui/*.cc examples/*.cc bin/*.cc  games/**/*.cc games/**/**/*.h games/**/**/*.cc
+clang-tidy -header-filter=.* -p build include/gf2/**/*.h library/core/*.cc library/graphics/*.cc library/network/*.cc library/network/bits/* library/physics/*.cc library/imgui/*.cc examples/*.cc bin/*.cc  games/**/*.cc games/**/**/*.h games/**/**/*.cc

games/HOME/bits/BackpackEntity.cc

@@ -79,11 +79,11 @@ namespace home {
       }
     }
 
-    gf::Positioning positioning(m_hub->render_manager()->surface_size());
+    const gf::Positioning positioning(m_hub->render_manager()->surface_size());
 
     gf::ShapeGroupData shape_group_data;
 
-    gf::RectF backpack_bounds = gf::RectF::from_position_size(positioning.relative_point({ 0.95f, 0.18f }), positioning.relative_size({ 0.01f, 0.72f }));
+    const gf::RectF backpack_bounds = gf::RectF::from_position_size(positioning.relative_point({ 0.95f, 0.18f }), positioning.relative_size({ 0.01f, 0.72f }));
 
     gf::ShapeData back_shape_data = gf::ShapeData::make_rectangle(backpack_bounds);
     back_shape_data.color = gf::Black * gf::opaque(0.3f);
@@ -98,8 +98,8 @@ namespace home {
         continue;
       }
 
-      float supply_percent = static_cast<float>(supply.quantity) / static_cast<float>(LimitBackpack);
-      float supply_height = backpack_bounds.extent.h * supply_percent;
+      const float supply_percent = static_cast<float>(supply.quantity) / static_cast<float>(LimitBackpack);
+      const float supply_height = backpack_bounds.extent.h * supply_percent;
       supply_position.y -= supply_height;
 
       auto color = to_color(supply.type);
@@ -112,7 +112,7 @@ namespace home {
     }
 
     gf::RectF oxygen_bounds = gf::RectF::from_position_size(positioning.relative_point({ 0.04f, 0.18f }), positioning.relative_size({ 0.01f, 0.72f }));
-    gf::Color oxygen_color = to_color(SupplyType::Oxygen);
+    const gf::Color oxygen_color = to_color(SupplyType::Oxygen);
 
     auto oxygen_percent = static_cast<float>(m_oxygen_quantity) / static_cast<float>(MaxOxygen);
 
@@ -143,7 +143,7 @@ namespace home {
 
   void BackpackEntity::render(gf::RenderRecorder& recorder)
   {
-    gf::Positioning positioning(m_hub->render_manager()->surface_size());
+    const gf::Positioning positioning(m_hub->render_manager()->surface_size());
 
     auto icon_size = positioning.relative_size({ 0.04f, 0.0f });
 

include/gf2/core/AnimationData.h

@@ -22,7 +22,7 @@ namespace gf {
   struct GF_CORE_API AnimationFrameData {
     uint32_t texture_index = 0;
     RectF texture_region = RectF::from_size({ 0.0f, 0.0f });
-    Time duration = {};
+    Time duration;
   };
 
   template<typename Archive>

include/gf2/core/Circ.h

@@ -33,12 +33,12 @@ namespace gf {
       return radius == T(0);
     }
 
-    inline bool contains(Vec2<T> point) const noexcept
+    constexpr bool contains(Vec2<T> point) const noexcept
     {
       return gf::square_distance(center, point) <= gf::square(radius);
     }
 
-    inline bool intersects(Circ other) const noexcept
+    constexpr bool intersects(Circ other) const noexcept
     {
       return gf::square_distance(center, other.center) <= gf::square(radius + other.radius);
     }

include/gf2/core/Math.h

@@ -123,7 +123,7 @@ namespace gf {
   template<typename T>
   constexpr T clamp(T val, T lo, T hi)
   {
-    return val < lo ? lo : (hi < val ? hi : val);
+    return details::min(details::max(val, lo), hi);
   }
 
   template<typename T>

include/gf2/graphics/Animation.h

@@ -24,7 +24,7 @@ namespace gf {
 
   struct GF_GRAPHICS_API AnimationFrameRuntime {
     std::size_t texture_index = 0;
-    Time duration = {};
+    Time duration;
     std::size_t offset = 0;
   };
 
@@ -57,7 +57,7 @@ namespace gf {
 
     AnimationRuntime m_animation;
     std::size_t m_current_frame = 0;
-    Time m_current_time = {};
+    Time m_current_time;
   };
 
   class GF_GRAPHICS_API AnimationGroup {
@@ -90,7 +90,7 @@ namespace gf {
     std::map<Id, AnimationRuntime> m_animations;
     Id m_current_animation_id = InvalidId;
     std::size_t m_current_frame = 0;
-    Time m_current_time = {};
+    Time m_current_time;
   };
 }
 

include/gf2/graphics/VertexInput.h

@@ -27,8 +27,8 @@ namespace gf {
   };
 
   struct GF_GRAPHICS_API VertexInput {
-    std::vector<VertexBinding> bindings = {};
-    std::vector<VertexAttribute> attributes = {};
+    std::vector<VertexBinding> bindings;
+    std::vector<VertexAttribute> attributes;
   };
 
 }

xmake.lua

@@ -13,6 +13,7 @@ add_requires("vulkan-headers")
 add_requires("vulkan-memory-allocator")
 
 add_rules("mode.coverage", "mode.debug", "mode.releasedbg", "mode.release")
+add_rules("plugin.compile_commands.autoupdate", {outputdir = "$(buildir)"})
 
 if is_mode("sanitizers") then
     set_symbols("debug")