fix: add missing letter ё to the Russian keyboard layout#469
Conversation
The Russian layout offered no way to type ё. Long-pressing the е key only exposed the digit 5, and with the numbers row enabled the digit is stripped from the popup, leaving no popup at all — so ё was untypeable. Add ё to the popupCharacters of the е key, matching the existing convention used elsewhere (e.g. the Belarusian layout's є, ґ, щ). The Belarusian cyrillic layout already has a dedicated ё key, so it needs no change.
|
I see you have now submitted a large batch (22) of PRs in a short period. Please do not submit bulk AI-generated PRs or AI-generated issue comments. Even small diffs still require maintainer review, testing, and support after merging. See https://github.com/FossifyOrg/General-Discussion#contributing-code |
|
Thanks for the direct feedback, @naveensingh — you're right that opening that many at once was too much, regardless of how each was prepared. I've closed the ones I hadn't individually verified on a device, and removed the analysis comments, so that's off your plate. The handful still open are each a fix I reproduced and tested on an emulator for an already-accepted issue. Could I ask how you'd prefer I proceed — do you refuse well-tested pull requests for accepted, active issues that genuinely improve the apps' experience, or is the concern specifically the pace/volume (and unverified changes)? I'm glad to go at a slow trickle, one small tested fix at a time, or to step back entirely if you'd rather. Thanks for maintaining Fossify. |
|
Hi, the concern is specifically the pace/volume and validation, yes. The remaining pull requests will be reviewed on a case-by-case basis. |
Type of change(s)
What changed and why
The Russian keyboard layout offered no way to type the letter
ё:еkey only offered5.еshowed no popup at all —ёwas completely untypeable (matching the reporter's "nothing happens").Fix: add
ёto thepopupCharactersof theеkey ("5"→"5ё"), following the exact convention already used elsewhere (e.g. the Belarusian layout'sє,ґ,щ). Long-pressingеnow offersё(and5when the numbers row is off; onlyёwhen it is on).I intentionally did not apply the reporter's suggested Belarusian (cyrillic) change: that layout already has a dedicated
ёkey (app:keyLabel="ё"), soёis already directly typeable there and adding it to theеpopup would be redundant.Tests performed
Built the
fossDebugvariant and installed it on an Android 15 (API 35) emulator, with Fossify Keyboard set as the active IME and the Russian layout selected:еoffered only5.еshows a5/Ёpopup; selecting the new entry insertsёinto the text field (verified the field then containedё).There are no unit tests for keyboard layout resources; this is a static XML resource change verified manually on-device.
Closes the following issue(s)
Checklist
CHANGELOG.md.Coded with Opus 4.8 ultracode.