Skip to content

#6185 Upgrade avajs to v7#6192

Draft
ioanatflowcrypt wants to merge 4 commits intomasterfrom
6185-upgrade-avajs-to-v7
Draft

#6185 Upgrade avajs to v7#6192
ioanatflowcrypt wants to merge 4 commits intomasterfrom
6185-upgrade-avajs-to-v7

Conversation

@ioanatflowcrypt
Copy link
Collaborator

This PR upgraded avajs to v7

close #6185 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt
Copy link
Collaborator Author

@sosnovsky Could you tell me what triggers snyk failure?
I don't have acccess to snyk and can't see details.

@sosnovsky
Copy link
Collaborator

Hi @ioanatflowcrypt, error description on Snyk says Failed to parse package.json or package-lock.json as valid JSON, as there are some unresolved merge conflicts in package-lock.json - https://github.com/FlowCrypt/flowcrypt-browser/blob/6185-upgrade-avajs-to-v7/package-lock.json#L747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade avajs to v7

2 participants