Skip to content

Commit 4df670f

Browse files
#6157 Upgrade bootstrap from v4 to v5 (#6158)
* feat: upgraded to bootstrap v5 * fix: pr reviews * fix: encrypted contact page * fix: position relative
1 parent e30c969 commit 4df670f

7 files changed

Lines changed: 51 additions & 36 deletions

File tree

extension/chrome/elements/pgp_block.htm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<tbody>
2323
<tr class="print_header_info">
2424
<td class="print_user_email" data-test="print-user-email"></td>
25-
<td class="display-table float-right">
25+
<td class="display-table float-end">
2626
<span class="print_encrypted_with_label">Encrypted with</span>
2727
<img src="/img/logo/flowcrypt-logo-125-27.png" width="auto" height="22" alt="FlowCrypt a.s. Mail" class="logo" />
2828
</td>

extension/chrome/settings/index.htm

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,19 @@
2121
<section id="header-row">
2222
<div class="container">
2323
<div class="row">
24-
<div class="col-12 col-lg-6 text-left logo-row">
24+
<div class="col-12 col-lg-6 text-start logo-row">
2525
<img class="cryptup-logo" src="/img/logo/full-logo.svg" alt="FlowCrypt Logo" />
2626
<span class="subscription">
2727
<a class="level green_label short" href="https://flowcrypt.com/account">free forever</a>
2828
<span class="expire"></span>
2929
</span>
3030
</div>
3131

32-
<div class="col-12 col-lg-6 text-right">
32+
<div class="col-12 col-lg-6 text-end position-relative">
3333
<div class="profile-row">
3434
<div class="public-profile-container hide_if_setup_not_done public_profile_indicator_container" style="visibility: hidden">
3535
<div id="public-profile-indicator">
36-
<a href="https://flowcrypt.com/account" target="_blank"> Encrypted Contact Page </a>
36+
<a href="https://flowcrypt.com/account" target="_blank" class="action-open-encrypted-contact-page"> Encrypted Contact Page </a>
3737
</div>
3838
</div>
3939
<a href="#" class="email-address action-toggle-accounts-menu" data-test="action-toggle-accounts-menu"></a>
@@ -199,7 +199,7 @@ <h1 class="text-center">FlowCrypt Settings</h1>
199199
<div class="col-12 flex" style="padding-left: 0">
200200
<img src="/img/svgs/key-icon.svg" class="key-icon" alt="key icon" />
201201
<span class="my-keys-copy">My Keys</span>
202-
<span class="text-right keys-link-top-right-container">
202+
<span class="text-end keys-link-top-right-container">
203203
<a href="#" class="show_settings_page my_key_link add_key" data-test="action-open-add-key-page" page="/chrome/settings/modules/add_key.htm"
204204
>Add Key</a
205205
>
@@ -218,7 +218,7 @@ <h1 class="text-center">FlowCrypt Settings</h1>
218218
<div class="col-12 col-lg-2">
219219
<a href="#" class="show_settings_page" page="modules/help.htm" data-test="action-open-modules-help">Need Help?</a>
220220
</div>
221-
<div class="col-12 col-lg-8 row">
221+
<div class="col-12 col-lg-8 d-flex justify-content-center">
222222
<a href="https://flowcrypt.com/terms" target="_blank" class="gray_link">Terms</a>
223223
<a href="https://flowcrypt.com/privacy" target="_blank" class="gray_link">Privacy</a>
224224
<a href="https://github.com/FlowCrypt/flowcrypt-browser" target="_blank" class="gray_link advanced">Source</a>
@@ -228,7 +228,7 @@ <h1 class="text-center">FlowCrypt Settings</h1>
228228
>
229229
</span>
230230
</div>
231-
<div class="col-12 col-lg-2 text-right hide_if_setup_not_done">
231+
<div class="col-12 col-lg-2 text-end hide_if_setup_not_done">
232232
<a class="toggle-settings advanced" href="#" data-test="action-toggle-screen-basic">Basic Settings</a
233233
><a class="toggle-settings basic" href="#" data-test="action-toggle-screen-additional">Additional Settings</a>
234234
</div>

extension/chrome/settings/setup.htm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
<section id="header-row">
2222
<div class="container">
2323
<div class="row">
24-
<div class="col-12 col-lg-6 text-left logo-row">
24+
<div class="col-12 col-lg-6 text-start logo-row">
2525
<img class="cryptup-logo" src="/img/logo/full-logo.svg" alt="FlowCrypt Logo" />
2626
</div>
2727

28-
<div class="col-12 col-lg-6 text-right">
28+
<div class="col-12 col-lg-6 text-end">
2929
<div class="profile-row">
3030
<div class="public-profile-container hide_if_setup_not_done public_profile_indicator_container" style="visibility: hidden"></div>
3131
<a href="#" class="email-address action-toggle-accounts-menu" data-test="action-toggle-accounts-menu"></a>

extension/css/settings.css

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,19 @@ html {
4747
display: none;
4848
}
4949

50+
#header-row .action-open-encrypted-contact-page,
51+
#header-row .action-toggle-accounts-menu,
52+
#footer-row a {
53+
text-decoration: none;
54+
}
55+
56+
#header-row .action-open-encrypted-contact-page:hover,
57+
#header-row .action-toggle-accounts-menu:hover,
58+
#footer-row a:hover {
59+
color: #0056b3;
60+
text-decoration: underline;
61+
}
62+
5063
#header-row .logo-row a.cryptup-logo-row {
5164
text-decoration: none;
5265
}
@@ -332,12 +345,17 @@ a.gray_link {
332345
padding: 36px 0;
333346
}
334347

348+
.profile-row {
349+
position: relative;
350+
}
351+
335352
#settings-row .box {
336353
background-color: #31a217;
337354

338355
/* background-image: -webkit-linear-gradient(140deg, #31A217 -40%, green 0%, #31A217 100%);
339356
*/
340357
border: 0;
358+
position: relative;
341359
border-top-left-radius: 3px;
342360
border-top-right-radius: 3px;
343361
display: block;
@@ -870,4 +888,4 @@ span.fc-badge {
870888
.fc-badge-light-gray {
871889
background-color: #bcbcbc;
872890
color: #444 !important;
873-
}
891+
}

extension/js/common/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ export class Settings {
427427
return [
428428
`<a href="#" ${isHeaderRow && 'id = "header-row"'} class="row alt-accounts action_select_account">`,
429429
` <div class="col-2"><img class="profile-img" src="${Xss.escape(picture)}" alt=""></div>`,
430-
' <div class="col-10 text-left">',
430+
' <div class="col-10 text-start">',
431431
` <div class="contains_email" data-test="action-switch-to-account">${Xss.escape(email)}</div>`,
432432
' </div>',
433433
'</a>',

package-lock.json

Lines changed: 20 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@
4848
"@zxcvbn-ts/core": "^3.0.4",
4949
"@zxcvbn-ts/language-common": "^3.0.4",
5050
"@zxcvbn-ts/language-en": "^3.0.2",
51-
"bootstrap": "4.6.2",
51+
"bootstrap": "^5.3.3",
5252
"dompurify": "3.3.1",
5353
"filesize": "11.0.13",
5454
"fs-extra": "^11.3.3",
5555
"globby": "^16.1.0",
56-
"jquery": "^3.7.1",
56+
"jquery": "^4.0.0",
5757
"linkify-html": "4.3.2",
5858
"linkifyjs": "4.3.2",
5959
"node-forge": "1.3.3",

0 commit comments

Comments
 (0)